Re: [PATCH] rcu: fix section mismatch

[Randy Dunlap <randy.dunlap@oracle.com>]

Sam Ravnborg wrote:
> On Mon, Jan 21, 2008 at 03:34:09PM -0800, Randy Dunlap wrote:
>> On Mon, 21 Jan 2008 11:38:38 +1100 Rusty Russell wrote:
>>
>>> On Sunday 20 January 2008 08:25:49 Sam Ravnborg wrote:
>>>> On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote:
>>>>> rcu_online_cpu() should be __cpuinit instead of __devinit.
>>>> So if we have:
>>>> CONFIG_HOTPLUG=n
>>>> CONFIG_HOTPLUG_CPU=y
>>>>
>>>> then this is a oops candidate.
>>> At first glance, this can't happen because all CONFIG_HOTPLUG_CPU depends on 
>>> CONFIG_HOTPLUG or selects it, for all archs.
>> Mostly, but arch/mips/ seems to be different (neither depends nor selects)
>> unless it has changed very recently (I looked at 2.6.24-rc8).
> 
> mips has
> 	default n
> 
> So they at least try to turn off this feature.

OK.

ISTM that conflating CONFIG_HOTPLUG and CONFIG_HOTPLUG_CPU is both a
mistake and confusing.  CONFIG_HOTPLUG help text specifically talks
about hot-pluggable devices and /dev.  I can imagine some engineers
saying that CPUs and MEM are (abstract) devices, but I don't think that
most users would go that far, so I think that HOTPLUG and HOTPLUG_CPU
should be totally independent.

-- 
~Randy