From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Cc: devel@lists.laptop.org
Subject: Re: GRUB on OLPC / XO
Date: Mon, 21 Jan 2008 12:33:11 +0100 [thread overview]
Message-ID: <20080121113311.GB7949@thorin> (raw)
In-Reply-To: <87d4rvxyq3.fsf@xs4all.nl>
On Mon, Jan 21, 2008 at 11:24:52AM +0100, Marco Gerards wrote:
> >
> > _start: 0x10000, _end: 0x1f804
> > Using memory for heap: addr=0x100000, end=0x400000
> > Using memory for heap: addr=0x2000, end=0x9ffff
> > Welcome to GRUB!
> >
> > See how our core image and the second heap chunk overlap. I'm not sure if this
> > is a bug in OFW's /memory/available, but in any case it doesn't hurt to add a
> > generic sanity check in our memory manager to avoid this sort of breakage.
> >
> > It's also be useful to protect our own stack, etc..
> >
> > What do you think?
>
> At least some kind of check should be available. It could also be in
> init.c.
Yep.
I concluded that there's nothing usefuly portable about having this in kern/,
and proposed:
[PATCH] safety check in claim_heap()
see my other mail below.
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)
next prev parent reply other threads:[~2008-01-21 11:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-12 3:14 GRUB on OLPC / XO Robert Millan
2008-01-15 11:31 ` Marco Gerards
2008-01-15 12:06 ` Robert Millan
2008-01-15 12:23 ` Marco Gerards
2008-01-15 12:32 ` Robert Millan
2008-01-15 12:48 ` Marco Gerards
2008-01-15 16:36 ` Robert Millan
2008-01-21 10:24 ` Marco Gerards
2008-01-21 11:33 ` Robert Millan [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-01-12 13:42 Robert Millan
2008-01-12 14:00 ` Robert Millan
[not found] ` <4789009B.8030403@laptop.org>
2008-01-12 18:58 ` Robert Millan
[not found] ` <47891639.7070500@laptop.org>
[not found] ` <47891889.5020402@laptop.org>
2008-01-12 20:30 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080121113311.GB7949@thorin \
--to=rmh@aybabtu.com \
--cc=devel@lists.laptop.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.