From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] abort when core.img is too big
Date: Mon, 21 Jan 2008 16:49:49 +0100 [thread overview]
Message-ID: <20080121154949.GB6988@thorin> (raw)
In-Reply-To: <878x2jw76n.fsf@xs4all.nl>
On Mon, Jan 21, 2008 at 04:05:04PM +0100, Marco Gerards wrote:
> Robert Millan <rmh@aybabtu.com> writes:
>
> > With the addition of memdisk, it is too easy for user to create an image
> > big enough that would corrupt upper memory (starting with vga region). This
> > happens at roughly ~600 kiB memdisk size.
> >
> > This patch adds a check in grub-mkimage to prevent this. I did also take
> > the opportunity to reuse the upper memory macro to avoid hardcoding its
> > address for VGA stuff.
> >
> > Comments?
>
> This makes sense to me.
Ok, committed.
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)
prev parent reply other threads:[~2008-01-21 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 14:44 [PATCH] abort when core.img is too big Robert Millan
2008-01-21 15:05 ` Marco Gerards
2008-01-21 15:49 ` Robert Millan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080121154949.GB6988@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.