Re: [PATCH] memdisk + grub-mkrescue

[Robert Millan <rmh@aybabtu.com>]

On Wed, Jan 23, 2008 at 11:45:19AM +0100, Marco Gerards wrote:
> Robert Millan <rmh@aybabtu.com> writes:
> 
> > These two were predestined to get together..  attached patch for their
> > wedding.
> >
> > Comments?
> >
> > -- 
> > Robert Millan
> >
> > <GPLv2> I know my rights; I want my phone call!
> > <DRM> What use is a phone call… if you are unable to speak?
> > (as seen on /.)
> >
> >
> > 	* kern/i386/pc/init.c (make_install_device): When memdisk image is
> > 	present, "(memdisk)/boot/grub" becomes the default prefix.
> 
> Sounds sane to me.
> 
> > 	* util/i386/pc/grub-mkrescue.in: Switch to a minimal core.img plus
> > 	a memdisk tarball with all the modules.  Add --overlay=DIR option that
> > 	allows users to overlay additional files into the image.
> 
> Overlay means that I can add a grub.cfg easily?

It means you can do:

mkdir -p boot/grub
zile boot/grub/grub.cfg
grub-mkrescue --overlay=boot

Of course, it'd be easier if you could just add it directly, but I really
think having this in a separate directory is a good idea (in case user wants
to add random stuff to her memdisk).

So I'm not sure if it can be improved.  Does it seem fine as-is ?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)