All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] memdisk + grub-mkrescue
Date: Mon, 21 Jan 2008 12:47:06 -0500	[thread overview]
Message-ID: <1200937626.4686.17.camel@dv> (raw)
In-Reply-To: <20080121165209.GA2557@thorin>

On Mon, 2008-01-21 at 17:52 +0100, Robert Millan wrote:
> These two were predestined to get together..  attached patch for their
> wedding.
> 
> Comments?

I really like the ability to add more things than just modules
(especially grub.cfg and fonts).  Is that the main motivation for your
patch?  Or you have some other things in mind?

I've tested the patch, and it seems to be OK, although I was surprised
to see an empty menu on startup.  Perhaps a command line would be more
appropriate in absence of grub.cfg?

I don't quite understand why "biosdisk" needs to be mandatory.  I guess
it's not initialized by default, so that it doesn't conflict with the
ata module.  But ata can load on top of biosdisk (but not the other way
around).

-- 
Regards,
Pavel Roskin



  reply	other threads:[~2008-01-21 17:47 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-21 16:52 [PATCH] memdisk + grub-mkrescue Robert Millan
2008-01-21 17:47 ` Pavel Roskin [this message]
2008-01-21 21:06   ` Robert Millan
2008-01-22  2:11     ` Pavel Roskin
2008-01-22 14:02       ` Robert Millan
2008-01-22 14:55         ` Pavel Roskin
2008-01-22 15:17           ` Robert Millan
2008-01-23  7:51             ` Pavel Roskin
2008-01-23  9:15               ` Robert Millan
2008-01-23 15:22                 ` Pavel Roskin
2008-01-23 19:03                   ` Marco Gerards
2008-01-23 19:28                     ` Pavel Roskin
2008-01-31 14:35                       ` Robert Millan
2008-01-31 17:12                         ` Pavel Roskin
2008-01-31 17:35                           ` Marco Gerards
2008-01-31 18:00                             ` Pavel Roskin
2008-01-31 18:50                               ` Marco Gerards
2008-01-31 20:13                                 ` Pavel Roskin
2008-01-21 21:09   ` grub_cpio_find_file() finds unexisting files (Re: [PATCH] memdisk + grub-mkrescue) Robert Millan
2008-01-22  2:01     ` Pavel Roskin
2008-01-22 10:12       ` Bean
2008-01-23 10:45 ` [PATCH] memdisk + grub-mkrescue Marco Gerards
2008-01-23 11:01   ` Robert Millan
2008-01-23 11:20     ` Marco Gerards
2008-01-23 11:25       ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1200937626.4686.17.camel@dv \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.