All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] use at_keyboard.c on i386-ieee1275
Date: Wed, 23 Jan 2008 12:56:18 +0100	[thread overview]
Message-ID: <20080123115618.GE27060@thorin> (raw)
In-Reply-To: <87fxword4x.fsf@xs4all.nl>

On Wed, Jan 23, 2008 at 12:32:14PM +0100, Marco Gerards wrote:
> >         * conf/i386-ieee1275.rmk (kernel_elf_SOURCES): Add
> >         `term/i386/pc/at_keyboard.c'.
> >
> >         * include/grub/i386/ieee1275/console.h: Add `<grub/symbol.h>'.  Remove
> >         `<grub/powerpc/ieee1275/console.h>'.
> >         (grub_keyboard_controller_init): New function prototype.
> >         (grub_console_checkkey): Likewise.
> >         (grub_console_getkey): Likewise.
> >
> >         * kern/powerpc/ieee1275/init.c (grub_machine_init): Initialize AT
> >         keyboard on i386.
> >
> >         * term/ieee1275/ofconsole.c (grub_ofconsole_term): On i386, use
> >         grub_ofconsole_checkkey() and grub_ofconsole_getkey() for input.
> 
> Looks fine to me.

Done.  I also enabled serial.mod.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)



  reply	other threads:[~2008-01-23 11:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-23 10:47 [PATCH] use at_keyboard.c on i386-ieee1275 Robert Millan
2008-01-23 10:58 ` Marco Gerards
2008-01-23 11:18   ` Robert Millan
2008-01-23 11:32     ` Marco Gerards
2008-01-23 11:56       ` Robert Millan [this message]
2008-01-24  8:40       ` Yoshinori K. Okuji
2008-01-24  9:10         ` Marco Gerards
2008-01-24 12:39         ` Robert Millan
2008-01-24 12:56           ` Marco Gerards
2008-01-24 21:26           ` Yoshinori K. Okuji
2008-01-24 21:55             ` Robert Millan
2008-01-25  8:56             ` Marco Gerards
2008-01-25 21:22               ` Yoshinori K. Okuji
2008-01-25 22:57                 ` next release & NEWS file (Re: [PATCH] use at_keyboard.c on i386-ieee1275) Robert Millan
2008-01-27  8:01                   ` Pavel Roskin
2008-01-27 22:03                     ` Robert Millan
2008-01-28  8:53                 ` [PATCH] use at_keyboard.c on i386-ieee1275 Marco Gerards

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080123115618.GE27060@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.