* [PATCH] [MIPS]: constify function pointer tables
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
@ 2008-01-22 19:42 ` Jan Engelhardt
2008-01-23 0:32 ` Ralf Baechle
2008-02-07 12:41 ` [PATCH] [MIPS]: fix CAC_ADDR/UNCAC_ADDR peter fuerst
2008-01-22 19:43 ` [PATCH] [POWERPC]: constify function pointer tables Jan Engelhardt
` (15 subsequent siblings)
16 siblings, 2 replies; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:42 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
---
arch/mips/basler/excite/excite_iodev.c | 2 +-
arch/mips/kernel/proc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/basler/excite/excite_iodev.c b/arch/mips/basler/excite/excite_iodev.c
index 6af0b21..476d20e 100644
--- a/arch/mips/basler/excite/excite_iodev.c
+++ b/arch/mips/basler/excite/excite_iodev.c
@@ -48,7 +48,7 @@ static DECLARE_WAIT_QUEUE_HEAD(wq);
-static struct file_operations fops =
+static const struct file_operations fops =
{
.owner = THIS_MODULE,
.open = iodev_open,
diff --git a/arch/mips/kernel/proc.c b/arch/mips/kernel/proc.c
index 6e6e947..f30e035 100644
--- a/arch/mips/kernel/proc.c
+++ b/arch/mips/kernel/proc.c
@@ -89,7 +89,7 @@ static void c_stop(struct seq_file *m, void *v)
{
}
-struct seq_operations cpuinfo_op = {
+const struct seq_operations cpuinfo_op = {
.start = c_start,
.next = c_next,
.stop = c_stop,
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH] [POWERPC]: constify function pointer tables
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
2008-01-22 19:42 ` [PATCH] [MIPS]: constify function pointer tables Jan Engelhardt
@ 2008-01-22 19:43 ` Jan Engelhardt
2008-01-22 23:11 ` Stephen Rothwell
2008-01-22 19:44 ` [PATCH] [CRYPTO]: " Jan Engelhardt
` (14 subsequent siblings)
16 siblings, 1 reply; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:43 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
---
arch/powerpc/kernel/setup-common.c | 2 +-
arch/powerpc/platforms/cell/spufs/inode.c | 2 +-
arch/powerpc/platforms/pseries/hvCall_inst.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 2de00f8..57d4f28 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -296,7 +296,7 @@ static void c_stop(struct seq_file *m, void *v)
{
}
-struct seq_operations cpuinfo_op = {
+const struct seq_operations cpuinfo_op = {
.start =c_start,
.next = c_next,
.stop = c_stop,
diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c
index c0e968a..d99fcda 100644
--- a/arch/powerpc/platforms/cell/spufs/inode.c
+++ b/arch/powerpc/platforms/cell/spufs/inode.c
@@ -110,7 +110,7 @@ spufs_new_file(struct super_block *sb, struct dentry *dentry,
const struct file_operations *fops, int mode,
struct spu_context *ctx)
{
- static struct inode_operations spufs_file_iops = {
+ static const struct inode_operations spufs_file_iops = {
.setattr = spufs_setattr,
};
struct inode *inode;
diff --git a/arch/powerpc/platforms/pseries/hvCall_inst.c b/arch/powerpc/platforms/pseries/hvCall_inst.c
index eae51ef..3631a4f 100644
--- a/arch/powerpc/platforms/pseries/hvCall_inst.c
+++ b/arch/powerpc/platforms/pseries/hvCall_inst.c
@@ -71,7 +71,7 @@ static int hc_show(struct seq_file *m, void *p)
return 0;
}
-static struct seq_operations hcall_inst_seq_ops = {
+static const struct seq_operations hcall_inst_seq_ops = {
.start = hc_start,
.next = hc_next,
.stop = hc_stop,
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH] [CRYPTO]: constify function pointer tables
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
2008-01-22 19:42 ` [PATCH] [MIPS]: constify function pointer tables Jan Engelhardt
2008-01-22 19:43 ` [PATCH] [POWERPC]: constify function pointer tables Jan Engelhardt
@ 2008-01-22 19:44 ` Jan Engelhardt
2008-03-13 11:38 ` Herbert Xu
2008-01-22 19:44 ` [PATCH] ACPI: " Jan Engelhardt
` (13 subsequent siblings)
16 siblings, 1 reply; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:44 UTC (permalink / raw)
To: Herbert Xu; +Cc: linux-crypto
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
---
crypto/proc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/crypto/proc.c b/crypto/proc.c
index 3d73323..24164b2 100644
--- a/crypto/proc.c
+++ b/crypto/proc.c
@@ -78,7 +78,7 @@ static int c_show(struct seq_file *m, void *p)
return 0;
}
-static struct seq_operations crypto_seq_ops = {
+static const struct seq_operations crypto_seq_ops = {
.start = c_start,
.next = c_next,
.stop = c_stop,
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH] ACPI: constify function pointer tables
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
` (2 preceding siblings ...)
2008-01-22 19:44 ` [PATCH] [CRYPTO]: " Jan Engelhardt
@ 2008-01-22 19:44 ` Jan Engelhardt
2008-01-22 19:47 ` [PATCH] NET: constify data and " Jan Engelhardt
` (12 subsequent siblings)
16 siblings, 0 replies; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:44 UTC (permalink / raw)
To: Len Brown; +Cc: linux-acpi
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
---
drivers/acpi/battery.c | 2 +-
drivers/acpi/ec.c | 2 +-
drivers/acpi/processor_perflib.c | 2 +-
drivers/acpi/processor_thermal.c | 2 +-
drivers/acpi/processor_throttling.c | 2 +-
drivers/acpi/sbs.c | 14 +++++++-------
drivers/acpi/video.c | 10 +++++-----
include/acpi/processor.h | 4 ++--
8 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
index c4a769d..e164029 100644
--- a/drivers/acpi/battery.c
+++ b/drivers/acpi/battery.c
@@ -713,7 +713,7 @@ DECLARE_FILE_FUNCTIONS(alarm);
static struct battery_file {
struct file_operations ops;
mode_t mode;
- char *name;
+ const char *name;
} acpi_battery_file[] = {
FILE_DESCRIPTION_RO(info),
FILE_DESCRIPTION_RO(state),
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 97dc161..0efbd51 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -629,7 +629,7 @@ static int acpi_ec_info_open_fs(struct inode *inode, struct file *file)
return single_open(file, acpi_ec_read_info, PDE(inode)->data);
}
-static struct file_operations acpi_ec_info_ops = {
+static const struct file_operations acpi_ec_info_ops = {
.open = acpi_ec_info_open_fs,
.read = seq_read,
.llseek = seq_lseek,
diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c
index 463b024..263a136 100644
--- a/drivers/acpi/processor_perflib.c
+++ b/drivers/acpi/processor_perflib.c
@@ -389,7 +389,7 @@ EXPORT_SYMBOL(acpi_processor_notify_smm);
/* /proc/acpi/processor/../performance interface (DEPRECATED) */
static int acpi_processor_perf_open_fs(struct inode *inode, struct file *file);
-static struct file_operations acpi_processor_perf_fops = {
+static const struct file_operations acpi_processor_perf_fops = {
.open = acpi_processor_perf_open_fs,
.read = seq_read,
.llseek = seq_lseek,
diff --git a/drivers/acpi/processor_thermal.c b/drivers/acpi/processor_thermal.c
index 06e6f3f..2510928 100644
--- a/drivers/acpi/processor_thermal.c
+++ b/drivers/acpi/processor_thermal.c
@@ -382,7 +382,7 @@ static ssize_t acpi_processor_write_limit(struct file * file,
return count;
}
-struct file_operations acpi_processor_limit_fops = {
+const struct file_operations acpi_processor_limit_fops = {
.open = acpi_processor_limit_open_fs,
.read = seq_read,
.write = acpi_processor_write_limit,
diff --git a/drivers/acpi/processor_throttling.c b/drivers/acpi/processor_throttling.c
index 6742d7b..916204c 100644
--- a/drivers/acpi/processor_throttling.c
+++ b/drivers/acpi/processor_throttling.c
@@ -917,7 +917,7 @@ static ssize_t acpi_processor_write_throttling(struct file *file,
return count;
}
-struct file_operations acpi_processor_throttling_fops = {
+const struct file_operations acpi_processor_throttling_fops = {
.open = acpi_processor_throttling_open_fs,
.read = seq_read,
.write = acpi_processor_write_throttling,
diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c
index f136c7d..23c8618 100644
--- a/drivers/acpi/sbs.c
+++ b/drivers/acpi/sbs.c
@@ -479,9 +479,9 @@ static int
acpi_sbs_add_fs(struct proc_dir_entry **dir,
struct proc_dir_entry *parent_dir,
char *dir_name,
- struct file_operations *info_fops,
- struct file_operations *state_fops,
- struct file_operations *alarm_fops, void *data)
+ const struct file_operations *info_fops,
+ const struct file_operations *state_fops,
+ const struct file_operations *alarm_fops, void *data)
{
struct proc_dir_entry *entry = NULL;
@@ -694,7 +694,7 @@ static int acpi_battery_alarm_open_fs(struct inode *inode, struct file *file)
return single_open(file, acpi_battery_read_alarm, PDE(inode)->data);
}
-static struct file_operations acpi_battery_info_fops = {
+static const struct file_operations acpi_battery_info_fops = {
.open = acpi_battery_info_open_fs,
.read = seq_read,
.llseek = seq_lseek,
@@ -702,7 +702,7 @@ static struct file_operations acpi_battery_info_fops = {
.owner = THIS_MODULE,
};
-static struct file_operations acpi_battery_state_fops = {
+static const struct file_operations acpi_battery_state_fops = {
.open = acpi_battery_state_open_fs,
.read = seq_read,
.llseek = seq_lseek,
@@ -710,7 +710,7 @@ static struct file_operations acpi_battery_state_fops = {
.owner = THIS_MODULE,
};
-static struct file_operations acpi_battery_alarm_fops = {
+static const struct file_operations acpi_battery_alarm_fops = {
.open = acpi_battery_alarm_open_fs,
.read = seq_read,
.write = acpi_battery_write_alarm,
@@ -742,7 +742,7 @@ static int acpi_ac_state_open_fs(struct inode *inode, struct file *file)
return single_open(file, acpi_ac_read_state, PDE(inode)->data);
}
-static struct file_operations acpi_ac_state_fops = {
+static const struct file_operations acpi_ac_state_fops = {
.open = acpi_ac_state_open_fs,
.read = seq_read,
.llseek = seq_lseek,
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index bd77e81..25de850 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -184,7 +184,7 @@ struct acpi_video_device {
/* bus */
static int acpi_video_bus_info_open_fs(struct inode *inode, struct file *file);
-static struct file_operations acpi_video_bus_info_fops = {
+static const struct file_operations acpi_video_bus_info_fops = {
.open = acpi_video_bus_info_open_fs,
.read = seq_read,
.llseek = seq_lseek,
@@ -192,7 +192,7 @@ static struct file_operations acpi_video_bus_info_fops = {
};
static int acpi_video_bus_ROM_open_fs(struct inode *inode, struct file *file);
-static struct file_operations acpi_video_bus_ROM_fops = {
+static const struct file_operations acpi_video_bus_ROM_fops = {
.open = acpi_video_bus_ROM_open_fs,
.read = seq_read,
.llseek = seq_lseek,
@@ -201,7 +201,7 @@ static struct file_operations acpi_video_bus_ROM_fops = {
static int acpi_video_bus_POST_info_open_fs(struct inode *inode,
struct file *file);
-static struct file_operations acpi_video_bus_POST_info_fops = {
+static const struct file_operations acpi_video_bus_POST_info_fops = {
.open = acpi_video_bus_POST_info_open_fs,
.read = seq_read,
.llseek = seq_lseek,
@@ -227,7 +227,7 @@ static struct file_operations acpi_video_bus_DOS_fops = {
/* device */
static int acpi_video_device_info_open_fs(struct inode *inode,
struct file *file);
-static struct file_operations acpi_video_device_info_fops = {
+static const struct file_operations acpi_video_device_info_fops = {
.open = acpi_video_device_info_open_fs,
.read = seq_read,
.llseek = seq_lseek,
@@ -254,7 +254,7 @@ static struct file_operations acpi_video_device_brightness_fops = {
static int acpi_video_device_EDID_open_fs(struct inode *inode,
struct file *file);
-static struct file_operations acpi_video_device_EDID_fops = {
+static const struct file_operations acpi_video_device_EDID_fops = {
.open = acpi_video_device_EDID_open_fs,
.read = seq_read,
.llseek = seq_lseek,
diff --git a/include/acpi/processor.h b/include/acpi/processor.h
index 76411b1..d997361 100644
--- a/include/acpi/processor.h
+++ b/include/acpi/processor.h
@@ -315,7 +315,7 @@ static inline int acpi_processor_ppc_has_changed(struct acpi_processor *pr)
/* in processor_throttling.c */
int acpi_processor_get_throttling_info(struct acpi_processor *pr);
extern int acpi_processor_set_throttling(struct acpi_processor *pr, int state);
-extern struct file_operations acpi_processor_throttling_fops;
+extern const struct file_operations acpi_processor_throttling_fops;
/* in processor_idle.c */
int acpi_processor_power_init(struct acpi_processor *pr,
@@ -329,7 +329,7 @@ extern struct cpuidle_driver acpi_idle_driver;
/* in processor_thermal.c */
int acpi_processor_get_limit_info(struct acpi_processor *pr);
-extern struct file_operations acpi_processor_limit_fops;
+extern const struct file_operations acpi_processor_limit_fops;
#ifdef CONFIG_CPU_FREQ
void acpi_thermal_cpufreq_init(void);
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH] KVM: constify function pointer tables
[not found] ` <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh-bdq14YP6qtRlEiWPh9xO2Q@public.gmane.org>
@ 2008-01-22 19:46 ` Jan Engelhardt
[not found] ` <Pine.LNX.4.64.0801222046010.5722-vVwEwcwQeYFPkBl3ERsXe1l1cybopEuJUBSOeVevoDU@public.gmane.org>
2008-01-22 19:48 ` [PATCH] [NFS]: " Jan Engelhardt
2008-01-22 19:48 ` [NFS] [PATCH] knfsd: " Jan Engelhardt
2 siblings, 1 reply; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:46 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
Signed-off-by: Jan Engelhardt <jengelh-bdq14YP6qtRlEiWPh9xO2Q@public.gmane.org>
---
drivers/kvm/kvm_main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
index 47c10b8..7b931a8 100644
--- a/drivers/kvm/kvm_main.c
+++ b/drivers/kvm/kvm_main.c
@@ -2573,7 +2573,7 @@ static int kvm_vcpu_release(struct inode *inode, struct file *filp)
return 0;
}
-static struct file_operations kvm_vcpu_fops = {
+static const struct file_operations kvm_vcpu_fops = {
.release = kvm_vcpu_release,
.unlocked_ioctl = kvm_vcpu_ioctl,
.compat_ioctl = kvm_vcpu_ioctl,
@@ -3140,7 +3140,7 @@ static int kvm_vm_mmap(struct file *file, struct vm_area_struct *vma)
return 0;
}
-static struct file_operations kvm_vm_fops = {
+static const struct file_operations kvm_vm_fops = {
.release = kvm_vm_release,
.unlocked_ioctl = kvm_vm_ioctl,
.compat_ioctl = kvm_vm_ioctl,
--
1.5.3.4
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH] NET: constify data and function pointer tables
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
` (3 preceding siblings ...)
2008-01-22 19:44 ` [PATCH] ACPI: " Jan Engelhardt
@ 2008-01-22 19:47 ` Jan Engelhardt
2008-01-30 9:25 ` Jeff Garzik
2008-01-22 19:47 ` [PATCH] [AF_RXRPC]: constify " Jan Engelhardt
` (11 subsequent siblings)
16 siblings, 1 reply; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:47 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
---
drivers/net/bonding/bond_main.c | 2 +-
drivers/net/hamradio/bpqether.c | 2 +-
drivers/net/hamradio/scc.c | 2 +-
drivers/net/hamradio/yam.c | 2 +-
drivers/net/ibmveth.c | 2 +-
drivers/net/pppoe.c | 2 +-
drivers/net/pppol2tp.c | 4 ++--
drivers/net/wireless/libertas/debugfs.c | 14 +++++++-------
drivers/net/wireless/strip.c | 2 +-
9 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index b0b2603..ca18eaa 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -3252,7 +3252,7 @@ static int bond_info_seq_show(struct seq_file *seq, void *v)
return 0;
}
-static struct seq_operations bond_info_seq_ops = {
+static const struct seq_operations bond_info_seq_ops = {
.start = bond_info_seq_start,
.next = bond_info_seq_next,
.stop = bond_info_seq_stop,
diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c
index 5ddf8b0..a93ad86 100644
--- a/drivers/net/hamradio/bpqether.c
+++ b/drivers/net/hamradio/bpqether.c
@@ -442,7 +442,7 @@ static int bpq_seq_show(struct seq_file *seq, void *v)
return 0;
}
-static struct seq_operations bpq_seqops = {
+static const struct seq_operations bpq_seqops = {
.start = bpq_seq_start,
.next = bpq_seq_next,
.stop = bpq_seq_stop,
diff --git a/drivers/net/hamradio/scc.c b/drivers/net/hamradio/scc.c
index 353d13e..6f1b449 100644
--- a/drivers/net/hamradio/scc.c
+++ b/drivers/net/hamradio/scc.c
@@ -2071,7 +2071,7 @@ static int scc_net_seq_show(struct seq_file *seq, void *v)
return 0;
}
-static struct seq_operations scc_net_seq_ops = {
+static const struct seq_operations scc_net_seq_ops = {
.start = scc_net_seq_start,
.next = scc_net_seq_next,
.stop = scc_net_seq_stop,
diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
index 1c94286..797f7a5 100644
--- a/drivers/net/hamradio/yam.c
+++ b/drivers/net/hamradio/yam.c
@@ -788,7 +788,7 @@ static int yam_seq_show(struct seq_file *seq, void *v)
return 0;
}
-static struct seq_operations yam_seqops = {
+static const struct seq_operations yam_seqops = {
.start = yam_seq_start,
.next = yam_seq_next,
.stop = yam_seq_stop,
diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c
index 7d7758f..32800e2 100644
--- a/drivers/net/ibmveth.c
+++ b/drivers/net/ibmveth.c
@@ -1300,7 +1300,7 @@ static int ibmveth_seq_show(struct seq_file *seq, void *v)
return 0;
}
-static struct seq_operations ibmveth_seq_ops = {
+static const struct seq_operations ibmveth_seq_ops = {
.start = ibmveth_seq_start,
.next = ibmveth_seq_next,
.stop = ibmveth_seq_stop,
diff --git a/drivers/net/pppoe.c b/drivers/net/pppoe.c
index a005d8f..a38e636 100644
--- a/drivers/net/pppoe.c
+++ b/drivers/net/pppoe.c
@@ -1026,7 +1026,7 @@ static void pppoe_seq_stop(struct seq_file *seq, void *v)
read_unlock_bh(&pppoe_hash_lock);
}
-static struct seq_operations pppoe_seq_ops = {
+static const struct seq_operations pppoe_seq_ops = {
.start = pppoe_seq_start,
.next = pppoe_seq_next,
.stop = pppoe_seq_stop,
diff --git a/drivers/net/pppol2tp.c b/drivers/net/pppol2tp.c
index a7556cd..a8793b3 100644
--- a/drivers/net/pppol2tp.c
+++ b/drivers/net/pppol2tp.c
@@ -2355,7 +2355,7 @@ out:
return 0;
}
-static struct seq_operations pppol2tp_seq_ops = {
+static const struct seq_operations pppol2tp_seq_ops = {
.start = pppol2tp_seq_start,
.next = pppol2tp_seq_next,
.stop = pppol2tp_seq_stop,
@@ -2403,7 +2403,7 @@ static int pppol2tp_proc_release(struct inode *inode, struct file *file)
return seq_release(inode, file);
}
-static struct file_operations pppol2tp_proc_fops = {
+static const struct file_operations pppol2tp_proc_fops = {
.owner = THIS_MODULE,
.open = pppol2tp_proc_open,
.read = seq_read,
diff --git a/drivers/net/wireless/libertas/debugfs.c b/drivers/net/wireless/libertas/debugfs.c
index 0bda0b5..765c542 100644
--- a/drivers/net/wireless/libertas/debugfs.c
+++ b/drivers/net/wireless/libertas/debugfs.c
@@ -1569,7 +1569,7 @@ static ssize_t libertas_rdrf_write(struct file *file,
res = -EFAULT;
goto out_unlock;
}
- priv->rf_offset = simple_strtoul((char *)buf, NULL, 16);
+ priv->rf_offset = simple_strtoul(buf, NULL, 16);
res = count;
out_unlock:
free_page(addr);
@@ -1620,12 +1620,12 @@ out_unlock:
}
struct libertas_debugfs_files {
- char *name;
+ const char *name;
int perm;
struct file_operations fops;
};
-static struct libertas_debugfs_files debugfs_files[] = {
+static const struct libertas_debugfs_files debugfs_files[] = {
{ "info", 0444, FOPS(libertas_dev_info, write_file_dummy), },
{ "getscantable", 0444, FOPS(libertas_getscantable,
write_file_dummy), },
@@ -1635,7 +1635,7 @@ static struct libertas_debugfs_files debugfs_files[] = {
{ "setuserscan", 0600, FOPS(NULL, libertas_setuserscan), },
};
-static struct libertas_debugfs_files debugfs_events_files[] = {
+static const struct libertas_debugfs_files debugfs_events_files[] = {
{"low_rssi", 0644, FOPS(libertas_lowrssi_read,
libertas_lowrssi_write), },
{"low_snr", 0644, FOPS(libertas_lowsnr_read,
@@ -1650,7 +1650,7 @@ static struct libertas_debugfs_files debugfs_events_files[] = {
libertas_highsnr_write), },
};
-static struct libertas_debugfs_files debugfs_regs_files[] = {
+static const struct libertas_debugfs_files debugfs_regs_files[] = {
{"rdmac", 0644, FOPS(libertas_rdmac_read, libertas_rdmac_write), },
{"wrmac", 0600, FOPS(NULL, libertas_wrmac_write), },
{"rdbbp", 0644, FOPS(libertas_rdbbp_read, libertas_rdbbp_write), },
@@ -1677,7 +1677,7 @@ void libertas_debugfs_remove(void)
void libertas_debugfs_init_one(wlan_private *priv, struct net_device *dev)
{
int i;
- struct libertas_debugfs_files *files;
+ const struct libertas_debugfs_files *files;
if (!libertas_dir)
goto exit;
@@ -1881,7 +1881,7 @@ static ssize_t wlan_debugfs_write(struct file *f, const char __user *buf,
return (ssize_t)cnt;
}
-static struct file_operations libertas_debug_fops = {
+static const struct file_operations libertas_debug_fops = {
.owner = THIS_MODULE,
.open = open_file_generic,
.write = wlan_debugfs_write,
diff --git a/drivers/net/wireless/strip.c b/drivers/net/wireless/strip.c
index 88efe1b..cde07c6 100644
--- a/drivers/net/wireless/strip.c
+++ b/drivers/net/wireless/strip.c
@@ -1149,7 +1149,7 @@ static int strip_seq_show(struct seq_file *seq, void *v)
}
-static struct seq_operations strip_seq_ops = {
+static const struct seq_operations strip_seq_ops = {
.start = strip_seq_start,
.next = strip_seq_next,
.stop = strip_seq_stop,
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH] [AF_RXRPC]: constify function pointer tables
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
` (4 preceding siblings ...)
2008-01-22 19:47 ` [PATCH] NET: constify data and " Jan Engelhardt
@ 2008-01-22 19:47 ` Jan Engelhardt
2008-01-31 3:05 ` David Miller
[not found] ` <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh-bdq14YP6qtRlEiWPh9xO2Q@public.gmane.org>
` (10 subsequent siblings)
16 siblings, 1 reply; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:47 UTC (permalink / raw)
To: David Howells; +Cc: netdev
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
---
net/rxrpc/ar-call.c | 2 +-
net/rxrpc/ar-internal.h | 6 +++---
net/rxrpc/ar-proc.c | 6 +++---
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/net/rxrpc/ar-call.c b/net/rxrpc/ar-call.c
index 3c04b00..d923124 100644
--- a/net/rxrpc/ar-call.c
+++ b/net/rxrpc/ar-call.c
@@ -15,7 +15,7 @@
#include <net/af_rxrpc.h>
#include "ar-internal.h"
-const char *rxrpc_call_states[] = {
+const char *const rxrpc_call_states[] = {
[RXRPC_CALL_CLIENT_SEND_REQUEST] = "ClSndReq",
[RXRPC_CALL_CLIENT_AWAIT_REPLY] = "ClAwtRpl",
[RXRPC_CALL_CLIENT_RECV_REPLY] = "ClRcvRpl",
diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-internal.h
index 58aaf89..1aaa2e8 100644
--- a/net/rxrpc/ar-internal.h
+++ b/net/rxrpc/ar-internal.h
@@ -565,9 +565,9 @@ extern void __exit rxrpc_destroy_all_peers(void);
/*
* ar-proc.c
*/
-extern const char *rxrpc_call_states[];
-extern struct file_operations rxrpc_call_seq_fops;
-extern struct file_operations rxrpc_connection_seq_fops;
+extern const char *const rxrpc_call_states[];
+extern const struct file_operations rxrpc_call_seq_fops;
+extern const struct file_operations rxrpc_connection_seq_fops;
/*
* ar-recvmsg.c
diff --git a/net/rxrpc/ar-proc.c b/net/rxrpc/ar-proc.c
index 2e83ce3..83eda24 100644
--- a/net/rxrpc/ar-proc.c
+++ b/net/rxrpc/ar-proc.c
@@ -14,7 +14,7 @@
#include <net/af_rxrpc.h>
#include "ar-internal.h"
-static const char *rxrpc_conn_states[] = {
+static const char *const rxrpc_conn_states[] = {
[RXRPC_CONN_UNUSED] = "Unused ",
[RXRPC_CONN_CLIENT] = "Client ",
[RXRPC_CONN_SERVER_UNSECURED] = "SvUnsec ",
@@ -98,7 +98,7 @@ static int rxrpc_call_seq_open(struct inode *inode, struct file *file)
return seq_open(file, &rxrpc_call_seq_ops);
}
-struct file_operations rxrpc_call_seq_fops = {
+const struct file_operations rxrpc_call_seq_fops = {
.owner = THIS_MODULE,
.open = rxrpc_call_seq_open,
.read = seq_read,
@@ -183,7 +183,7 @@ static int rxrpc_connection_seq_open(struct inode *inode, struct file *file)
return seq_open(file, &rxrpc_connection_seq_ops);
}
-struct file_operations rxrpc_connection_seq_fops = {
+const struct file_operations rxrpc_connection_seq_fops = {
.owner = THIS_MODULE,
.open = rxrpc_connection_seq_open,
.read = seq_read,
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH] [NFS]: constify function pointer tables
[not found] ` <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh-bdq14YP6qtRlEiWPh9xO2Q@public.gmane.org>
2008-01-22 19:46 ` [PATCH] KVM: " Jan Engelhardt
@ 2008-01-22 19:48 ` Jan Engelhardt
2008-01-22 19:48 ` [NFS] [PATCH] knfsd: " Jan Engelhardt
2 siblings, 0 replies; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:48 UTC (permalink / raw)
To: Trond Myklebust; +Cc: linux-nfs
Signed-off-by: Jan Engelhardt <jengelh-bdq14YP6qtRlEiWPh9xO2Q@public.gmane.org>
---
fs/nfs/client.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/client.c b/fs/nfs/client.c
index a6f6254..b4832d9 100644
--- a/fs/nfs/client.c
+++ b/fs/nfs/client.c
@@ -1168,7 +1168,7 @@ static void *nfs_server_list_next(struct seq_file *p, void *v, loff_t *pos);
static void nfs_server_list_stop(struct seq_file *p, void *v);
static int nfs_server_list_show(struct seq_file *m, void *v);
-static struct seq_operations nfs_server_list_ops = {
+static const struct seq_operations nfs_server_list_ops = {
.start = nfs_server_list_start,
.next = nfs_server_list_next,
.stop = nfs_server_list_stop,
@@ -1188,7 +1188,7 @@ static void *nfs_volume_list_next(struct seq_file *p, void *v, loff_t *pos);
static void nfs_volume_list_stop(struct seq_file *p, void *v);
static int nfs_volume_list_show(struct seq_file *m, void *v);
-static struct seq_operations nfs_volume_list_ops = {
+static const struct seq_operations nfs_volume_list_ops = {
.start = nfs_volume_list_start,
.next = nfs_volume_list_next,
.stop = nfs_volume_list_stop,
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [NFS] [PATCH] knfsd: constify function pointer tables
[not found] ` <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh-bdq14YP6qtRlEiWPh9xO2Q@public.gmane.org>
2008-01-22 19:46 ` [PATCH] KVM: " Jan Engelhardt
2008-01-22 19:48 ` [PATCH] [NFS]: " Jan Engelhardt
@ 2008-01-22 19:48 ` Jan Engelhardt
2 siblings, 0 replies; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:48 UTC (permalink / raw)
To: Neil Brown; +Cc: nfs
Signed-off-by: Jan Engelhardt <jengelh-bdq14YP6qtRlEiWPh9xO2Q@public.gmane.org>
---
fs/nfsd/export.c | 2 +-
fs/nfsd/nfsctl.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
index 66d0aeb..af2da43 100644
--- a/fs/nfsd/export.c
+++ b/fs/nfsd/export.c
@@ -1539,7 +1539,7 @@ static int e_show(struct seq_file *m, void *p)
return svc_export_show(m, &svc_export_cache, cp);
}
-struct seq_operations nfs_exports_op = {
+const struct seq_operations nfs_exports_op = {
.start = e_start,
.next = e_next,
.stop = e_stop,
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index 77dc989..9d23cae 100644
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -149,7 +149,7 @@ static const struct file_operations transaction_ops = {
.release = simple_transaction_release,
};
-extern struct seq_operations nfs_exports_op;
+extern const struct seq_operations nfs_exports_op;
static int exports_open(struct inode *inode, struct file *file)
{
return seq_open(file, &nfs_exports_op);
--
1.5.3.4
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
_______________________________________________
Please note that nfs@lists.sourceforge.net is being discontinued.
Please subscribe to linux-nfs@vger.kernel.org instead.
http://vger.kernel.org/vger-lists.html#linux-nfs
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH] [MTD]: constify function pointer tables
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
` (6 preceding siblings ...)
[not found] ` <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh-bdq14YP6qtRlEiWPh9xO2Q@public.gmane.org>
@ 2008-01-22 19:49 ` Jan Engelhardt
2008-01-22 19:50 ` [PATCH] md: " Jan Engelhardt
` (8 subsequent siblings)
16 siblings, 0 replies; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:49 UTC (permalink / raw)
To: David Woohouse; +Cc: linux-mtd
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
---
drivers/mtd/ubi/cdev.c | 4 ++--
drivers/mtd/ubi/ubi.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index fe4da1e..05ed76f 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -683,14 +683,14 @@ static int ubi_cdev_ioctl(struct inode *inode, struct file *file,
}
/* UBI character device operations */
-struct file_operations ubi_cdev_operations = {
+const struct file_operations ubi_cdev_operations = {
.owner = THIS_MODULE,
.ioctl = ubi_cdev_ioctl,
.llseek = no_llseek,
};
/* UBI volume character device operations */
-struct file_operations ubi_vol_cdev_operations = {
+const struct file_operations ubi_vol_cdev_operations = {
.owner = THIS_MODULE,
.open = vol_cdev_open,
.release = vol_cdev_release,
diff --git a/drivers/mtd/ubi/ubi.h b/drivers/mtd/ubi/ubi.h
index 5e941a6..3a8ab61 100644
--- a/drivers/mtd/ubi/ubi.h
+++ b/drivers/mtd/ubi/ubi.h
@@ -361,8 +361,8 @@ struct ubi_device {
#endif
};
-extern struct file_operations ubi_cdev_operations;
-extern struct file_operations ubi_vol_cdev_operations;
+extern const struct file_operations ubi_cdev_operations;
+extern const struct file_operations ubi_vol_cdev_operations;
extern struct class *ubi_class;
/* vtbl.c */
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH] md: constify function pointer tables
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
` (7 preceding siblings ...)
2008-01-22 19:49 ` [PATCH] [MTD]: " Jan Engelhardt
@ 2008-01-22 19:50 ` Jan Engelhardt
2008-01-22 19:51 ` [PATCH] x86: " Jan Engelhardt
` (7 subsequent siblings)
16 siblings, 0 replies; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:50 UTC (permalink / raw)
To: Neil Brown; +Cc: linux-raid
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
---
drivers/md/md.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index cef9ebd..6295b90 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -5033,7 +5033,7 @@ static int md_seq_show(struct seq_file *seq, void *v)
return 0;
}
-static struct seq_operations md_seq_ops = {
+static const struct seq_operations md_seq_ops = {
.start = md_seq_start,
.next = md_seq_next,
.stop = md_seq_stop,
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH] x86: constify function pointer tables
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
` (8 preceding siblings ...)
2008-01-22 19:50 ` [PATCH] md: " Jan Engelhardt
@ 2008-01-22 19:51 ` Jan Engelhardt
2008-01-22 20:56 ` Ingo Molnar
2008-01-22 19:52 ` [PATCH] [AF_X25]: " Jan Engelhardt
` (6 subsequent siblings)
16 siblings, 1 reply; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:51 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Linux Kernel Mailing List, tglx
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
---
arch/x86/kernel/cpu/proc.c | 2 +-
arch/x86/kernel/setup_64.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/proc.c b/arch/x86/kernel/cpu/proc.c
index 3900e46..0282132 100644
--- a/arch/x86/kernel/cpu/proc.c
+++ b/arch/x86/kernel/cpu/proc.c
@@ -188,7 +188,7 @@ static void *c_next(struct seq_file *m, void *v, loff_t *pos)
static void c_stop(struct seq_file *m, void *v)
{
}
-struct seq_operations cpuinfo_op = {
+const struct seq_operations cpuinfo_op = {
.start = c_start,
.next = c_next,
.stop = c_stop,
diff --git a/arch/x86/kernel/setup_64.c b/arch/x86/kernel/setup_64.c
index 30d94d1..52ef415 100644
--- a/arch/x86/kernel/setup_64.c
+++ b/arch/x86/kernel/setup_64.c
@@ -1184,7 +1184,7 @@ static void c_stop(struct seq_file *m, void *v)
{
}
-struct seq_operations cpuinfo_op = {
+const struct seq_operations cpuinfo_op = {
.start =c_start,
.next = c_next,
.stop = c_stop,
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH] [AF_X25]: constify function pointer tables
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
` (9 preceding siblings ...)
2008-01-22 19:51 ` [PATCH] x86: " Jan Engelhardt
@ 2008-01-22 19:52 ` Jan Engelhardt
2008-01-23 2:30 ` David Miller
2008-01-22 19:53 ` [Ocfs2-devel] [PATCH] [OCFS2]: " Jan Engelhardt
` (5 subsequent siblings)
16 siblings, 1 reply; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:52 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
---
net/x25/x25_proc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/x25/x25_proc.c b/net/x25/x25_proc.c
index 7d55e50..3faec8e 100644
--- a/net/x25/x25_proc.c
+++ b/net/x25/x25_proc.c
@@ -287,7 +287,7 @@ static const struct file_operations x25_seq_route_fops = {
.release = seq_release,
};
-static struct file_operations x25_seq_forward_fops = {
+static const struct file_operations x25_seq_forward_fops = {
.owner = THIS_MODULE,
.open = x25_seq_forward_open,
.read = seq_read,
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [Ocfs2-devel] [PATCH] [OCFS2]: constify function pointer tables
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
` (10 preceding siblings ...)
2008-01-22 19:52 ` [PATCH] [AF_X25]: " Jan Engelhardt
@ 2008-01-22 19:53 ` Jan Engelhardt
2008-01-22 19:53 ` [Cluster-devel] [PATCH] [DLM]: " Jan Engelhardt
` (4 subsequent siblings)
16 siblings, 0 replies; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:53 UTC (permalink / raw)
To: ocfs2-devel
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
---
fs/ocfs2/dlmglue.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
index 4e97dcc..ba27657 100644
--- a/fs/ocfs2/dlmglue.c
+++ b/fs/ocfs2/dlmglue.c
@@ -2211,7 +2211,7 @@ static int ocfs2_dlm_seq_show(struct seq_file *m, void *v)
return 0;
}
-static struct seq_operations ocfs2_dlm_seq_ops = {
+static const struct seq_operations ocfs2_dlm_seq_ops = {
.start = ocfs2_dlm_seq_start,
.stop = ocfs2_dlm_seq_stop,
.next = ocfs2_dlm_seq_next,
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [Cluster-devel] [PATCH] [DLM]: constify function pointer tables
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
` (11 preceding siblings ...)
2008-01-22 19:53 ` [Ocfs2-devel] [PATCH] [OCFS2]: " Jan Engelhardt
@ 2008-01-22 19:53 ` Jan Engelhardt
2008-01-22 19:54 ` [PATCH] [SCSI]: " Jan Engelhardt
` (3 subsequent siblings)
16 siblings, 0 replies; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:53 UTC (permalink / raw)
To: cluster-devel.redhat.com
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
---
fs/dlm/debug_fs.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/debug_fs.c b/fs/dlm/debug_fs.c
index 12c3bfd..15333eb 100644
--- a/fs/dlm/debug_fs.c
+++ b/fs/dlm/debug_fs.c
@@ -342,7 +342,7 @@ static int rsb_seq_show(struct seq_file *file, void *iter_ptr)
return 0;
}
-static struct seq_operations rsb_seq_ops = {
+static const struct seq_operations rsb_seq_ops = {
.start = rsb_seq_start,
.next = rsb_seq_next,
.stop = rsb_seq_stop,
@@ -419,7 +419,7 @@ static void *locks_seq_start(struct seq_file *file, loff_t *pos)
return ri;
}
-static struct seq_operations locks_seq_ops = {
+static const struct seq_operations locks_seq_ops = {
.start = locks_seq_start,
.next = rsb_seq_next,
.stop = rsb_seq_stop,
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH] [SCSI]: constify function pointer tables
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
` (12 preceding siblings ...)
2008-01-22 19:53 ` [Cluster-devel] [PATCH] [DLM]: " Jan Engelhardt
@ 2008-01-22 19:54 ` Jan Engelhardt
2008-01-22 20:37 ` James Smart
2008-01-22 19:55 ` [PATCH] input: " Jan Engelhardt
` (2 subsequent siblings)
16 siblings, 1 reply; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:54 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi, axboe
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
---
drivers/scsi/lpfc/lpfc_debugfs.c | 10 +++++-----
drivers/scsi/sg.c | 8 ++++----
diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
index d6a98bc..002f541 100644
--- a/drivers/scsi/lpfc/lpfc_debugfs.c
+++ b/drivers/scsi/lpfc/lpfc_debugfs.c
@@ -715,7 +715,7 @@ lpfc_debugfs_release(struct inode *inode, struct file *file)
}
#undef lpfc_debugfs_op_disc_trc
-static struct file_operations lpfc_debugfs_op_disc_trc = {
+static const struct file_operations lpfc_debugfs_op_disc_trc = {
.owner = THIS_MODULE,
.open = lpfc_debugfs_disc_trc_open,
.llseek = lpfc_debugfs_lseek,
@@ -724,7 +724,7 @@ static struct file_operations lpfc_debugfs_op_disc_trc = {
};
#undef lpfc_debugfs_op_nodelist
-static struct file_operations lpfc_debugfs_op_nodelist = {
+static const struct file_operations lpfc_debugfs_op_nodelist = {
.owner = THIS_MODULE,
.open = lpfc_debugfs_nodelist_open,
.llseek = lpfc_debugfs_lseek,
@@ -733,7 +733,7 @@ static struct file_operations lpfc_debugfs_op_nodelist = {
};
#undef lpfc_debugfs_op_hbqinfo
-static struct file_operations lpfc_debugfs_op_hbqinfo = {
+static const struct file_operations lpfc_debugfs_op_hbqinfo = {
.owner = THIS_MODULE,
.open = lpfc_debugfs_hbqinfo_open,
.llseek = lpfc_debugfs_lseek,
@@ -742,7 +742,7 @@ static struct file_operations lpfc_debugfs_op_hbqinfo = {
};
#undef lpfc_debugfs_op_dumpslim
-static struct file_operations lpfc_debugfs_op_dumpslim = {
+static const struct file_operations lpfc_debugfs_op_dumpslim = {
.owner = THIS_MODULE,
.open = lpfc_debugfs_dumpslim_open,
.llseek = lpfc_debugfs_lseek,
@@ -751,7 +751,7 @@ static struct file_operations lpfc_debugfs_op_dumpslim = {
};
#undef lpfc_debugfs_op_slow_ring_trc
-static struct file_operations lpfc_debugfs_op_slow_ring_trc = {
+static const struct file_operations lpfc_debugfs_op_slow_ring_trc = {
.owner = THIS_MODULE,
.open = lpfc_debugfs_slow_ring_trc_open,
.llseek = lpfc_debugfs_lseek,
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index f1871ea..c3f0e32 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -1309,7 +1309,7 @@ sg_cmd_done(void *data, char *sense, int result, int resid)
}
}
-static struct file_operations sg_fops = {
+static const struct file_operations sg_fops = {
.owner = THIS_MODULE,
.read = sg_read,
.write = sg_write,
@@ -2594,7 +2594,7 @@ static struct file_operations dev_fops = {
.open = sg_proc_open_dev,
.release = seq_release,
};
-static struct seq_operations dev_seq_ops = {
+static const struct seq_operations dev_seq_ops = {
.start = dev_seq_start,
.next = dev_seq_next,
.stop = dev_seq_stop,
@@ -2607,7 +2607,7 @@ static struct file_operations devstrs_fops = {
.open = sg_proc_open_devstrs,
.release = seq_release,
};
-static struct seq_operations devstrs_seq_ops = {
+static const struct seq_operations devstrs_seq_ops = {
.start = dev_seq_start,
.next = dev_seq_next,
.stop = dev_seq_stop,
@@ -2620,7 +2620,7 @@ static struct file_operations debug_fops = {
.open = sg_proc_open_debug,
.release = seq_release,
};
-static struct seq_operations debug_seq_ops = {
+static const struct seq_operations debug_seq_ops = {
.start = dev_seq_start,
.next = dev_seq_next,
.stop = dev_seq_stop,
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH] input: constify function pointer tables
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
` (13 preceding siblings ...)
2008-01-22 19:54 ` [PATCH] [SCSI]: " Jan Engelhardt
@ 2008-01-22 19:55 ` Jan Engelhardt
2008-01-22 20:00 ` [PATCH] procfs: " Jan Engelhardt
2008-01-22 20:01 ` [PATCH] kernel: constify data and " Jan Engelhardt
16 siblings, 0 replies; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 19:55 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
---
drivers/input/input.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/input.c b/drivers/input/input.c
index a0be978..570cbcd 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -755,7 +755,7 @@ static int input_devices_seq_show(struct seq_file *seq, void *v)
return 0;
}
-static struct seq_operations input_devices_seq_ops = {
+static const struct seq_operations input_devices_seq_ops = {
.start = input_devices_seq_start,
.next = input_devices_seq_next,
.stop = input_devices_seq_stop,
@@ -808,7 +808,7 @@ static int input_handlers_seq_show(struct seq_file *seq, void *v)
return 0;
}
-static struct seq_operations input_handlers_seq_ops = {
+static const struct seq_operations input_handlers_seq_ops = {
.start = input_handlers_seq_start,
.next = input_handlers_seq_next,
.stop = input_handlers_seq_stop,
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH] procfs: constify function pointer tables
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
` (14 preceding siblings ...)
2008-01-22 19:55 ` [PATCH] input: " Jan Engelhardt
@ 2008-01-22 20:00 ` Jan Engelhardt
2008-01-22 21:25 ` Geert Uytterhoeven
` (5 more replies)
2008-01-22 20:01 ` [PATCH] kernel: constify data and " Jan Engelhardt
16 siblings, 6 replies; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 20:00 UTC (permalink / raw)
To: Andrew Morton
Cc: Linux Kernel Mailing List, linux-fsdevel, Ivan Kokshaysky,
Bryan Wu, Mikael Starvik, David Howells, Hirokazu Takata,
Geert Uytterhoeven, Roman Zippel, Kyle McMartin, Matthew Wilcox,
Chris Zankel
Hi,
This touches so many different places that I did not feel like creating
a miniscule patch for each architecture. I hope that is ok.
===Patch begins===
[PATCH] procfs: constify function pointer tables
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
---
arch/alpha/kernel/setup.c | 2 +-
arch/blackfin/kernel/setup.c | 2 +-
arch/cris/kernel/setup.c | 2 +-
arch/frv/kernel/setup.c | 2 +-
arch/h8300/kernel/setup.c | 2 +-
arch/m32r/kernel/setup.c | 2 +-
arch/m68k/kernel/setup.c | 2 +-
arch/m68knommu/kernel/setup.c | 2 +-
arch/parisc/kernel/setup.c | 2 +-
arch/ppc/kernel/setup.c | 2 +-
arch/v850/kernel/procfs.c | 2 +-
arch/xtensa/kernel/setup.c | 2 +-
fs/proc/base.c | 6 +++---
fs/proc/nommu.c | 2 +-
fs/proc/proc_misc.c | 22 +++++++++++-----------
fs/proc/proc_sysctl.c | 4 ++--
fs/proc/proc_tty.c | 2 +-
fs/proc/task_mmu.c | 8 ++++----
fs/proc/task_nommu.c | 2 +-
19 files changed, 35 insertions(+), 35 deletions(-)
diff --git a/arch/alpha/kernel/setup.c b/arch/alpha/kernel/setup.c
index bd5e68c..823f18e 100644
--- a/arch/alpha/kernel/setup.c
+++ b/arch/alpha/kernel/setup.c
@@ -1472,7 +1472,7 @@ c_stop(struct seq_file *f, void *v)
{
}
-struct seq_operations cpuinfo_op = {
+const struct seq_operations cpuinfo_op = {
.start = c_start,
.next = c_next,
.stop = c_stop,
diff --git a/arch/blackfin/kernel/setup.c b/arch/blackfin/kernel/setup.c
index d282201..d67cf54 100644
--- a/arch/blackfin/kernel/setup.c
+++ b/arch/blackfin/kernel/setup.c
@@ -691,7 +691,7 @@ static void c_stop(struct seq_file *m, void *v)
{
}
-struct seq_operations cpuinfo_op = {
+const struct seq_operations cpuinfo_op = {
.start = c_start,
.next = c_next,
.stop = c_stop,
diff --git a/arch/cris/kernel/setup.c b/arch/cris/kernel/setup.c
index 65466c4..e42aedd 100644
--- a/arch/cris/kernel/setup.c
+++ b/arch/cris/kernel/setup.c
@@ -180,7 +180,7 @@ static void c_stop(struct seq_file *m, void *v)
extern int show_cpuinfo(struct seq_file *m, void *v);
-struct seq_operations cpuinfo_op = {
+const struct seq_operations cpuinfo_op = {
.start = c_start,
.next = c_next,
.stop = c_stop,
diff --git a/arch/frv/kernel/setup.c b/arch/frv/kernel/setup.c
index a74c087..582e832 100644
--- a/arch/frv/kernel/setup.c
+++ b/arch/frv/kernel/setup.c
@@ -1109,7 +1109,7 @@ static void c_stop(struct seq_file *m, void *v)
{
}
-struct seq_operations cpuinfo_op = {
+const struct seq_operations cpuinfo_op = {
.start = c_start,
.next = c_next,
.stop = c_stop,
diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c
index b2e86d0..fb0f809 100644
--- a/arch/h8300/kernel/setup.c
+++ b/arch/h8300/kernel/setup.c
@@ -236,7 +236,7 @@ static void c_stop(struct seq_file *m, void *v)
{
}
-struct seq_operations cpuinfo_op = {
+const struct seq_operations cpuinfo_op = {
.start = c_start,
.next = c_next,
.stop = c_stop,
diff --git a/arch/m32r/kernel/setup.c b/arch/m32r/kernel/setup.c
index d648143..c815fbe 100644
--- a/arch/m32r/kernel/setup.c
+++ b/arch/m32r/kernel/setup.c
@@ -366,7 +366,7 @@ static void c_stop(struct seq_file *m, void *v)
{
}
-struct seq_operations cpuinfo_op = {
+const struct seq_operations cpuinfo_op = {
.start = c_start,
.next = c_next,
.stop = c_stop,
diff --git a/arch/m68k/kernel/setup.c b/arch/m68k/kernel/setup.c
index ed3a4ca..6a8afa9 100644
--- a/arch/m68k/kernel/setup.c
+++ b/arch/m68k/kernel/setup.c
@@ -449,7 +449,7 @@ static void *c_next(struct seq_file *m, void *v, loff_t *pos)
static void c_stop(struct seq_file *m, void *v)
{
}
-struct seq_operations cpuinfo_op = {
+const struct seq_operations cpuinfo_op = {
.start = c_start,
.next = c_next,
.stop = c_stop,
diff --git a/arch/m68knommu/kernel/setup.c b/arch/m68knommu/kernel/setup.c
index 332345d..001181a 100644
--- a/arch/m68knommu/kernel/setup.c
+++ b/arch/m68knommu/kernel/setup.c
@@ -263,7 +263,7 @@ static void c_stop(struct seq_file *m, void *v)
{
}
-struct seq_operations cpuinfo_op = {
+const struct seq_operations cpuinfo_op = {
.start = c_start,
.next = c_next,
.stop = c_stop,
diff --git a/arch/parisc/kernel/setup.c b/arch/parisc/kernel/setup.c
index c44b8c5..39e7c5a 100644
--- a/arch/parisc/kernel/setup.c
+++ b/arch/parisc/kernel/setup.c
@@ -190,7 +190,7 @@ c_stop (struct seq_file *m, void *v)
{
}
-struct seq_operations cpuinfo_op = {
+const struct seq_operations cpuinfo_op = {
.start = c_start,
.next = c_next,
.stop = c_stop,
diff --git a/arch/ppc/kernel/setup.c b/arch/ppc/kernel/setup.c
index 5255bd8..9b38b0b 100644
--- a/arch/ppc/kernel/setup.c
+++ b/arch/ppc/kernel/setup.c
@@ -277,7 +277,7 @@ static void c_stop(struct seq_file *m, void *v)
{
}
-struct seq_operations cpuinfo_op = {
+const struct seq_operations cpuinfo_op = {
.start =c_start,
.next = c_next,
.stop = c_stop,
diff --git a/arch/v850/kernel/procfs.c b/arch/v850/kernel/procfs.c
index e6f9d06..e433cde 100644
--- a/arch/v850/kernel/procfs.c
+++ b/arch/v850/kernel/procfs.c
@@ -59,7 +59,7 @@ static void cpuinfo_stop (struct seq_file *m, void *v)
{
}
-struct seq_operations cpuinfo_op = {
+const struct seq_operations cpuinfo_op = {
.start = cpuinfo_start,
.next = cpuinfo_next,
.stop = cpuinfo_stop,
diff --git a/arch/xtensa/kernel/setup.c b/arch/xtensa/kernel/setup.c
index 2e8d398..b80f2cb 100644
--- a/arch/xtensa/kernel/setup.c
+++ b/arch/xtensa/kernel/setup.c
@@ -469,7 +469,7 @@ c_stop(struct seq_file *f, void *v)
{
}
-struct seq_operations cpuinfo_op =
+const struct seq_operations cpuinfo_op =
{
start: c_start,
next: c_next,
diff --git a/fs/proc/base.c b/fs/proc/base.c
index 7411bfb..1784c97 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -435,7 +435,7 @@ static const struct inode_operations proc_def_inode_operations = {
.setattr = proc_setattr,
};
-extern struct seq_operations mounts_op;
+extern const struct seq_operations mounts_op;
struct proc_mounts {
struct seq_file m;
int event;
@@ -514,7 +514,7 @@ static const struct file_operations proc_mounts_operations = {
.poll = mounts_poll,
};
-extern struct seq_operations mountstats_op;
+extern const struct seq_operations mountstats_op;
static int mountstats_open(struct inode *inode, struct file *file)
{
int ret = seq_open(file, &mountstats_op);
@@ -895,7 +895,7 @@ static ssize_t clear_refs_write(struct file *file, const char __user *buf,
return end - buffer;
}
-static struct file_operations proc_clear_refs_operations = {
+static const struct file_operations proc_clear_refs_operations = {
.write = clear_refs_write,
};
#endif
diff --git a/fs/proc/nommu.c b/fs/proc/nommu.c
index 22f789d..5d9147b 100644
--- a/fs/proc/nommu.c
+++ b/fs/proc/nommu.c
@@ -116,7 +116,7 @@ static void *nommu_vma_list_next(struct seq_file *m, void *v, loff_t *pos)
return rb_next((struct rb_node *) v);
}
-static struct seq_operations proc_nommu_vma_list_seqop = {
+static const struct seq_operations proc_nommu_vma_list_seqop = {
.start = nommu_vma_list_start,
.next = nommu_vma_list_next,
.stop = nommu_vma_list_stop,
diff --git a/fs/proc/proc_misc.c b/fs/proc/proc_misc.c
index 3462bfd..7315786 100644
--- a/fs/proc/proc_misc.c
+++ b/fs/proc/proc_misc.c
@@ -216,7 +216,7 @@ static int meminfo_read_proc(char *page, char **start, off_t off,
#undef K
}
-extern struct seq_operations fragmentation_op;
+extern const struct seq_operations fragmentation_op;
static int fragmentation_open(struct inode *inode, struct file *file)
{
(void)inode;
@@ -230,7 +230,7 @@ static const struct file_operations fragmentation_file_operations = {
.release = seq_release,
};
-extern struct seq_operations pagetypeinfo_op;
+extern const struct seq_operations pagetypeinfo_op;
static int pagetypeinfo_open(struct inode *inode, struct file *file)
{
return seq_open(file, &pagetypeinfo_op);
@@ -243,7 +243,7 @@ static const struct file_operations pagetypeinfo_file_ops = {
.release = seq_release,
};
-extern struct seq_operations zoneinfo_op;
+extern const struct seq_operations zoneinfo_op;
static int zoneinfo_open(struct inode *inode, struct file *file)
{
return seq_open(file, &zoneinfo_op);
@@ -268,7 +268,7 @@ static int version_read_proc(char *page, char **start, off_t off,
return proc_calc_metrics(page, start, off, count, eof, len);
}
-extern struct seq_operations cpuinfo_op;
+extern const struct seq_operations cpuinfo_op;
static int cpuinfo_open(struct inode *inode, struct file *file)
{
return seq_open(file, &cpuinfo_op);
@@ -321,7 +321,7 @@ static void devinfo_stop(struct seq_file *f, void *v)
/* Nothing to do */
}
-static struct seq_operations devinfo_ops = {
+static const struct seq_operations devinfo_ops = {
.start = devinfo_start,
.next = devinfo_next,
.stop = devinfo_stop,
@@ -340,7 +340,7 @@ static const struct file_operations proc_devinfo_operations = {
.release = seq_release,
};
-extern struct seq_operations vmstat_op;
+extern const struct seq_operations vmstat_op;
static int vmstat_open(struct inode *inode, struct file *file)
{
return seq_open(file, &vmstat_op);
@@ -371,7 +371,7 @@ static int stram_read_proc(char *page, char **start, off_t off,
#endif
#ifdef CONFIG_BLOCK
-extern struct seq_operations partitions_op;
+extern const struct seq_operations partitions_op;
static int partitions_open(struct inode *inode, struct file *file)
{
return seq_open(file, &partitions_op);
@@ -383,7 +383,7 @@ static const struct file_operations proc_partitions_operations = {
.release = seq_release,
};
-extern struct seq_operations diskstats_op;
+extern const struct seq_operations diskstats_op;
static int diskstats_open(struct inode *inode, struct file *file)
{
return seq_open(file, &diskstats_op);
@@ -397,7 +397,7 @@ static const struct file_operations proc_diskstats_operations = {
#endif
#ifdef CONFIG_MODULES
-extern struct seq_operations modules_op;
+extern const struct seq_operations modules_op;
static int modules_open(struct inode *inode, struct file *file)
{
return seq_open(file, &modules_op);
@@ -424,7 +424,7 @@ static const struct file_operations proc_slabinfo_operations = {
};
#ifdef CONFIG_DEBUG_SLAB_LEAK
-extern struct seq_operations slabstats_op;
+extern const struct seq_operations slabstats_op;
static int slabstats_open(struct inode *inode, struct file *file)
{
unsigned long *n = kzalloc(PAGE_SIZE, GFP_KERNEL);
@@ -599,7 +599,7 @@ static void int_seq_stop(struct seq_file *f, void *v)
extern int show_interrupts(struct seq_file *f, void *v); /* In arch code */
-static struct seq_operations int_seq_ops = {
+static const struct seq_operations int_seq_ops = {
.start = int_seq_start,
.next = int_seq_next,
.stop = int_seq_stop,
diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
index 4e57fcf..b9cb23c 100644
--- a/fs/proc/proc_sysctl.c
+++ b/fs/proc/proc_sysctl.c
@@ -9,7 +9,7 @@
static struct dentry_operations proc_sys_dentry_operations;
static const struct file_operations proc_sys_file_operations;
-static struct inode_operations proc_sys_inode_operations;
+static const struct inode_operations proc_sys_inode_operations;
static void proc_sys_refresh_inode(struct inode *inode, struct ctl_table *table)
{
@@ -446,7 +446,7 @@ static const struct file_operations proc_sys_file_operations = {
.readdir = proc_sys_readdir,
};
-static struct inode_operations proc_sys_inode_operations = {
+static const struct inode_operations proc_sys_inode_operations = {
.lookup = proc_sys_lookup,
.permission = proc_sys_permission,
.setattr = proc_sys_setattr,
diff --git a/fs/proc/proc_tty.c b/fs/proc/proc_tty.c
index 2284622..6d3da93 100644
--- a/fs/proc/proc_tty.c
+++ b/fs/proc/proc_tty.c
@@ -120,7 +120,7 @@ static void t_stop(struct seq_file *m, void *v)
mutex_unlock(&tty_mutex);
}
-static struct seq_operations tty_drivers_op = {
+static const struct seq_operations tty_drivers_op = {
.start = t_start,
.next = t_next,
.stop = t_stop,
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 8043a3e..2c2755d 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -467,14 +467,14 @@ static void m_stop(struct seq_file *m, void *v)
put_task_struct(priv->task);
}
-static struct seq_operations proc_pid_maps_op = {
+static const struct seq_operations proc_pid_maps_op = {
.start = m_start,
.next = m_next,
.stop = m_stop,
.show = show_map
};
-static struct seq_operations proc_pid_smaps_op = {
+static const struct seq_operations proc_pid_smaps_op = {
.start = m_start,
.next = m_next,
.stop = m_stop,
@@ -482,7 +482,7 @@ static struct seq_operations proc_pid_smaps_op = {
};
static int do_maps_open(struct inode *inode, struct file *file,
- struct seq_operations *ops)
+ const struct seq_operations *ops)
{
struct proc_maps_private *priv;
int ret = -ENOMEM;
@@ -526,7 +526,7 @@ static int show_numa_map_checked(struct seq_file *m, void *v)
return show_numa_map(m, v);
}
-static struct seq_operations proc_pid_numa_maps_op = {
+static const struct seq_operations proc_pid_numa_maps_op = {
.start = m_start,
.next = m_next,
.stop = m_stop,
diff --git a/fs/proc/task_nommu.c b/fs/proc/task_nommu.c
index 1932c2c..e5a3d8b 100644
--- a/fs/proc/task_nommu.c
+++ b/fs/proc/task_nommu.c
@@ -199,7 +199,7 @@ static void *m_next(struct seq_file *m, void *_vml, loff_t *pos)
return vml ? vml->next : NULL;
}
-static struct seq_operations proc_pid_maps_ops = {
+static const struct seq_operations proc_pid_maps_ops = {
.start = m_start,
.next = m_next,
.stop = m_stop,
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH] kernel: constify data and function pointer tables
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
` (15 preceding siblings ...)
2008-01-22 20:00 ` [PATCH] procfs: " Jan Engelhardt
@ 2008-01-22 20:01 ` Jan Engelhardt
16 siblings, 0 replies; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-22 20:01 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux Kernel Mailing List
Hi,
this one also touches like any place that could be found, so I combined
it.
===Patch begins here===
[PATCH] kernel: constify data and function pointer tables
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
---
drivers/char/apm-emulation.c | 2 +-
drivers/char/drm/drmP.h | 6 +++---
drivers/char/misc.c | 2 +-
drivers/char/tpm/tpm_bios.c | 4 ++--
drivers/isdn/capi/kcapi_proc.c | 10 +++++-----
drivers/misc/phantom.c | 2 +-
drivers/spi/spidev.c | 2 +-
fs/afs/proc.c | 8 ++++----
fs/char_dev.c | 2 +-
fs/debugfs/inode.c | 4 ++--
fs/hfsplus/inode.c | 2 +-
fs/inode.c | 2 +-
fs/locks.c | 2 +-
fs/namespace.c | 4 ++--
include/linux/cgroup.h | 2 +-
include/linux/fs.h | 2 +-
ipc/util.c | 2 +-
kernel/cgroup.c | 12 ++++++------
kernel/kprobes.c | 6 +++---
kernel/lockdep_proc.c | 2 +-
kernel/time/timer_list.c | 2 +-
kernel/time/timer_stats.c | 2 +-
samples/markers/marker-example.c | 2 +-
23 files changed, 42 insertions(+), 42 deletions(-)
diff --git a/drivers/char/apm-emulation.c b/drivers/char/apm-emulation.c
index 17d5431..98f140d 100644
--- a/drivers/char/apm-emulation.c
+++ b/drivers/char/apm-emulation.c
@@ -438,7 +438,7 @@ static int apm_open(struct inode * inode, struct file * filp)
return as ? 0 : -ENOMEM;
}
-static struct file_operations apm_bios_fops = {
+static const struct file_operations apm_bios_fops = {
.owner = THIS_MODULE,
.read = apm_read,
.poll = apm_poll,
diff --git a/drivers/char/drm/drmP.h b/drivers/char/drm/drmP.h
index dde02a1..136906b 100644
--- a/drivers/char/drm/drmP.h
+++ b/drivers/char/drm/drmP.h
@@ -612,9 +612,9 @@ struct drm_driver {
int major;
int minor;
int patchlevel;
- char *name;
- char *desc;
- char *date;
+ const char *name;
+ const char *desc;
+ const char *date;
u32 driver_features;
int dev_priv_size;
diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index 71c8cd7..035a011 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -90,7 +90,7 @@ static int misc_seq_show(struct seq_file *seq, void *v)
}
-static struct seq_operations misc_seq_ops = {
+static const struct seq_operations misc_seq_ops = {
.start = misc_seq_start,
.next = misc_seq_next,
.stop = misc_seq_stop,
diff --git a/drivers/char/tpm/tpm_bios.c b/drivers/char/tpm/tpm_bios.c
index 60a2d26..7b6a7fb 100644
--- a/drivers/char/tpm/tpm_bios.c
+++ b/drivers/char/tpm/tpm_bios.c
@@ -344,14 +344,14 @@ static int tpm_ascii_bios_measurements_show(struct seq_file *m, void *v)
return 0;
}
-static struct seq_operations tpm_ascii_b_measurments_seqops = {
+static const struct seq_operations tpm_ascii_b_measurments_seqops = {
.start = tpm_bios_measurements_start,
.next = tpm_bios_measurements_next,
.stop = tpm_bios_measurements_stop,
.show = tpm_ascii_bios_measurements_show,
};
-static struct seq_operations tpm_binary_b_measurments_seqops = {
+static const struct seq_operations tpm_binary_b_measurments_seqops = {
.start = tpm_bios_measurements_start,
.next = tpm_bios_measurements_next,
.stop = tpm_bios_measurements_stop,
diff --git a/drivers/isdn/capi/kcapi_proc.c b/drivers/isdn/capi/kcapi_proc.c
index 845a797..ad7865d 100644
--- a/drivers/isdn/capi/kcapi_proc.c
+++ b/drivers/isdn/capi/kcapi_proc.c
@@ -89,14 +89,14 @@ static int contrstats_show(struct seq_file *seq, void *v)
return 0;
}
-static struct seq_operations seq_controller_ops = {
+static const struct seq_operations seq_controller_ops = {
.start = controller_start,
.next = controller_next,
.stop = controller_stop,
.show = controller_show,
};
-static struct seq_operations seq_contrstats_ops = {
+static const struct seq_operations seq_contrstats_ops = {
.start = controller_start,
.next = controller_next,
.stop = controller_stop,
@@ -192,14 +192,14 @@ applstats_show(struct seq_file *seq, void *v)
return 0;
}
-static struct seq_operations seq_applications_ops = {
+static const struct seq_operations seq_applications_ops = {
.start = applications_start,
.next = applications_next,
.stop = applications_stop,
.show = applications_show,
};
-static struct seq_operations seq_applstats_ops = {
+static const struct seq_operations seq_applstats_ops = {
.start = applications_start,
.next = applications_next,
.stop = applications_stop,
@@ -267,7 +267,7 @@ static int capi_driver_show(struct seq_file *seq, void *v)
return 0;
}
-static struct seq_operations seq_capi_driver_ops = {
+static const struct seq_operations seq_capi_driver_ops = {
.start = capi_driver_start,
.next = capi_driver_next,
.stop = capi_driver_stop,
diff --git a/drivers/misc/phantom.c b/drivers/misc/phantom.c
index cd221fd..8e2736a 100644
--- a/drivers/misc/phantom.c
+++ b/drivers/misc/phantom.c
@@ -249,7 +249,7 @@ static unsigned int phantom_poll(struct file *file, poll_table *wait)
return mask;
}
-static struct file_operations phantom_file_ops = {
+static const struct file_operations phantom_file_ops = {
.open = phantom_open,
.release = phantom_release,
.unlocked_ioctl = phantom_ioctl,
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index b3518ca..be4caed 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -439,7 +439,7 @@ static int spidev_release(struct inode *inode, struct file *filp)
return status;
}
-static struct file_operations spidev_fops = {
+static const struct file_operations spidev_fops = {
.owner = THIS_MODULE,
/* REVISIT switch to aio primitives, so that userspace
* gets more complete API coverage. It'll simplify things
diff --git a/fs/afs/proc.c b/fs/afs/proc.c
index 846c761..370d656 100644
--- a/fs/afs/proc.c
+++ b/fs/afs/proc.c
@@ -28,7 +28,7 @@ static int afs_proc_cells_show(struct seq_file *m, void *v);
static ssize_t afs_proc_cells_write(struct file *file, const char __user *buf,
size_t size, loff_t *_pos);
-static struct seq_operations afs_proc_cells_ops = {
+static const struct seq_operations afs_proc_cells_ops = {
.start = afs_proc_cells_start,
.next = afs_proc_cells_next,
.stop = afs_proc_cells_stop,
@@ -68,7 +68,7 @@ static void *afs_proc_cell_volumes_next(struct seq_file *p, void *v,
static void afs_proc_cell_volumes_stop(struct seq_file *p, void *v);
static int afs_proc_cell_volumes_show(struct seq_file *m, void *v);
-static struct seq_operations afs_proc_cell_volumes_ops = {
+static const struct seq_operations afs_proc_cell_volumes_ops = {
.start = afs_proc_cell_volumes_start,
.next = afs_proc_cell_volumes_next,
.stop = afs_proc_cell_volumes_stop,
@@ -92,7 +92,7 @@ static void *afs_proc_cell_vlservers_next(struct seq_file *p, void *v,
static void afs_proc_cell_vlservers_stop(struct seq_file *p, void *v);
static int afs_proc_cell_vlservers_show(struct seq_file *m, void *v);
-static struct seq_operations afs_proc_cell_vlservers_ops = {
+static const struct seq_operations afs_proc_cell_vlservers_ops = {
.start = afs_proc_cell_vlservers_start,
.next = afs_proc_cell_vlservers_next,
.stop = afs_proc_cell_vlservers_stop,
@@ -115,7 +115,7 @@ static void *afs_proc_cell_servers_next(struct seq_file *p, void *v,
static void afs_proc_cell_servers_stop(struct seq_file *p, void *v);
static int afs_proc_cell_servers_show(struct seq_file *m, void *v);
-static struct seq_operations afs_proc_cell_servers_ops = {
+static const struct seq_operations afs_proc_cell_servers_ops = {
.start = afs_proc_cell_servers_start,
.next = afs_proc_cell_servers_next,
.stop = afs_proc_cell_servers_stop,
diff --git a/fs/char_dev.c b/fs/char_dev.c
index c3bfa76..150e38d 100644
--- a/fs/char_dev.c
+++ b/fs/char_dev.c
@@ -55,7 +55,7 @@ static struct char_device_struct {
unsigned int baseminor;
int minorct;
char name[64];
- struct file_operations *fops;
+ const struct file_operations *fops;
struct cdev *cdev; /* will die */
} *chrdevs[CHRDEV_MAJOR_HASH_SIZE];
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
index 6a713b3..b32b730 100644
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -30,8 +30,8 @@
#define DEBUGFS_MAGIC 0x64626720
/* declared over in file.c */
-extern struct file_operations debugfs_file_operations;
-extern struct inode_operations debugfs_link_operations;
+extern const struct file_operations debugfs_file_operations;
+extern const struct inode_operations debugfs_link_operations;
static struct vfsmount *debugfs_mount;
static int debugfs_mount_count;
diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
index 37744cf..aea1de4 100644
--- a/fs/hfsplus/inode.c
+++ b/fs/hfsplus/inode.c
@@ -279,7 +279,7 @@ static int hfsplus_file_release(struct inode *inode, struct file *file)
}
extern const struct inode_operations hfsplus_dir_inode_operations;
-extern struct file_operations hfsplus_dir_operations;
+extern const struct file_operations hfsplus_dir_operations;
static const struct inode_operations hfsplus_file_inode_operations = {
.lookup = hfsplus_file_lookup,
diff --git a/fs/inode.c b/fs/inode.c
index ed35383..cca0193 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -111,7 +111,7 @@ static void wake_up_inode(struct inode *inode)
static struct inode *alloc_inode(struct super_block *sb)
{
static const struct address_space_operations empty_aops;
- static struct inode_operations empty_iops;
+ static const struct inode_operations empty_iops;
static const struct file_operations empty_fops;
struct inode *inode;
diff --git a/fs/locks.c b/fs/locks.c
index 8b8388e..d389248 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -2177,7 +2177,7 @@ static void locks_stop(struct seq_file *f, void *v)
unlock_kernel();
}
-struct seq_operations locks_seq_operations = {
+const struct seq_operations locks_seq_operations = {
.start = locks_start,
.next = locks_next,
.stop = locks_stop,
diff --git a/fs/namespace.c b/fs/namespace.c
index 0608388..f967896 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -391,7 +391,7 @@ static int show_vfsmnt(struct seq_file *m, void *v)
return err;
}
-struct seq_operations mounts_op = {
+const struct seq_operations mounts_op = {
.start = m_start,
.next = m_next,
.stop = m_stop,
@@ -429,7 +429,7 @@ static int show_vfsstat(struct seq_file *m, void *v)
return err;
}
-struct seq_operations mountstats_op = {
+const struct seq_operations mountstats_op = {
.start = m_start,
.next = m_next,
.stop = m_stop,
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index 8747932..c843d98 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -33,7 +33,7 @@ extern void cgroup_exit(struct task_struct *p, int run_callbacks);
extern int cgroupstats_build(struct cgroupstats *stats,
struct dentry *dentry);
-extern struct file_operations proc_cgroup_operations;
+extern const struct file_operations proc_cgroup_operations;
/* Define the enumeration of all cgroup subsystems */
#define SUBSYS(_x) _x ## _subsys_id,
diff --git a/include/linux/fs.h b/include/linux/fs.h
index b3ec4a4..c88626e 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -939,7 +939,7 @@ extern int vfs_setlease(struct file *, long, struct file_lock **);
extern int lease_modify(struct file_lock **, int);
extern int lock_may_read(struct inode *, loff_t start, unsigned long count);
extern int lock_may_write(struct inode *, loff_t start, unsigned long count);
-extern struct seq_operations locks_seq_operations;
+extern const struct seq_operations locks_seq_operations;
struct fasync_struct {
int magic;
diff --git a/ipc/util.c b/ipc/util.c
index 1aa0ebf..f784a79 100644
--- a/ipc/util.c
+++ b/ipc/util.c
@@ -901,7 +901,7 @@ static int sysvipc_proc_show(struct seq_file *s, void *it)
return iface->show(s, it);
}
-static struct seq_operations sysvipc_proc_seqops = {
+static const struct seq_operations sysvipc_proc_seqops = {
.start = sysvipc_proc_start,
.stop = sysvipc_proc_stop,
.next = sysvipc_proc_next,
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 1a3c239..333f447 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -564,8 +564,8 @@ void cgroup_unlock(void)
static int cgroup_mkdir(struct inode *dir, struct dentry *dentry, int mode);
static int cgroup_rmdir(struct inode *unused_dir, struct dentry *dentry);
static int cgroup_populate_dir(struct cgroup *cgrp);
-static struct inode_operations cgroup_dir_inode_operations;
-static struct file_operations proc_cgroupstats_operations;
+static const struct inode_operations cgroup_dir_inode_operations;
+static const struct file_operations proc_cgroupstats_operations;
static struct backing_dev_info cgroup_backing_dev_info = {
.capabilities = BDI_CAP_NO_ACCT_DIRTY | BDI_CAP_NO_WRITEBACK,
@@ -1510,7 +1510,7 @@ static int cgroup_rename(struct inode *old_dir, struct dentry *old_dentry,
return simple_rename(old_dir, old_dentry, new_dir, new_dentry);
}
-static struct file_operations cgroup_file_operations = {
+static const struct file_operations cgroup_file_operations = {
.read = cgroup_file_read,
.write = cgroup_file_write,
.llseek = generic_file_llseek,
@@ -1518,7 +1518,7 @@ static struct file_operations cgroup_file_operations = {
.release = cgroup_file_release,
};
-static struct inode_operations cgroup_dir_inode_operations = {
+static const struct inode_operations cgroup_dir_inode_operations = {
.lookup = simple_lookup,
.mkdir = cgroup_mkdir,
.rmdir = cgroup_rmdir,
@@ -2390,7 +2390,7 @@ static int cgroup_open(struct inode *inode, struct file *file)
return single_open(file, proc_cgroup_show, pid);
}
-struct file_operations proc_cgroup_operations = {
+const struct file_operations proc_cgroup_operations = {
.open = cgroup_open,
.read = seq_read,
.llseek = seq_lseek,
@@ -2419,7 +2419,7 @@ static int cgroupstats_open(struct inode *inode, struct file *file)
return single_open(file, proc_cgroupstats_show, 0);
}
-static struct file_operations proc_cgroupstats_operations = {
+static const struct file_operations proc_cgroupstats_operations = {
.open = cgroupstats_open,
.read = seq_read,
.llseek = seq_lseek,
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index e3a5d81..49e20ec 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -889,7 +889,7 @@ static int __kprobes show_kprobe_addr(struct seq_file *pi, void *v)
return 0;
}
-static struct seq_operations kprobes_seq_ops = {
+static const struct seq_operations kprobes_seq_ops = {
.start = kprobe_seq_start,
.next = kprobe_seq_next,
.stop = kprobe_seq_stop,
@@ -901,7 +901,7 @@ static int __kprobes kprobes_open(struct inode *inode, struct file *filp)
return seq_open(filp, &kprobes_seq_ops);
}
-static struct file_operations debugfs_kprobes_operations = {
+static const struct file_operations debugfs_kprobes_operations = {
.open = kprobes_open,
.read = seq_read,
.llseek = seq_lseek,
@@ -1013,7 +1013,7 @@ static ssize_t write_enabled_file_bool(struct file *file,
return count;
}
-static struct file_operations fops_kp = {
+static const struct file_operations fops_kp = {
.read = read_enabled_file_bool,
.write = write_enabled_file_bool,
};
diff --git a/kernel/lockdep_proc.c b/kernel/lockdep_proc.c
index 8a135bd..c1e8b3a 100644
--- a/kernel/lockdep_proc.c
+++ b/kernel/lockdep_proc.c
@@ -581,7 +581,7 @@ static int ls_show(struct seq_file *m, void *v)
return 0;
}
-static struct seq_operations lockstat_ops = {
+static const struct seq_operations lockstat_ops = {
.start = ls_start,
.next = ls_next,
.stop = ls_stop,
diff --git a/kernel/time/timer_list.c b/kernel/time/timer_list.c
index 12c5f4c..4eab187 100644
--- a/kernel/time/timer_list.c
+++ b/kernel/time/timer_list.c
@@ -265,7 +265,7 @@ static int timer_list_open(struct inode *inode, struct file *filp)
return single_open(filp, timer_list_show, NULL);
}
-static struct file_operations timer_list_fops = {
+static const struct file_operations timer_list_fops = {
.open = timer_list_open,
.read = seq_read,
.llseek = seq_lseek,
diff --git a/kernel/time/timer_stats.c b/kernel/time/timer_stats.c
index c36bb7e..f120255 100644
--- a/kernel/time/timer_stats.c
+++ b/kernel/time/timer_stats.c
@@ -395,7 +395,7 @@ static int tstats_open(struct inode *inode, struct file *filp)
return single_open(filp, tstats_show, NULL);
}
-static struct file_operations tstats_fops = {
+static const struct file_operations tstats_fops = {
.open = tstats_open,
.read = seq_read,
.write = tstats_write,
diff --git a/samples/markers/marker-example.c b/samples/markers/marker-example.c
index 05e438f..27e2668 100644
--- a/samples/markers/marker-example.c
+++ b/samples/markers/marker-example.c
@@ -26,7 +26,7 @@ static int my_open(struct inode *inode, struct file *file)
return -EPERM;
}
-static struct file_operations mark_ops = {
+static const struct file_operations mark_ops = {
.open = my_open,
};
--
1.5.3.4
^ permalink raw reply related [flat|nested] 41+ messages in thread
* Re: [PATCH] [SCSI]: constify function pointer tables
2008-01-22 19:54 ` [PATCH] [SCSI]: " Jan Engelhardt
@ 2008-01-22 20:37 ` James Smart
0 siblings, 0 replies; 41+ messages in thread
From: James Smart @ 2008-01-22 20:37 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: James Bottomley, linux-scsi, axboe
Jan Engelhardt wrote:
> Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
> ---
> drivers/scsi/lpfc/lpfc_debugfs.c | 10 +++++-----
> drivers/scsi/sg.c | 8 ++++----
ACK
-- james s
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] x86: constify function pointer tables
2008-01-22 19:51 ` [PATCH] x86: " Jan Engelhardt
@ 2008-01-22 20:56 ` Ingo Molnar
0 siblings, 0 replies; 41+ messages in thread
From: Ingo Molnar @ 2008-01-22 20:56 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: Linux Kernel Mailing List, tglx
* Jan Engelhardt <jengelh@computergmbh.de> wrote:
> Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
thanks, applied.
btw., please send future x86 cleanup patches against x86.git#mm. For
example, this bit:
> -struct seq_operations cpuinfo_op = {
> +const struct seq_operations cpuinfo_op = {
> .start =c_start,
already looks a bit different there so it didnt apply straight away. (i
fixed that up so no need to resend)
x86.git#mm tracking coordinates are at:
http://redhat.com/~mingo/x86.git/README
Ingo
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] procfs: constify function pointer tables
2008-01-22 20:00 ` [PATCH] procfs: " Jan Engelhardt
@ 2008-01-22 21:25 ` Geert Uytterhoeven
2008-01-22 22:43 ` Mike Frysinger
` (4 subsequent siblings)
5 siblings, 0 replies; 41+ messages in thread
From: Geert Uytterhoeven @ 2008-01-22 21:25 UTC (permalink / raw)
To: Jan Engelhardt
Cc: Andrew Morton, Linux Kernel Mailing List, linux-fsdevel,
Ivan Kokshaysky, Bryan Wu, Mikael Starvik, David Howells,
Hirokazu Takata, Roman Zippel, Kyle McMartin, Matthew Wilcox,
Chris Zankel
On Tue, 22 Jan 2008, Jan Engelhardt wrote:
> This touches so many different places that I did not feel like creating
> a miniscule patch for each architecture. I hope that is ok.
>
> ===Patch begins===
> [PATCH] procfs: constify function pointer tables
>
> Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
> ---
> arch/alpha/kernel/setup.c | 2 +-
> arch/blackfin/kernel/setup.c | 2 +-
> arch/cris/kernel/setup.c | 2 +-
> arch/frv/kernel/setup.c | 2 +-
> arch/h8300/kernel/setup.c | 2 +-
> arch/m32r/kernel/setup.c | 2 +-
> arch/m68k/kernel/setup.c | 2 +-
> arch/m68knommu/kernel/setup.c | 2 +-
> arch/parisc/kernel/setup.c | 2 +-
> arch/ppc/kernel/setup.c | 2 +-
> arch/v850/kernel/procfs.c | 2 +-
> arch/xtensa/kernel/setup.c | 2 +-
> fs/proc/base.c | 6 +++---
> fs/proc/nommu.c | 2 +-
> fs/proc/proc_misc.c | 22 +++++++++++-----------
> fs/proc/proc_sysctl.c | 4 ++--
> fs/proc/proc_tty.c | 2 +-
> fs/proc/task_mmu.c | 8 ++++----
> fs/proc/task_nommu.c | 2 +-
> 19 files changed, 35 insertions(+), 35 deletions(-)
m68k part is:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] procfs: constify function pointer tables
2008-01-22 20:00 ` [PATCH] procfs: " Jan Engelhardt
2008-01-22 21:25 ` Geert Uytterhoeven
@ 2008-01-22 22:43 ` Mike Frysinger
2008-01-22 22:57 ` David Howells
` (3 subsequent siblings)
5 siblings, 0 replies; 41+ messages in thread
From: Mike Frysinger @ 2008-01-22 22:43 UTC (permalink / raw)
To: Jan Engelhardt
Cc: Andrew Morton, Linux Kernel Mailing List, linux-fsdevel,
Ivan Kokshaysky, Bryan Wu, Mikael Starvik, David Howells,
Hirokazu Takata, Geert Uytterhoeven, Roman Zippel, Kyle McMartin,
Matthew Wilcox, Chris Zankel
On Jan 22, 2008 3:00 PM, Jan Engelhardt <jengelh@computergmbh.de> wrote:
> This touches so many different places that I did not feel like creating
> a miniscule patch for each architecture. I hope that is ok.
there is a linux-arch alias so you dont have to look up every
maintainer yourself ;)
> arch/blackfin/kernel/setup.c | 2 +-
Blackfin changes look fine, thanks
Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] procfs: constify function pointer tables
2008-01-22 20:00 ` [PATCH] procfs: " Jan Engelhardt
2008-01-22 21:25 ` Geert Uytterhoeven
2008-01-22 22:43 ` Mike Frysinger
@ 2008-01-22 22:57 ` David Howells
2008-01-22 23:36 ` Stephen Rothwell
` (2 subsequent siblings)
5 siblings, 0 replies; 41+ messages in thread
From: David Howells @ 2008-01-22 22:57 UTC (permalink / raw)
To: Jan Engelhardt
Cc: dhowells, Andrew Morton, Linux Kernel Mailing List, linux-fsdevel,
Ivan Kokshaysky, Bryan Wu, Mikael Starvik, Hirokazu Takata,
Geert Uytterhoeven, Roman Zippel, Kyle McMartin, Matthew Wilcox,
Chris Zankel
FRV looks okay.
Acked-By: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] [POWERPC]: constify function pointer tables
2008-01-22 19:43 ` [PATCH] [POWERPC]: constify function pointer tables Jan Engelhardt
@ 2008-01-22 23:11 ` Stephen Rothwell
0 siblings, 0 replies; 41+ messages in thread
From: Stephen Rothwell @ 2008-01-22 23:11 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: linuxppc-dev, Paul Mackerras
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
Hi Jan,
Good idea ... but ...
On Tue, 22 Jan 2008 20:43:09 +0100 (CET) Jan Engelhardt <jengelh@computergmbh.de> wrote:
>
> diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
> index 2de00f8..57d4f28 100644
> --- a/arch/powerpc/kernel/setup-common.c
> +++ b/arch/powerpc/kernel/setup-common.c
> @@ -296,7 +296,7 @@ static void c_stop(struct seq_file *m, void *v)
> {
> }
>
> -struct seq_operations cpuinfo_op = {
> +const struct seq_operations cpuinfo_op = {
This is declared non const in fs/proc/proc_misc.c (one of the reasons why
it should be decalred in a header file ...)
The others look good, though.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] procfs: constify function pointer tables
2008-01-22 20:00 ` [PATCH] procfs: " Jan Engelhardt
` (2 preceding siblings ...)
2008-01-22 22:57 ` David Howells
@ 2008-01-22 23:36 ` Stephen Rothwell
2008-01-23 4:18 ` Bryan Wu
2008-01-23 16:40 ` Jesper Nilsson
5 siblings, 0 replies; 41+ messages in thread
From: Stephen Rothwell @ 2008-01-22 23:36 UTC (permalink / raw)
To: Jan Engelhardt
Cc: Andrew Morton, Linux Kernel Mailing List, linux-fsdevel,
Ivan Kokshaysky, Bryan Wu, Mikael Starvik, David Howells,
Hirokazu Takata, Geert Uytterhoeven, Roman Zippel, Kyle McMartin,
Matthew Wilcox, Chris Zankel
[-- Attachment #1: Type: text/plain, Size: 433 bytes --]
Hi Jan,
On Tue, 22 Jan 2008 21:00:46 +0100 (CET) Jan Engelhardt <jengelh@computergmbh.de> wrote:
>
> -extern struct seq_operations mounts_op;
> +extern const struct seq_operations mounts_op;
[ and many others ... ]
I don't suppose you feel like finding appropriate header files to put
these declarations into?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] [MIPS]: constify function pointer tables
2008-01-22 19:42 ` [PATCH] [MIPS]: constify function pointer tables Jan Engelhardt
@ 2008-01-23 0:32 ` Ralf Baechle
2008-02-07 12:41 ` [PATCH] [MIPS]: fix CAC_ADDR/UNCAC_ADDR peter fuerst
1 sibling, 0 replies; 41+ messages in thread
From: Ralf Baechle @ 2008-01-23 0:32 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: linux-mips
On Tue, Jan 22, 2008 at 08:42:33PM +0100, Jan Engelhardt wrote:
Thanks, queued for 2.6.25.
Ralf
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] [AF_X25]: constify function pointer tables
2008-01-22 19:52 ` [PATCH] [AF_X25]: " Jan Engelhardt
@ 2008-01-23 2:30 ` David Miller
0 siblings, 0 replies; 41+ messages in thread
From: David Miller @ 2008-01-23 2:30 UTC (permalink / raw)
To: jengelh; +Cc: netdev
From: Jan Engelhardt <jengelh@computergmbh.de>
Date: Tue, 22 Jan 2008 20:52:04 +0100 (CET)
> Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
Applied.
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] procfs: constify function pointer tables
2008-01-22 20:00 ` [PATCH] procfs: " Jan Engelhardt
` (3 preceding siblings ...)
2008-01-22 23:36 ` Stephen Rothwell
@ 2008-01-23 4:18 ` Bryan Wu
2008-01-23 9:06 ` Jan Engelhardt
2008-01-23 16:40 ` Jesper Nilsson
5 siblings, 1 reply; 41+ messages in thread
From: Bryan Wu @ 2008-01-23 4:18 UTC (permalink / raw)
To: Jan Engelhardt
Cc: Andrew Morton, Linux Kernel Mailing List, linux-fsdevel,
Ivan Kokshaysky, Bryan Wu, Mikael Starvik, David Howells,
Hirokazu Takata, Geert Uytterhoeven, Roman Zippel, Kyle McMartin,
Matthew Wilcox, Chris Zankel
On Jan 23, 2008 4:00 AM, Jan Engelhardt <jengelh@computergmbh.de> wrote:
> Hi,
>
>
> This touches so many different places that I did not feel like creating
> a miniscule patch for each architecture. I hope that is ok.
>
> ===Patch begins===
> [PATCH] procfs: constify function pointer tables
>
> Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
> ---
> arch/alpha/kernel/setup.c | 2 +-
> arch/blackfin/kernel/setup.c | 2 +-
> arch/cris/kernel/setup.c | 2 +-
> arch/frv/kernel/setup.c | 2 +-
> arch/h8300/kernel/setup.c | 2 +-
> arch/m32r/kernel/setup.c | 2 +-
> arch/m68k/kernel/setup.c | 2 +-
> arch/m68knommu/kernel/setup.c | 2 +-
> arch/parisc/kernel/setup.c | 2 +-
> arch/ppc/kernel/setup.c | 2 +-
> arch/v850/kernel/procfs.c | 2 +-
> arch/xtensa/kernel/setup.c | 2 +-
> fs/proc/base.c | 6 +++---
> fs/proc/nommu.c | 2 +-
> fs/proc/proc_misc.c | 22 +++++++++++-----------
> fs/proc/proc_sysctl.c | 4 ++--
> fs/proc/proc_tty.c | 2 +-
> fs/proc/task_mmu.c | 8 ++++----
> fs/proc/task_nommu.c | 2 +-
> 19 files changed, 35 insertions(+), 35 deletions(-)
>
> diff --git a/arch/alpha/kernel/setup.c b/arch/alpha/kernel/setup.c
> index bd5e68c..823f18e 100644
> --- a/arch/alpha/kernel/setup.c
> +++ b/arch/alpha/kernel/setup.c
> @@ -1472,7 +1472,7 @@ c_stop(struct seq_file *f, void *v)
> {
> }
>
> -struct seq_operations cpuinfo_op = {
> +const struct seq_operations cpuinfo_op = {
> .start = c_start,
> .next = c_next,
> .stop = c_stop,
> diff --git a/arch/blackfin/kernel/setup.c b/arch/blackfin/kernel/setup.c
> index d282201..d67cf54 100644
> --- a/arch/blackfin/kernel/setup.c
> +++ b/arch/blackfin/kernel/setup.c
> @@ -691,7 +691,7 @@ static void c_stop(struct seq_file *m, void *v)
> {
> }
>
> -struct seq_operations cpuinfo_op = {
> +const struct seq_operations cpuinfo_op = {
> .start = c_start,
> .next = c_next,
> .stop = c_stop,
Thanks, I understand the seq_xxx() API needs "const struct seq_operations *".
So for Blackfin part, I agree with Mike.
Acked-by: Bryan Wu <bryan.wu@analog.com>
but there are still some other files need add "const":
---
/opt/git-tree/blackfin-2.6$ grep -r seq_operations arch/*
arch/alpha/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/arm/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/arm/mach-davinci/clock.c:static struct seq_operations davinci_ck_op = {
arch/avr32/kernel/cpu.c:struct seq_operations cpuinfo_op = {
arch/avr32/mm/tlb.c:static struct seq_operations tlb_ops = {
arch/blackfin/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/cris/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/frv/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/h8300/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/ia64/hp/common/sba_iommu.c:static struct seq_operations ioc_seq_ops = {
arch/ia64/kernel/perfmon.c:struct seq_operations pfm_seq_ops = {
arch/ia64/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/ia64/sn/kernel/sn2/sn2_smp.c:static struct seq_operations
sn2_ptc_seq_ops = {
arch/ia64/sn/kernel/sn2/sn_hwperf.c:static struct seq_operations
sn_topology_seq_ops = {
arch/m32r/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/m68k/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/m68knommu/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/mips/kernel/proc.c:struct seq_operations cpuinfo_op = {
arch/parisc/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/powerpc/kernel/setup-common.c:struct seq_operations cpuinfo_op = {
----
[!snip!]
Regards,
-Bryan
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] procfs: constify function pointer tables
2008-01-23 4:18 ` Bryan Wu
@ 2008-01-23 9:06 ` Jan Engelhardt
2008-01-23 10:41 ` Bryan Wu
0 siblings, 1 reply; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-23 9:06 UTC (permalink / raw)
To: Bryan Wu
Cc: Andrew Morton, Linux Kernel Mailing List, linux-fsdevel,
Ivan Kokshaysky, Bryan Wu, Mikael Starvik, David Howells,
Hirokazu Takata, Geert Uytterhoeven, Roman Zippel, Kyle McMartin,
Matthew Wilcox, Chris Zankel
On Jan 23 2008 12:18, Bryan Wu wrote:
>> [PATCH] procfs: constify function pointer tables
>> ---
>> arch/alpha/kernel/setup.c | 2 +-
>> arch/blackfin/kernel/setup.c | 2 +-
>> [...]
>> diff --git a/arch/alpha/kernel/setup.c b/arch/alpha/kernel/setup.c
>> index bd5e68c..823f18e 100644
>> --- a/arch/alpha/kernel/setup.c
>> +++ b/arch/alpha/kernel/setup.c
>> @@ -1472,7 +1472,7 @@ c_stop(struct seq_file *f, void *v)
>> {
>> }
>>
>> -struct seq_operations cpuinfo_op = {
>> +const struct seq_operations cpuinfo_op = {
>> .start = c_start,
>> .next = c_next,
>> .stop = c_stop,
[...]
>Thanks, I understand the seq_xxx() API needs "const struct seq_operations *".
>So for Blackfin part, I agree with Mike.
>
>but there are still some other files need add "const":
>---
>/opt/git-tree/blackfin-2.6$ grep -r seq_operations arch/*
>arch/alpha/kernel/setup.c:struct seq_operations cpuinfo_op = {
The patch already touches that :-)
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] procfs: constify function pointer tables
2008-01-23 9:06 ` Jan Engelhardt
@ 2008-01-23 10:41 ` Bryan Wu
2008-01-23 11:25 ` Jan Engelhardt
0 siblings, 1 reply; 41+ messages in thread
From: Bryan Wu @ 2008-01-23 10:41 UTC (permalink / raw)
To: Jan Engelhardt
Cc: Andrew Morton, Linux Kernel Mailing List, linux-fsdevel,
Ivan Kokshaysky, Bryan Wu, Mikael Starvik, David Howells,
Hirokazu Takata, Geert Uytterhoeven, Roman Zippel, Kyle McMartin,
Matthew Wilcox, Chris Zankel
On Jan 23, 2008 5:06 PM, Jan Engelhardt <jengelh@computergmbh.de> wrote:
>
> On Jan 23 2008 12:18, Bryan Wu wrote:
> >> [PATCH] procfs: constify function pointer tables
> >> ---
> >> arch/alpha/kernel/setup.c | 2 +-
> >> arch/blackfin/kernel/setup.c | 2 +-
> >> [...]
> >> diff --git a/arch/alpha/kernel/setup.c b/arch/alpha/kernel/setup.c
> >> index bd5e68c..823f18e 100644
> >> --- a/arch/alpha/kernel/setup.c
> >> +++ b/arch/alpha/kernel/setup.c
> >> @@ -1472,7 +1472,7 @@ c_stop(struct seq_file *f, void *v)
> >> {
> >> }
> >>
> >> -struct seq_operations cpuinfo_op = {
> >> +const struct seq_operations cpuinfo_op = {
> >> .start = c_start,
> >> .next = c_next,
> >> .stop = c_stop,
> [...]
> >Thanks, I understand the seq_xxx() API needs "const struct seq_operations *".
> >So for Blackfin part, I agree with Mike.
> >
> >but there are still some other files need add "const":
> >---
> >/opt/git-tree/blackfin-2.6$ grep -r seq_operations arch/*
> >arch/alpha/kernel/setup.c:struct seq_operations cpuinfo_op = {
>
> The patch already touches that :-)
>
Oh, this patch does not touch all, following is the missing list:
---
arch/arm/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/arm/mach-davinci/clock.c:static struct seq_operations davinci_ck_op = {
arch/avr32/kernel/cpu.c:struct seq_operations cpuinfo_op = {
arch/avr32/mm/tlb.c:static struct seq_operations tlb_ops = {
arch/ia64/hp/common/sba_iommu.c:static struct seq_operations ioc_seq_ops = {
arch/ia64/kernel/perfmon.c:struct seq_operations pfm_seq_ops = {
arch/ia64/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/ia64/sn/kernel/sn2/sn2_smp.c:static struct seq_operations
sn2_ptc_seq_ops = {
arch/ia64/sn/kernel/sn2/sn_hwperf.c:static struct seq_operations
sn_topology_seq_ops = {
arch/mips/kernel/proc.c:struct seq_operations cpuinfo_op = {
arch/powerpc/kernel/setup-common.c:struct seq_operations cpuinfo_op = {
arch/powerpc/platforms/pseries/hvCall_inst.c:static struct
seq_operations hcall_inst_seq_ops = {
arch/s390/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/sh/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/sh64/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/sparc/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/sparc64/kernel/setup.c:struct seq_operations cpuinfo_op = {
arch/x86/kernel/cpu/proc.c:struct seq_operations cpuinfo_op = {
arch/x86/kernel/setup_64.c:struct seq_operations cpuinfo_op = {
----
maybe you did not use the latest git tree.
-Bryan Wu
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] procfs: constify function pointer tables
2008-01-23 10:41 ` Bryan Wu
@ 2008-01-23 11:25 ` Jan Engelhardt
2008-01-23 12:16 ` Bryan Wu
0 siblings, 1 reply; 41+ messages in thread
From: Jan Engelhardt @ 2008-01-23 11:25 UTC (permalink / raw)
To: Bryan Wu
Cc: Andrew Morton, Linux Kernel Mailing List, linux-fsdevel,
Ivan Kokshaysky, Bryan Wu, Mikael Starvik, David Howells,
Hirokazu Takata, Geert Uytterhoeven, Roman Zippel, Kyle McMartin,
Matthew Wilcox, Chris Zankel
On Jan 23 2008 18:41, Bryan Wu wrote:
>Oh, this patch does not touch all, following is the missing list:
>---
[...]
>arch/ia64/hp/common/sba_iommu.c:static struct seq_operations ioc_seq_ops = {
>arch/ia64/kernel/perfmon.c:struct seq_operations pfm_seq_ops = {
>arch/ia64/kernel/setup.c:struct seq_operations cpuinfo_op = {
>arch/ia64/sn/kernel/sn2/sn2_smp.c:static struct seq_operations
(and more)
[...]
They were sent as other separate patches to each maintainer.
(without lkml, would have been a needless patchbomb.)
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] procfs: constify function pointer tables
2008-01-23 11:25 ` Jan Engelhardt
@ 2008-01-23 12:16 ` Bryan Wu
0 siblings, 0 replies; 41+ messages in thread
From: Bryan Wu @ 2008-01-23 12:16 UTC (permalink / raw)
To: Jan Engelhardt
Cc: Andrew Morton, Linux Kernel Mailing List, linux-fsdevel,
Ivan Kokshaysky, Bryan Wu, Mikael Starvik, David Howells,
Hirokazu Takata, Geert Uytterhoeven, Roman Zippel, Kyle McMartin,
Matthew Wilcox, Chris Zankel
On Jan 23, 2008 7:25 PM, Jan Engelhardt <jengelh@computergmbh.de> wrote:
>
> On Jan 23 2008 18:41, Bryan Wu wrote:
> >Oh, this patch does not touch all, following is the missing list:
> >---
> [...]
> >arch/ia64/hp/common/sba_iommu.c:static struct seq_operations ioc_seq_ops = {
> >arch/ia64/kernel/perfmon.c:struct seq_operations pfm_seq_ops = {
> >arch/ia64/kernel/setup.c:struct seq_operations cpuinfo_op = {
> >arch/ia64/sn/kernel/sn2/sn2_smp.c:static struct seq_operations
> (and more)
> [...]
>
> They were sent as other separate patches to each maintainer.
> (without lkml, would have been a needless patchbomb.)
>
Oh, don't know that. I worried a lot, -:))
-Bryan
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] KVM: constify function pointer tables
[not found] ` <Pine.LNX.4.64.0801222046010.5722-vVwEwcwQeYFPkBl3ERsXe1l1cybopEuJUBSOeVevoDU@public.gmane.org>
@ 2008-01-23 14:14 ` Avi Kivity
0 siblings, 0 replies; 41+ messages in thread
From: Avi Kivity @ 2008-01-23 14:14 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
Jan Engelhardt wrote:
> Signed-off-by: Jan Engelhardt <jengelh-bdq14YP6qtRlEiWPh9xO2Q@public.gmane.org>
> ---
> drivers/kvm/kvm_main.c | 4 ++--
Applied, but please generate patches against kvm.git as kvm moves
quickly. In this case, the file has moved to virt/kvm/.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] procfs: constify function pointer tables
2008-01-22 20:00 ` [PATCH] procfs: " Jan Engelhardt
` (4 preceding siblings ...)
2008-01-23 4:18 ` Bryan Wu
@ 2008-01-23 16:40 ` Jesper Nilsson
5 siblings, 0 replies; 41+ messages in thread
From: Jesper Nilsson @ 2008-01-23 16:40 UTC (permalink / raw)
To: Jan Engelhardt
Cc: Andrew Morton, Linux Kernel Mailing List, linux-fsdevel,
Ivan Kokshaysky, Bryan Wu, Mikael Starvik, David Howells,
Hirokazu Takata, Geert Uytterhoeven, Roman Zippel, Kyle McMartin,
Matthew Wilcox, Chris Zankel
On Tue, Jan 22, 2008 at 09:00:46PM +0100, Jan Engelhardt wrote:
> Hi,
>
> This touches so many different places that I did not feel like creating
> a miniscule patch for each architecture. I hope that is ok.
>
> ===Patch begins===
> [PATCH] procfs: constify function pointer tables
>
> Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
> ---
...
> diff --git a/arch/cris/kernel/setup.c b/arch/cris/kernel/setup.c
> index 65466c4..e42aedd 100644
> --- a/arch/cris/kernel/setup.c
> +++ b/arch/cris/kernel/setup.c
> @@ -180,7 +180,7 @@ static void c_stop(struct seq_file *m, void *v)
>
> extern int show_cpuinfo(struct seq_file *m, void *v);
>
> -struct seq_operations cpuinfo_op = {
> +const struct seq_operations cpuinfo_op = {
> .start = c_start,
> .next = c_next,
> .stop = c_stop,
CRIS port:
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] NET: constify data and function pointer tables
2008-01-22 19:47 ` [PATCH] NET: constify data and " Jan Engelhardt
@ 2008-01-30 9:25 ` Jeff Garzik
2008-01-30 16:11 ` John W. Linville
0 siblings, 1 reply; 41+ messages in thread
From: Jeff Garzik @ 2008-01-30 9:25 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: netdev, linux-wireless, John Linville
Jan Engelhardt wrote:
> Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
> ---
> drivers/net/bonding/bond_main.c | 2 +-
> drivers/net/hamradio/bpqether.c | 2 +-
> drivers/net/hamradio/scc.c | 2 +-
> drivers/net/hamradio/yam.c | 2 +-
> drivers/net/ibmveth.c | 2 +-
> drivers/net/pppoe.c | 2 +-
> drivers/net/pppol2tp.c | 4 ++--
> drivers/net/wireless/libertas/debugfs.c | 14 +++++++-------
> drivers/net/wireless/strip.c | 2 +-
> 9 files changed, 16 insertions(+), 16 deletions(-)
ACK -- but you should collect linville's ack of the wireless stuff too
(even though the patch is simple and obvious)
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] NET: constify data and function pointer tables
@ 2008-01-30 16:11 ` John W. Linville
0 siblings, 0 replies; 41+ messages in thread
From: John W. Linville @ 2008-01-30 16:11 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Jan Engelhardt, netdev, linux-wireless
On Wed, Jan 30, 2008 at 04:25:17AM -0500, Jeff Garzik wrote:
> Jan Engelhardt wrote:
>> Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
>> ---
>> drivers/net/bonding/bond_main.c | 2 +-
>> drivers/net/hamradio/bpqether.c | 2 +-
>> drivers/net/hamradio/scc.c | 2 +-
>> drivers/net/hamradio/yam.c | 2 +-
>> drivers/net/ibmveth.c | 2 +-
>> drivers/net/pppoe.c | 2 +-
>> drivers/net/pppol2tp.c | 4 ++--
>> drivers/net/wireless/libertas/debugfs.c | 14 +++++++-------
>> drivers/net/wireless/strip.c | 2 +-
>> 9 files changed, 16 insertions(+), 16 deletions(-)
>
> ACK -- but you should collect linville's ack of the wireless stuff too
> (even though the patch is simple and obvious)
Looks fine to me...ACK
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] NET: constify data and function pointer tables
@ 2008-01-30 16:11 ` John W. Linville
0 siblings, 0 replies; 41+ messages in thread
From: John W. Linville @ 2008-01-30 16:11 UTC (permalink / raw)
To: Jeff Garzik
Cc: Jan Engelhardt, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
On Wed, Jan 30, 2008 at 04:25:17AM -0500, Jeff Garzik wrote:
> Jan Engelhardt wrote:
>> Signed-off-by: Jan Engelhardt <jengelh-bdq14YP6qtRlEiWPh9xO2Q@public.gmane.org>
>> ---
>> drivers/net/bonding/bond_main.c | 2 +-
>> drivers/net/hamradio/bpqether.c | 2 +-
>> drivers/net/hamradio/scc.c | 2 +-
>> drivers/net/hamradio/yam.c | 2 +-
>> drivers/net/ibmveth.c | 2 +-
>> drivers/net/pppoe.c | 2 +-
>> drivers/net/pppol2tp.c | 4 ++--
>> drivers/net/wireless/libertas/debugfs.c | 14 +++++++-------
>> drivers/net/wireless/strip.c | 2 +-
>> 9 files changed, 16 insertions(+), 16 deletions(-)
>
> ACK -- but you should collect linville's ack of the wireless stuff too
> (even though the patch is simple and obvious)
Looks fine to me...ACK
--
John W. Linville
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] [AF_RXRPC]: constify function pointer tables
2008-01-22 19:47 ` [PATCH] [AF_RXRPC]: constify " Jan Engelhardt
@ 2008-01-31 3:05 ` David Miller
0 siblings, 0 replies; 41+ messages in thread
From: David Miller @ 2008-01-31 3:05 UTC (permalink / raw)
To: jengelh; +Cc: dhowells, netdev
From: Jan Engelhardt <jengelh@computergmbh.de>
Date: Tue, 22 Jan 2008 20:47:51 +0100 (CET)
> Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH] [MIPS]: fix CAC_ADDR/UNCAC_ADDR
2008-01-22 19:42 ` [PATCH] [MIPS]: constify function pointer tables Jan Engelhardt
2008-01-23 0:32 ` Ralf Baechle
@ 2008-02-07 12:41 ` peter fuerst
1 sibling, 0 replies; 41+ messages in thread
From: peter fuerst @ 2008-02-07 12:41 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips
With commit db38501511a7513ec4f0ae9922d847c135cf3c78 PAGE_OFFSET was
redefined as CAC_BASE+PHYS_OFFSET, but [UN]CAC_ADDR - which are used
in dma_alloc_coherent() and dma_free_coherent() respectively, and in
drivers/video/au1100fb.c - were not adjusted accordingly.
with kind regards
Signed-off-by: peter fuerst <post@pfrst.de>
--- a/linux-2.6.24/include/asm-mips/page.h Fri Jan 25 12:23:51 2008
+++ b/linux-2.6.24/include/asm-mips/page.h Wed Feb 6 23:26:31 2008
@@ -184,8 +184,8 @@
#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
-#define UNCAC_ADDR(addr) ((addr) - PAGE_OFFSET + UNCAC_BASE)
-#define CAC_ADDR(addr) ((addr) - UNCAC_BASE + PAGE_OFFSET)
+#define UNCAC_ADDR(addr) ((addr) - PAGE_OFFSET + PHYS_OFFSET + UNCAC_BASE)
+#define CAC_ADDR(addr) ((addr) - UNCAC_BASE + PAGE_OFFSET - PHYS_OFFSET)
#include <asm-generic/memory_model.h>
#include <asm-generic/page.h>
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH] [CRYPTO]: constify function pointer tables
2008-01-22 19:44 ` [PATCH] [CRYPTO]: " Jan Engelhardt
@ 2008-03-13 11:38 ` Herbert Xu
0 siblings, 0 replies; 41+ messages in thread
From: Herbert Xu @ 2008-03-13 11:38 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: linux-crypto
On Tue, Jan 22, 2008 at 08:44:23PM +0100, Jan Engelhardt wrote:
> Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
Patch applied. Thanks!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 41+ messages in thread
end of thread, other threads:[~2008-03-13 11:38 UTC | newest]
Thread overview: 41+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
2008-01-22 19:42 ` [PATCH] [MIPS]: constify function pointer tables Jan Engelhardt
2008-01-23 0:32 ` Ralf Baechle
2008-02-07 12:41 ` [PATCH] [MIPS]: fix CAC_ADDR/UNCAC_ADDR peter fuerst
2008-01-22 19:43 ` [PATCH] [POWERPC]: constify function pointer tables Jan Engelhardt
2008-01-22 23:11 ` Stephen Rothwell
2008-01-22 19:44 ` [PATCH] [CRYPTO]: " Jan Engelhardt
2008-03-13 11:38 ` Herbert Xu
2008-01-22 19:44 ` [PATCH] ACPI: " Jan Engelhardt
2008-01-22 19:47 ` [PATCH] NET: constify data and " Jan Engelhardt
2008-01-30 9:25 ` Jeff Garzik
2008-01-30 16:11 ` John W. Linville
2008-01-30 16:11 ` John W. Linville
2008-01-22 19:47 ` [PATCH] [AF_RXRPC]: constify " Jan Engelhardt
2008-01-31 3:05 ` David Miller
[not found] ` <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh-bdq14YP6qtRlEiWPh9xO2Q@public.gmane.org>
2008-01-22 19:46 ` [PATCH] KVM: " Jan Engelhardt
[not found] ` <Pine.LNX.4.64.0801222046010.5722-vVwEwcwQeYFPkBl3ERsXe1l1cybopEuJUBSOeVevoDU@public.gmane.org>
2008-01-23 14:14 ` Avi Kivity
2008-01-22 19:48 ` [PATCH] [NFS]: " Jan Engelhardt
2008-01-22 19:48 ` [NFS] [PATCH] knfsd: " Jan Engelhardt
2008-01-22 19:49 ` [PATCH] [MTD]: " Jan Engelhardt
2008-01-22 19:50 ` [PATCH] md: " Jan Engelhardt
2008-01-22 19:51 ` [PATCH] x86: " Jan Engelhardt
2008-01-22 20:56 ` Ingo Molnar
2008-01-22 19:52 ` [PATCH] [AF_X25]: " Jan Engelhardt
2008-01-23 2:30 ` David Miller
2008-01-22 19:53 ` [Ocfs2-devel] [PATCH] [OCFS2]: " Jan Engelhardt
2008-01-22 19:53 ` [Cluster-devel] [PATCH] [DLM]: " Jan Engelhardt
2008-01-22 19:54 ` [PATCH] [SCSI]: " Jan Engelhardt
2008-01-22 20:37 ` James Smart
2008-01-22 19:55 ` [PATCH] input: " Jan Engelhardt
2008-01-22 20:00 ` [PATCH] procfs: " Jan Engelhardt
2008-01-22 21:25 ` Geert Uytterhoeven
2008-01-22 22:43 ` Mike Frysinger
2008-01-22 22:57 ` David Howells
2008-01-22 23:36 ` Stephen Rothwell
2008-01-23 4:18 ` Bryan Wu
2008-01-23 9:06 ` Jan Engelhardt
2008-01-23 10:41 ` Bryan Wu
2008-01-23 11:25 ` Jan Engelhardt
2008-01-23 12:16 ` Bryan Wu
2008-01-23 16:40 ` Jesper Nilsson
2008-01-22 20:01 ` [PATCH] kernel: constify data and " Jan Engelhardt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.