[PATCH] ioemu: 'lib64' is Linux-specific

[PATCH] ioemu: 'lib64' is Linux-specific

[john.levon]

# HG changeset patch
# User john.levon@sun.com
# Date 1201123340 28800
# Node ID 7e4475e2a9ea0757596627bf86c4626b83bed2f2
# Parent  433792312a402e3169c7453e0a82a4c85f6f65f1
ioemu: 'lib64' is Linux-specific

Only use libdir == 'lib64' on Linux.

Signed-off-by: John Levon <john.levon@sun.com>

diff --git a/tools/ioemu/configure b/tools/ioemu/configure
--- a/tools/ioemu/configure
+++ b/tools/ioemu/configure
@@ -42,7 +42,7 @@ case "$XEN_TARGET_ARCH" in
   ;;
   x86_64)
     cpu="x86_64"
-    libdir="lib64"
+    [ `uname -s` = "Linux" ] && libdir="lib64"
   ;;
   *)
     cpu="unknown"

Re: [PATCH] ioemu: 'lib64' is Linux-specific

[Daniel P. Berrange]

On Wed, Jan 23, 2008 at 01:22:27PM -0800, john.levon@sun.com wrote:
> # HG changeset patch
> # User john.levon@sun.com
> # Date 1201123340 28800
> # Node ID 7e4475e2a9ea0757596627bf86c4626b83bed2f2
> # Parent  433792312a402e3169c7453e0a82a4c85f6f65f1
> ioemu: 'lib64' is Linux-specific
> 
> Only use libdir == 'lib64' on Linux.

Actually that's not entirely correct either - lib64 is specific to multi-lib
Linux distros only. Fedora / RHEL are multi-lib, Debian isn't.

To be honest, Xen shouldn't be putting binaries in /usr/{lib,lib64}/xen/bin.
They should be in /usr/libexec instead. For compat with existing 
configs a symlink from /usr/{lib,lib64}/xen/bin to /usr/libexec could be
used

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

Re: [PATCH] ioemu: 'lib64' is Linux-specific

[John Levon]

On Wed, Jan 23, 2008 at 09:33:26PM +0000, Daniel P. Berrange wrote:

> Actually that's not entirely correct either - lib64 is specific to multi-lib
> Linux distros only. Fedora / RHEL are multi-lib, Debian isn't.

Thanks for the correction. I have no idea how to handle that difference,
so someone from Debian will have to fix this up further.

> To be honest, Xen shouldn't be putting binaries in /usr/{lib,lib64}/xen/bin.
> They should be in /usr/libexec instead. For compat with existing 
> configs a symlink from /usr/{lib,lib64}/xen/bin to /usr/libexec could be
> used

Fine for StdGNU I suppose (on Solaris, they'll stay in /usr/lib/xen/bin)

cheers,
john

Re: [PATCH] ioemu: 'lib64' is Linux-specific

[Samuel Thibault]

John Levon, le Wed 23 Jan 2008 21:56:16 +0000, a écrit :
> On Wed, Jan 23, 2008 at 09:33:26PM +0000, Daniel P. Berrange wrote:
> 
> > Actually that's not entirely correct either - lib64 is specific to multi-lib
> > Linux distros only. Fedora / RHEL are multi-lib, Debian isn't.
> 
> Thanks for the correction. I have no idea how to handle that difference,
> so someone from Debian will have to fix this up further.

Debian is multilib too. On 64bit systems, lib64 points to lib and
there's a lib32 pointing to /emul/ia32-linux/usr/lib.

Samuel