[PATCH] usb/caiaq: decrease period_bytes_min

[PATCH] usb/caiaq: decrease period_bytes_min

[Daniel Mack]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

This patch increases the snd_pcm_hardware->period_bytes_min field in the
caiaq/usb audio driver. The hardware can actually handle as few as 128
bytes, depending on the system. So it makes no sense to keep
applications from actually using such values.

Signed-off-by: Daniel Mack <daniel@caiaq.de>



[-- Attachment #2: caiaq-periods.diff --]
[-- Type: text/x-diff, Size: 1008 bytes --]

diff --git a/sound/usb/caiaq/caiaq-audio.c b/sound/usb/caiaq/caiaq-audio.c
index 2f9e9b2..9cc4cd8 100644
--- a/sound/usb/caiaq/caiaq-audio.c
+++ b/sound/usb/caiaq/caiaq-audio.c
@@ -57,7 +57,7 @@ static struct snd_pcm_hardware snd_usb_caiaq_pcm_hardware = {
 	.channels_min	= CHANNELS_PER_STREAM,
 	.channels_max	= CHANNELS_PER_STREAM,
 	.buffer_bytes_max = MAX_BUFFER_SIZE,
-	.period_bytes_min = 4096,
+	.period_bytes_min = 128,
 	.period_bytes_max = MAX_BUFFER_SIZE,
 	.periods_min	= 1,
 	.periods_max	= 1024,
diff --git a/sound/usb/caiaq/caiaq-device.c b/sound/usb/caiaq/caiaq-device.c
index 5cd92ae..58d25e4 100644
--- a/sound/usb/caiaq/caiaq-device.c
+++ b/sound/usb/caiaq/caiaq-device.c
@@ -42,7 +42,7 @@
 #endif
 
 MODULE_AUTHOR("Daniel Mack <daniel@caiaq.de>");
-MODULE_DESCRIPTION("caiaq USB audio, version 1.3.1");
+MODULE_DESCRIPTION("caiaq USB audio, version 1.3.2");
 MODULE_LICENSE("GPL");
 MODULE_SUPPORTED_DEVICE("{{Native Instruments, RigKontrol2},"
 			 "{Native Instruments, RigKontrol3},"

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] usb/caiaq: decrease period_bytes_min

[Takashi Iwai]

At Thu, 24 Jan 2008 18:44:07 +0100,
Daniel Mack wrote:
> 
> This patch increases the snd_pcm_hardware->period_bytes_min field in the

decrease, right? :)

> caiaq/usb audio driver. The hardware can actually handle as few as 128
> bytes, depending on the system. So it makes no sense to keep
> applications from actually using such values.
> 
> Signed-off-by: Daniel Mack <daniel@caiaq.de>

Applied to HG tree.  Thanks.


Takashi

Re: [PATCH] usb/caiaq: decrease period_bytes_min

[Daniel Mack]

On Thu, Jan 24, 2008 at 06:46:38PM +0100, Takashi Iwai wrote:
> > This patch increases the snd_pcm_hardware->period_bytes_min field in the
> 
> decrease, right? :)

On closer examination, 128 is actually less than 4096, yes. Except for
very large values of 128. ;)

Daniel