All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Michael Buesch <mb@bu3sch.de>, Dan Williams <dcbw@redhat.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org
Subject: Re: Linux 2.6.24-rc7
Date: Fri, 25 Jan 2008 17:46:31 -0500	[thread overview]
Message-ID: <20080125224631.GH14687@tuxdriver.com> (raw)
In-Reply-To: <alpine.LFD.1.00.0801251354350.5056@hp.linux-foundation.org>

On Fri, Jan 25, 2008 at 01:56:15PM -0800, Linus Torvalds wrote:
> 
> 
> On Fri, 25 Jan 2008, John W. Linville wrote:
> > 
> > Anyway, this is mostly just so we can scope the driver change required
> > in absence of a firmware change.  Persumably the changes required if
> > we were to put such code in mac80211 would be similar.
> 
> Make this conditional on archictures that need it, please.
> 
> And why is it suddenly smart to do this in three drivers rather than one 
> upper layer?

Two drivers, FWIW... :-)

Given that we don't have a CONFIG_MUST_ALIGN at present, I'm not sure
it is worth adding one for either an iwlwifi fix or a mac80211 one.
Or are there other issues that might be resolved or aided by such
a definition?  It doesn't seem to have been needed so far.

Maybe it would be easier to add a CONFIG_MAC80211_ALIGN_PAYLOAD option
around some code in mac80211 to fix-up alignments?  Then users of
alignment-sensitive arches could turn-on that option, and the rest
of us would leave it off.  Another (non-exclusive) option would be
to put CONFIG_MAC80211_DEBUG around the alignment warning so that
most people would never see it.

Thoughts?  I'm just looking for a resolution... :-)

John
-- 
John W. Linville
linville@tuxdriver.com

  reply	other threads:[~2008-01-25 23:03 UTC|newest]

Thread overview: 127+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-06 22:19 Linux 2.6.24-rc7 Linus Torvalds
2008-01-06 23:52 ` Mark Lord
2008-01-07  0:08   ` Linus Torvalds
2008-01-07  0:35     ` Tejun Heo
2008-01-07  8:48 ` Linux 2.6.24-rc7 Build Failure on headers_install Kamalesh Babulal
2008-01-07 10:12   ` Sam Ravnborg
2008-01-08 10:51     ` Kamalesh Babulal
2008-01-08 13:10       ` Sam Ravnborg
2008-01-07 10:36 ` Linux 2.6.24-rc7 Build-Failure at __you_cannot_kmalloc_that_much Kamalesh Babulal
2008-01-07 18:07   ` Andrew Morton
2008-01-07 18:31     ` Christoph Lameter
2008-01-07 19:38       ` Andrew Morton
2008-01-08  9:56         ` Jean Delvare
2008-01-08 10:44           ` Kamalesh Babulal
2008-01-08 12:34           ` Fix for __you_cannot_kmalloc_that_much failure with gcc 3.2 Jean Delvare
2008-01-08  4:20       ` Linux 2.6.24-rc7 Build-Failure at __you_cannot_kmalloc_that_much Arjan van de Ven
2008-01-08  5:23         ` Christoph Lameter
2008-01-08  8:20     ` Kamalesh Babulal
2008-01-08  9:27       ` Balbir Singh
2008-01-08  7:48   ` Jean Delvare
2008-01-07 12:13 ` Linux 2.6.24-rc7 kernel BUG at kernel/sched.c:5156! Kamalesh Babulal
2008-01-08 16:16   ` [powerpc crash] " Ingo Molnar
2008-01-07 15:53 ` Linux 2.6.24-rc7 Alejandro Riveira Fernández
2008-01-07 16:27   ` smpboot_64 section mismatch warning Sam Ravnborg
2008-01-07 23:27     ` David Howells
2008-01-08  9:14       ` Alejandro Riveira Fernández
2008-01-08 11:17     ` David Howells
2008-01-07 16:31   ` section mismatch warning in head_64.S Sam Ravnborg
2008-01-15 10:18     ` Alejandro Riveira Fernández
2008-01-07 16:14 ` Linux 2.6.24-rc7 Alejandro Riveira Fernández
2008-01-07 16:14   ` Alejandro Riveira Fernández
2008-01-07 16:24   ` Michael Buesch
2008-01-07 16:24     ` Michael Buesch
2008-01-07 16:52     ` Alejandro Riveira Fernández
2008-01-07 16:52       ` Alejandro Riveira Fernández
2008-01-07 17:30       ` Michael Buesch
2008-01-07 17:30         ` Michael Buesch
2008-01-07 20:23         ` Alejandro Riveira Fernández
2008-01-07 20:23           ` Alejandro Riveira Fernández
2008-01-08 15:30           ` Michael Buesch
2008-01-08 15:30             ` Michael Buesch
2008-01-08 15:55             ` Alejandro Riveira Fernández
2008-01-08 15:55               ` Alejandro Riveira Fernández
2008-01-24 20:27             ` Linus Torvalds
2008-01-24 21:07               ` John W. Linville
2008-01-24 21:34                 ` Linus Torvalds
2008-01-25 12:29                   ` Johannes Berg
2008-01-25 16:08                     ` Linus Torvalds
2008-01-25 16:23                       ` Michael Buesch
2008-01-25 16:43                         ` Linus Torvalds
2008-01-25 17:27                           ` Dan Williams
2008-01-25 17:38                             ` Linus Torvalds
2008-01-25 17:42                               ` Dan Williams
2008-02-05 20:55                                 ` Russell S. Senior
2008-01-25 18:22                               ` Linus Torvalds
2008-01-25 18:30                                 ` Michael Buesch
2008-01-25 19:07                                   ` Linus Torvalds
2008-01-25 19:34                                     ` Michael Buesch
2008-01-25 19:48                                     ` John W. Linville
2008-01-25 19:50                                       ` John W. Linville
2008-01-25 21:18                                         ` John W. Linville
2008-01-25 21:56                                           ` Linus Torvalds
2008-01-25 22:46                                             ` John W. Linville [this message]
2008-01-25 23:20                                               ` Guy Cohen
2008-01-26 13:53                                               ` David Miller
2008-01-26 13:47                                             ` David Miller
2008-01-25 22:02                                           ` Guy Cohen
2008-01-26 13:40                                           ` David Miller
2008-01-25 20:28                                       ` Linus Torvalds
2008-01-26 13:37                                         ` David Miller
2008-01-27  6:32                                           ` Linus Torvalds
2008-01-27  7:16                                             ` Jeff Garzik
2008-01-27  7:24                                               ` David Miller
2008-01-27  7:54                                                 ` Linus Torvalds
2008-01-28  3:15                                                   ` David Miller
2008-01-25 23:22                                     ` Jeff Garzik
2008-01-26 13:27                                     ` David Miller
2008-01-27  6:25                                       ` Linus Torvalds
2008-01-26 13:22                                 ` David Miller
2008-01-25 18:21                           ` Michael Buesch
2008-01-25 18:34                             ` Linus Torvalds
2008-01-25 18:41                               ` Michael Buesch
2008-01-25 21:11                                 ` Inaky Perez-Gonzalez
2008-01-25 21:21                                   ` Michael Buesch
2008-01-25 21:28                                     ` Inaky Perez-Gonzalez
2008-01-26 13:42                                       ` David Miller
2008-01-27  2:26                                         ` Luis R. Rodriguez
2008-01-29 19:07                                         ` Inaky Perez-Gonzalez
2008-01-25 21:46                                     ` John W. Linville
2008-01-25 22:15                                       ` Michael Buesch
2008-01-25 22:34                                       ` Tomas Winkler
2008-01-26 13:49                                       ` David Miller
2008-01-25 21:46                                     ` Guy Cohen
2008-01-25 21:54                                     ` Linus Torvalds
2008-01-26 13:46                                       ` David Miller
2008-01-25 18:34                             ` John W. Linville
2008-01-24 22:17               ` Michael Buesch
2008-01-24 22:26                 ` Linus Torvalds
2008-01-24 22:33                   ` Michael Buesch
2008-01-08  0:50 ` J.A. Magallón
2008-01-09  1:32   ` Avuton Olrich
2008-01-09  1:56   ` Tejun Heo
2008-01-10  9:25     ` J.A. Magallón
2008-01-10 13:10       ` Tejun Heo
2008-01-13 23:19         ` J.A. Magallón
2008-01-13 23:57           ` Tejun Heo
2008-01-14 23:38             ` J.A. Magallón
2008-01-14 23:56               ` Tejun Heo
2008-01-08 18:42 ` Linux 2.6.24-rc7: sparc64: WARNING: at kernel/lockdep_proc.c:267 lockdep_stats_show() Mariusz Kozlowski
2008-01-08 18:42   ` Mariusz Kozlowski
2008-01-08 21:00   ` Linux 2.6.24-rc7: sparc64: WARNING: at Randy Dunlap
2008-01-08 21:00     ` Linux 2.6.24-rc7: sparc64: WARNING: at kernel/lockdep_proc.c:267 lockdep_stats_show() Randy Dunlap
2008-01-08 22:39     ` Mariusz Kozlowski
2008-01-08 22:39       ` Mariusz Kozlowski
2008-01-08 22:45       ` Linux 2.6.24-rc7: sparc64: WARNING: at kernel/lockdep_proc.c:267 Randy Dunlap
2008-01-08 22:45         ` Linux 2.6.24-rc7: sparc64: WARNING: at kernel/lockdep_proc.c:267 lockdep_stats_show() Randy Dunlap
2008-01-09 16:31         ` Mariusz Kozlowski
2008-01-09 16:31           ` Mariusz Kozlowski
2008-01-08 22:50   ` Linux 2.6.24-rc7: sparc64: WARNING: at David Miller
2008-01-08 22:50     ` Linux 2.6.24-rc7: sparc64: WARNING: at kernel/lockdep_proc.c:267 lockdep_stats_show() David Miller
2008-01-08 22:56     ` Linux 2.6.24-rc7: sparc64: WARNING: at Ingo Molnar
2008-01-08 22:56       ` Linux 2.6.24-rc7: sparc64: WARNING: at kernel/lockdep_proc.c:267 lockdep_stats_show() Ingo Molnar
2008-01-08 23:06       ` Linux 2.6.24-rc7: sparc64: WARNING: at David Miller
2008-01-08 23:06         ` Linux 2.6.24-rc7: sparc64: WARNING: at kernel/lockdep_proc.c:267 lockdep_stats_show() David Miller
2008-01-09  0:52         ` Linux 2.6.24-rc7: sparc64: WARNING: at Ingo Molnar
2008-01-09  0:52           ` Linux 2.6.24-rc7: sparc64: WARNING: at kernel/lockdep_proc.c:267 lockdep_stats_show() Ingo Molnar
2008-01-09  1:17 ` Linux 2.6.24-rc7 Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080125224631.GH14687@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=dcbw@redhat.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mb@bu3sch.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.