All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Matt Helsley <matthltc@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	viro@ftp.linux.org.uk, dhowells@redhat.com, wtaber@us.ibm.com,
	owilliam@br.ibm.com, rkissel@us.ibm.com, hch@lst.de
Subject: Re: [PATCH] Fix procfs task exe symlink
Date: Sat, 26 Jan 2008 22:03:36 -0800	[thread overview]
Message-ID: <20080126220336.a2a3caf7.akpm@linux-foundation.org> (raw)
In-Reply-To: <1201112977.5443.29.camel@localhost.localdomain>

> On Wed, 23 Jan 2008 10:29:37 -0800 Matt Helsley <matthltc@us.ibm.com> wrote:
> 
> Andrew, please consider this patch for inclusion in -mm.
> 
> ...
>

Can't say that we're particularly exercised about mvfs's problems, but the
current way of doing /proc/pid/exe is indeed a nasty hack.

> 
>  fs/binfmt_flat.c          |    3 +
>  fs/exec.c                 |    2 +
>  fs/proc/base.c            |   77 ++++++++++++++++++++++++++++++++++++++++++++++
>  fs/proc/internal.h        |    1 
>  fs/proc/task_mmu.c        |   34 --------------------
>  fs/proc/task_nommu.c      |   34 --------------------
>  include/linux/init_task.h |    8 ++++
>  include/linux/mm.h        |   22 +++++++++++++
>  include/linux/mm_types.h  |    7 ++++
>  include/linux/proc_fs.h   |   14 +++++++-
>  kernel/fork.c             |    3 +
>  mm/mmap.c                 |   22 ++++++++++---
>  mm/nommu.c                |   15 +++++++-
>  13 files changed, 164 insertions(+), 78 deletions(-)

It's a fairly expensive fix though.  Can't we just do a strcpy() somewhere
at exec time?



WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Matt Helsley <matthltc@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	viro@ftp.linux.org.uk, dhowells@redhat.com, wtaber@us.ibm.com,
	owilliam@br.ibm.com, rkissel@us.ibm.com, hch@lst.de
Subject: Re: [PATCH] Fix procfs task exe symlink
Date: Sat, 26 Jan 2008 22:03:36 -0800	[thread overview]
Message-ID: <20080126220336.a2a3caf7.akpm@linux-foundation.org> (raw)
In-Reply-To: <1201112977.5443.29.camel@localhost.localdomain>

> On Wed, 23 Jan 2008 10:29:37 -0800 Matt Helsley <matthltc@us.ibm.com> wrote:
> 
> Andrew, please consider this patch for inclusion in -mm.
> 
> ...
>

Can't say that we're particularly exercised about mvfs's problems, but the
current way of doing /proc/pid/exe is indeed a nasty hack.

> 
>  fs/binfmt_flat.c          |    3 +
>  fs/exec.c                 |    2 +
>  fs/proc/base.c            |   77 ++++++++++++++++++++++++++++++++++++++++++++++
>  fs/proc/internal.h        |    1 
>  fs/proc/task_mmu.c        |   34 --------------------
>  fs/proc/task_nommu.c      |   34 --------------------
>  include/linux/init_task.h |    8 ++++
>  include/linux/mm.h        |   22 +++++++++++++
>  include/linux/mm_types.h  |    7 ++++
>  include/linux/proc_fs.h   |   14 +++++++-
>  kernel/fork.c             |    3 +
>  mm/mmap.c                 |   22 ++++++++++---
>  mm/nommu.c                |   15 +++++++-
>  13 files changed, 164 insertions(+), 78 deletions(-)

It's a fairly expensive fix though.  Can't we just do a strcpy() somewhere
at exec time?


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2008-01-27  6:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-23 18:29 [PATCH] Fix procfs task exe symlink Matt Helsley
2008-01-23 18:29 ` Matt Helsley
2008-01-23 19:01 ` Jan Engelhardt
2008-01-23 19:01   ` Jan Engelhardt
2008-01-25  0:09   ` Erez Zadok
2008-01-25  0:09     ` Erez Zadok
2008-01-23 19:41 ` Christoph Hellwig
2008-01-23 19:41   ` Christoph Hellwig
2008-01-23 20:46 ` David Howells
2008-01-23 20:46   ` David Howells
2008-01-27  6:03 ` Andrew Morton [this message]
2008-01-27  6:03   ` Andrew Morton
2008-01-29  0:18   ` Matt Helsley
2008-01-29  0:18     ` Matt Helsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080126220336.a2a3caf7.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=matthltc@us.ibm.com \
    --cc=owilliam@br.ibm.com \
    --cc=rkissel@us.ibm.com \
    --cc=viro@ftp.linux.org.uk \
    --cc=wtaber@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.