From: Greg KH <greg@kroah.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
sfr@canb.auug.org.au
Subject: Re: [PATCH] Fix powerpc vio_find_name to not use devices_subsys
Date: Sat, 26 Jan 2008 21:36:06 -0800 [thread overview]
Message-ID: <20080127053606.GA24306@kroah.com> (raw)
In-Reply-To: <18331.54314.379281.960297@cargo.ozlabs.ibm.com>
On Sun, Jan 27, 2008 at 11:45:30AM +1100, Paul Mackerras wrote:
> This fixes vio_find_name() in arch/powerpc/kernel/vio.c, which is
> currently broken because it tries to use devices_subsys. That is bad
> for two reasons: (1) it's doing (or trying to do) a scan of all
> devices when it should only be scanning those on the vio bus, and
> (2) devices_subsys was an internal symbol of the device system code
> which was never meant for external use and has now gone away, and
> thus the kernel fails to compile on pSeries.
>
> The new version uses bus_find_device() on the vio bus (vio_bus_type).
>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
> ---
> Greg, do you want to send this to Linus or will I do that? Or do you
> have a better version? :)
I'll send it to him, with a minor change (I'm going to make this a core
function, as others also use the same functionality, no need for
everyone to re-invent the wheel all the time.
I also have some other patches to send him to fix up the fall-out of
these driver core changes :)
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
sfr@canb.auug.org.au
Subject: Re: [PATCH] Fix powerpc vio_find_name to not use devices_subsys
Date: Sat, 26 Jan 2008 21:36:06 -0800 [thread overview]
Message-ID: <20080127053606.GA24306@kroah.com> (raw)
In-Reply-To: <18331.54314.379281.960297@cargo.ozlabs.ibm.com>
On Sun, Jan 27, 2008 at 11:45:30AM +1100, Paul Mackerras wrote:
> This fixes vio_find_name() in arch/powerpc/kernel/vio.c, which is
> currently broken because it tries to use devices_subsys. That is bad
> for two reasons: (1) it's doing (or trying to do) a scan of all
> devices when it should only be scanning those on the vio bus, and
> (2) devices_subsys was an internal symbol of the device system code
> which was never meant for external use and has now gone away, and
> thus the kernel fails to compile on pSeries.
>
> The new version uses bus_find_device() on the vio bus (vio_bus_type).
>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
> ---
> Greg, do you want to send this to Linus or will I do that? Or do you
> have a better version? :)
I'll send it to him, with a minor change (I'm going to make this a core
function, as others also use the same functionality, no need for
everyone to re-invent the wheel all the time.
I also have some other patches to send him to fix up the fall-out of
these driver core changes :)
thanks,
greg k-h
next prev parent reply other threads:[~2008-01-27 5:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-27 0:45 [PATCH] Fix powerpc vio_find_name to not use devices_subsys Paul Mackerras
2008-01-27 5:36 ` Greg KH [this message]
2008-01-27 5:36 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080127053606.GA24306@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.