Re: (Updated) [Patch] Shut up warnings from files under drivers/

[WANG Cong <xiyou.wangcong@gmail.com>]

On Sun, Jan 27, 2008 at 10:21:12AM +0100, Jiri Slaby wrote:
>On 01/27/2008 10:08 AM, Jiri Slaby wrote:
>>On 01/27/2008 05:15 AM, WANG Cong wrote:
>>>Fix defined-but-not-used warnings from files under drivers/,
>>>such as:
>>>
>>>drivers/char/applicom.c:68: warning: ‘applicom_pci_tbl’ defined but 
>>>not used
>>>
>>>Compile tests passed.
>>>
>>>Cc: Jeff Garzik <jeff@garzik.org>
>>>Cc: Greg KH <gregkh@suse.de>
>>>Cc: Sam Ravnborg <sam@ravnborg.org>
>>>Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
>>>
>>>---
>>>
>>>diff --git a/drivers/char/applicom.c b/drivers/char/applicom.c
>>>index 1f0b752..97171ad 100644
>>>--- a/drivers/char/applicom.c
>>>+++ b/drivers/char/applicom.c
>>>@@ -65,7 +65,7 @@ static char *applicom_pci_devnames[] = {
>>>     "PCI2000PFB"
>>> };
>>> 
>>>-static struct pci_device_id applicom_pci_tbl[] = {
>>>+static struct pci_device_id applicom_pci_tbl[] __used = {
>>>     { PCI_VENDOR_ID_APPLICOM, PCI_DEVICE_ID_APPLICOM_PCIGENERIC,
>>>       PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
>>>     { PCI_VENDOR_ID_APPLICOM, PCI_DEVICE_ID_APPLICOM_PCI2000IBS_CAN,
>>
>>I have probably a better fix with pci_match_id() referencing this array.
>
>Hmm, checking it one more time persuades me that the best fix ever is to 
>convert it to probing. David, do you have the card?

OK. I will drop this part.