From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, dwmw2@infradead.org,
xiyou.wangcong@gmail.com
Subject: Re: [PATCH 2/2] Char: applicom, use pci_match_id
Date: Thu, 31 Jan 2008 10:26:17 +0100 [thread overview]
Message-ID: <47A19439.90409@gmail.com> (raw)
In-Reply-To: <20080130151022.c52ad664.akpm@linux-foundation.org>
On 01/31/2008 12:10 AM, Andrew Morton wrote:
> On Wed, 30 Jan 2008 12:13:15 +0100
> Jiri Slaby <jirislaby@gmail.com> wrote:
>
>> + if (!pci_match_id(applicom_pci_tbl, dev));
>> continue;
>
>
> The patch was carelessly prepared, was not runtine-tested and was not
> passed through checkpatch, which detects this error. Please fix these
> things, permanently.
Yes, you're right, I definitely need to change my workflow, this needn't happen.
next prev parent reply other threads:[~2008-01-31 9:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-26 9:30 [Patch] Shut up warnings from files under drivers/ WANG Cong
2008-01-26 9:55 ` Jeff Garzik
2008-01-26 10:18 ` WANG Cong
2008-01-26 11:44 ` Jeff Garzik
2008-01-26 19:17 ` Sam Ravnborg
2008-01-26 19:30 ` Sam Ravnborg
2008-01-27 2:50 ` WANG Cong
2008-01-27 4:15 ` (Updated) " WANG Cong
2008-01-27 9:08 ` Jiri Slaby
2008-01-27 9:21 ` Jiri Slaby
2008-01-28 5:20 ` WANG Cong
2008-01-27 9:21 ` Sam Ravnborg
2008-01-28 5:49 ` (Try#3) " WANG Cong
[not found] ` <1201691351-1038?= =?ISO-8859-1?Q?4-1-git-send-ema?= =?ISO-8859-1?Q?il-=1B[D>
2008-01-30 11:10 ` [PATCH 1/2] Char: applicom, use pci_resource_start Jiri Slaby
2008-01-30 11:13 ` Jiri Slaby
2008-01-30 11:13 ` [PATCH 2/2] Char: applicom, use pci_match_id Jiri Slaby
2008-01-30 23:10 ` Andrew Morton
2008-01-31 9:26 ` Jiri Slaby [this message]
2008-01-26 9:57 ` [Patch] Shut up warnings from files under drivers/ Sam Ravnborg
2008-01-26 10:15 ` WANG Cong
2008-01-26 10:21 ` Sam Ravnborg
2008-01-26 10:26 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A19439.90409@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.