Re: grub-fstest: debug tool for filesystem driver

[Robert Millan <rmh@aybabtu.com>]

On Sat, Jan 05, 2008 at 08:11:21PM +0800, Bean wrote:
> diff --git a/conf/i386-pc.rmk b/conf/i386-pc.rmk
> index 2638ee5..a25dd76 100644
> --- a/conf/i386-pc.rmk
> +++ b/conf/i386-pc.rmk
> @@ -59,6 +59,9 @@ sbin_UTILITIES = grub-setup grub-mkdevicemap grub-probe
>  ifeq ($(enable_grub_emu), yes)
>  sbin_UTILITIES += grub-emu
>  endif
> +ifeq ($(enable_grub_fstest), yes)
> +bin_UTILITIES += grub-fstest
> +endif
> 
>  # For grub-mkimage.
>  grub_mkimage_SOURCES = util/i386/pc/grub-mkimage.c util/misc.c \
> @@ -121,6 +124,18 @@ grub_emu_SOURCES = commands/boot.c commands/cat.c
> commands/cmp.c	\
> 
>  grub_emu_LDFLAGS = $(LIBCURSES)
> 
> +# For grub-fstest.
> +util/grub-fstest.c_DEPENDENCIES = grub_fstest_init.h
> +grub_fstest_SOURCES = util/grub-fstest.c util/hostfs.c util/misc.c 	\
> +	kern/file.c kern/device.c kern/disk.c kern/err.c kern/misc.c	\
> +	disk/host.c disk/loopback.c commands/hexdump.c io/gzio.c	\
> +	commands/blocklist.c fs/fat.c fs/ext2.c kern/parser.c		\
> +	kern/partition.c partmap/pc.c partmap/apple.c partmap/gpt.c 	\
> +	fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c fs/ntfs.c kern/fs.c	\
> +	kern/env.c fs/fshelp.c fs/xfs.c fs/affs.c fs/sfs.c fs/hfsplus.c	\
> +	fs/ntfscomp.c fs/iso9660.c fs/cpio.c disk/lvm.c disk/raid.c	\
> +	grub_fstest_init.c
> +
>  # Scripts.
>  sbin_SCRIPTS = grub-install
>  bin_SCRIPTS = grub-mkrescue

Can we move this to common.rmk ?  AFAICT, there's nothing i386-pc-specific about
this.

As for the list of filesystems, please reuse the filesystem chunk used on other
commands;  this will improve readability, ensure there are no missing components
(as it has happened before), and overall improve maintainability:

	\
	fs/affs.c fs/cpio.c fs/ext2.c fs/fat.c fs/hfs.c         \
	fs/hfsplus.c fs/iso9660.c fs/jfs.c fs/minix.c           \
	fs/ntfs.c fs/ntfscomp.c fs/reiserfs.c fs/sfs.c          \
	fs/ufs.c fs/xfs.c                                       \
	\

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)