Re: Kexec command line length

From: Bernhard Walle <bwalle@suse.de>
To: kexec@lists.infradead.org
Subject: Re: Kexec command line length
Date: Mon, 28 Jan 2008 22:29:10 +0100	[thread overview]
Message-ID: <20080128212910.GA21889@suse.de> (raw)
In-Reply-To: <20080128205324.GC1174@hmsreliant.think-freely.org>

* Neil Horman <nhorman@tuxdriver.com> [2008-01-28 21:53]:
>  		return -1;
>  	}
>  
> +	if (setup_header.protocol_version >= 0x0206) {
> +		if (command_line_len > setup_header.cmdline_size) {
> +			dbgprintf("Kernel command line too long for kernel!\n");
> +			return -1;
> +		}
> +	}
> +
>  	if (setup_header.protocol_version >= 0x0205) {
>  		relocatable_kernel = setup_header.relocatable_kernel;
>  		dbgprintf("bzImage is relocatable\n");

I know that there was a kernel release with 2048 _and_ still the old
boot protocol, but wouldn't it be better to warn the user if the size
is beyond 256 and the old kernel is used? I think new kexec-tools
should still support old kernels without problems ...

        Bernhard

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec