From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [patch] do not use cmd_reset uninitialized in cfi_flash.c
Date: Tue, 29 Jan 2008 07:15:59 +0100 [thread overview]
Message-ID: <200801290716.00231.sr@denx.de> (raw)
In-Reply-To: <200801282227.06426.vapier@gentoo.org>
On Tuesday 29 January 2008, Mike Frysinger wrote:
> The cmd_reset member of the flash info struct is not initialized until the
> specific cmdset function is called. This normally happens by:
> flash_get_size -> flash_detect_cfi -> cmdset_*_init
> That means we cannot use cmd_reset inside of the cfi detection functions.
Right. But your version now uses the Intel reset command (0xff)
unconditionally. AMD/Spansion style flash chips need AMD_CMD_RESET (0xf0)
instead. Any idea how we should handle this?
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2008-01-29 6:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 3:27 [U-Boot-Users] [patch] do not use cmd_reset uninitialized in cfi_flash.c Mike Frysinger
2008-01-29 6:15 ` Stefan Roese [this message]
2008-01-29 13:05 ` Mike Frysinger
2008-01-29 13:13 ` Stefan Roese
2008-02-03 15:56 ` Michael Schwingen
2008-02-04 10:13 ` Stefan Roese
2008-02-04 15:48 ` Michael Schwingen
2008-02-04 16:05 ` Stefan Roese
2008-02-05 9:45 ` Michael Schwingen
2008-02-05 9:52 ` Stefan Roese
2008-02-18 22:16 ` Michael Schwingen
2008-02-20 9:18 ` Stefan Roese
2008-02-20 9:50 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801290716.00231.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.