All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [patch] do not use cmd_reset uninitialized in cfi_flash.c
Date: Mon, 4 Feb 2008 17:05:10 +0100	[thread overview]
Message-ID: <200802041705.10934.sr@denx.de> (raw)
In-Reply-To: <47A733C9.3030207@discworld.dascon.de>

On Monday 04 February 2008, Michael Schwingen wrote:
> Stefan Roese wrote:
> >> However, I wonder if it would be possible to simply issue *both* reset
> >> commands - if the flash safely ignores the second (unknown) command,
> >> this should be fine, but it is relying on undocumented behaviour.
> >
> > Good idea. Do you (or somebody else) have HW available to test such a
> > change?
>
> I think I can run tests on a small set (~5-10 different AMD-commandset
> and 2 intel-commandset, all 16 bit) flashs, but that still leaves the
> (small) possibility that there are flash roms that behave different.

Right. But it will be an improvement to the current implementation, where a 
random command is written as RESET command. And also an improvement to the 
fixed AMD/Intel RESET command. So I vote for trying this solution. I'll test 
on a few of mine platforms too.

Michael, could please you provide a patch?

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2008-02-04 16:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-29  3:27 [U-Boot-Users] [patch] do not use cmd_reset uninitialized in cfi_flash.c Mike Frysinger
2008-01-29  6:15 ` Stefan Roese
2008-01-29 13:05   ` Mike Frysinger
2008-01-29 13:13     ` Stefan Roese
2008-02-03 15:56       ` Michael Schwingen
2008-02-04 10:13         ` Stefan Roese
2008-02-04 15:48           ` Michael Schwingen
2008-02-04 16:05             ` Stefan Roese [this message]
2008-02-05  9:45               ` Michael Schwingen
2008-02-05  9:52                 ` Stefan Roese
2008-02-18 22:16               ` Michael Schwingen
2008-02-20  9:18                 ` Stefan Roese
2008-02-20  9:50                   ` Haavard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802041705.10934.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.