* [PATCH] minios: Fix bug when blkfront reading into zero-mapped buffer
@ 2008-01-29 14:12 Samuel Thibault
0 siblings, 0 replies; only message in thread
From: Samuel Thibault @ 2008-01-29 14:12 UTC (permalink / raw)
To: xen-devel
minios: Fix bug when blkfront reading into zero-mapped buffer
by just poking the page.
No need to use virtual_to_mfn() for the ring since that is a real page.
Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
diff -r 807502236560 extras/mini-os/blkfront.c
--- a/extras/mini-os/blkfront.c Tue Jan 29 14:07:26 2008 +0000
+++ b/extras/mini-os/blkfront.c Tue Jan 29 14:07:32 2008 +0000
@@ -102,7 +102,7 @@ struct blkfront_dev *init_blkfront(char
SHARED_RING_INIT(s);
FRONT_RING_INIT(&dev->ring, s, PAGE_SIZE);
- dev->ring_ref = gnttab_grant_access(0,virtual_to_mfn(s),0);
+ dev->ring_ref = gnttab_grant_access(0,virt_to_mfn(s),0);
evtchn_alloc_unbound_t op;
op.dom = DOMID_SELF;
@@ -288,6 +288,11 @@ void blkfront_aio(struct blkfront_aiocb
for (j = 0; j < n; j++) {
uintptr_t data = start + j * PAGE_SIZE;
+ if (!write) {
+ /* Trigger CoW if needed */
+ *(char*)data = 0;
+ barrier();
+ }
aiocbp->gref[j] = req->seg[j].gref =
gnttab_grant_access(0, virtual_to_mfn(data), write);
req->seg[j].first_sect = 0;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-01-29 14:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-29 14:12 [PATCH] minios: Fix bug when blkfront reading into zero-mapped buffer Samuel Thibault
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.