From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: Nate Case <ncase@xes-inc.com>
Cc: Jeff Garzik <jeff@garzik.org>,
Andy Fleming <afleming@freescale.com>,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] PHYLIB: Locking fixes for PHY I/O potentially sleeping
Date: Tue, 29 Jan 2008 21:12:00 +0100 [thread overview]
Message-ID: <20080129211200.4fa73063@siona> (raw)
In-Reply-To: <1201622709.12444.118.camel@localhost.localdomain>
On Tue, 29 Jan 2008 10:05:09 -0600
Nate Case <ncase@xes-inc.com> wrote:
> +/* PHY timer which schedules the state machine work */
> +static void phy_timer(unsigned long data)
> +{
> + struct phy_device *phydev = (struct phy_device *)data;
> +
> + /*
> + * PHY I/O operations can potentially sleep so we ensure that
> + * it's done from a process context
> + */
> + schedule_work(&phydev->state_queue);
> +}
If you use schedule_delayed_work() instead, you can get rid of the
timer.
Haavard
next prev parent reply other threads:[~2008-01-29 20:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 23:36 [PATCH] PHYLIB: Locking fixes for PHY I/O potentially sleeping Nate Case
2008-01-17 21:04 ` Benjamin Herrenschmidt
2008-01-21 20:05 ` Andy Fleming
2008-01-22 18:49 ` David Hollis
2008-01-29 0:29 ` Andy Fleming
2008-01-29 0:32 ` David Miller
2008-01-29 0:43 ` Jeff Garzik
2008-01-29 16:05 ` Nate Case
2008-01-29 20:12 ` Haavard Skinnemoen [this message]
2008-01-30 8:48 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080129211200.4fa73063@siona \
--to=hskinnemoen@atmel.com \
--cc=afleming@freescale.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=ncase@xes-inc.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.