From: Jeff Garzik <jeff@garzik.org>
To: Andy Fleming <afleming@freescale.com>
Cc: Nate Case <ncase@xes-inc.com>,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] PHYLIB: Locking fixes for PHY I/O potentially sleeping
Date: Mon, 28 Jan 2008 19:43:14 -0500 [thread overview]
Message-ID: <479E76A2.8020304@garzik.org> (raw)
In-Reply-To: <6D762C47-9C9C-422E-A80E-CC418F624B05@freescale.com>
Andy Fleming wrote:
> Jeff, Dave, any chance we can get this one in for 2.6.25? It will allow
> a number of other drivers to start using PHY Lib.
> I'm sure Nate can resend if needed.
>
> On Jan 3, 2008, at 17:36, Nate Case wrote:
>
>> PHY read/write functions can potentially sleep (e.g., a PHY accessed
>> via I2C). The following changes were made to account for this:
>>
>> * Change spin locks to mutex locks
>> * Add a BUG_ON() to phy_read() phy_write() to warn against
>> calling them from an interrupt context.
>> * Use work queue for PHY state machine handling since
>> it can potentially sleep
>> * Change phydev lock from spinlock to mutex
>>
>> Signed-off-by: Nate Case <ncase@xes-inc.com>
don't see it in my queue, so please resend.
next prev parent reply other threads:[~2008-01-29 0:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 23:36 [PATCH] PHYLIB: Locking fixes for PHY I/O potentially sleeping Nate Case
2008-01-17 21:04 ` Benjamin Herrenschmidt
2008-01-21 20:05 ` Andy Fleming
2008-01-22 18:49 ` David Hollis
2008-01-29 0:29 ` Andy Fleming
2008-01-29 0:32 ` David Miller
2008-01-29 0:43 ` Jeff Garzik [this message]
2008-01-29 16:05 ` Nate Case
2008-01-29 20:12 ` Haavard Skinnemoen
2008-01-30 8:48 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479E76A2.8020304@garzik.org \
--to=jeff@garzik.org \
--cc=afleming@freescale.com \
--cc=davem@davemloft.net \
--cc=ncase@xes-inc.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.