All of lore.kernel.org
 help / color / mirror / Atom feed
From: Erik Mouw <mouw@nl.linux.org>
To: jamal <hadi@cyberus.ca>
Cc: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
	netdev@vger.kernel.org
Subject: Re: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24
Date: Tue, 29 Jan 2008 22:45:56 +0100	[thread overview]
Message-ID: <20080129214555.GC29300@gateway.home> (raw)
In-Reply-To: <1201640243.4431.29.camel@localhost>

[-- Attachment #1: Type: text/plain, Size: 2481 bytes --]

On Tue, Jan 29, 2008 at 03:57:23PM -0500, jamal wrote:
> On Tue, 2008-29-01 at 11:57 -0800, Waskiewicz Jr, Peter P wrote:
> > > I've just started to use 2.6.24 on my home firewall (before 
> > > it was running 2.6.24-rc2 for about 65 days) and I noticed a 
> > > couple of error messages I've never seen before:
> > > 
> > > Jan 29 07:50:54 gateway kernel: BUG eth1 code -5 qlen 0 Jan 
> > > 29 08:28:30 gateway kernel: BUG eth1 code -5 qlen 0 Jan 29 
> > > 08:57:30 gateway kernel: BUG eth1 code -5 qlen 0 Jan 29 
> > > 09:44:04 gateway kernel: BUG eth1 code -5 qlen 0 Jan 29 
> > > 10:01:35 gateway kernel: BUG eth1 code -5 qlen 0 Jan 29 
> > > 10:01:35 gateway last message repeated 2 times Jan 29 
> > > 10:16:48 gateway kernel: BUG eth1 code -5 qlen 0 Jan 29 
> > > 10:16:48 gateway last message repeated 2 times Jan 29 
> > > 10:45:48 gateway kernel: BUG eth1 code -5 qlen 0 Jan 29 
> > > 10:45:48 gateway last message repeated 2 times Jan 29 
> > > 11:10:01 gateway kernel: BUG eth1 code -5 qlen 0 Jan 29 
> > > 11:10:02 gateway last message repeated 9 times
> > > 
> > > The message seems to be coming from the qdisc_restart() in 
> > > net/sched/sch_generic.c which was changed with commit 
> > > 5f1a485d5905aa641f33009019b3699076666a4c .
> > > 
> > > The NIC is an IBM EtherJet cardbus card using the xircom_cb driver:
> > 
> > Are you using any specific qdisc, or just the default pfifo_fast?  Have
> > you done any specific tuning on your qdisc as well?  The default qlen
> > seems to have been changed.
> 
> The driver seems buggy. Make it return NETDEV_TX_BUSY instead of -EIO
> in xircom_start_xmit() and the messages will go away.

Like this?

diff --git a/drivers/net/tulip/xircom_cb.c b/drivers/net/tulip/xircom_cb.c
index 8fc7274..6b93d01 100644
--- a/drivers/net/tulip/xircom_cb.c
+++ b/drivers/net/tulip/xircom_cb.c
@@ -441,7 +441,7 @@ static int xircom_start_xmit(struct sk_buff *skb, struct net_device *dev)
 	spin_unlock_irqrestore(&card->lock,flags);
 	trigger_transmit(card);
 
-	return -EIO;
+	return NETDEV_TX_BUSY;
 }
 
 

It compiles without errors. I'm sorry I can't test it right now, I'm
100 km away from the machine and the same driver is used for both NICs
so if I goof up I won't be able to fix the it. I'll test it this friday
and let you know.


Erik

-- 
They're all fools. Don't worry. Darwin may be slow, but he'll
eventually get them. -- Matthew Lammers in alt.sysadmin.recovery

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2008-01-29 21:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-29 18:47 Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24 Erik Mouw
2008-01-29 19:57 ` Waskiewicz Jr, Peter P
2008-01-29 20:57   ` jamal
2008-01-29 21:45     ` Erik Mouw [this message]
2008-01-29 23:08       ` jamal
2008-01-29 23:12         ` Waskiewicz Jr, Peter P
2008-02-01 14:54         ` Erik Mouw
2008-02-01 19:07           ` Waskiewicz Jr, Peter P
2008-01-29 21:48     ` Waskiewicz Jr, Peter P
2008-01-29 21:00   ` Erik Mouw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080129214555.GC29300@gateway.home \
    --to=mouw@nl.linux.org \
    --cc=hadi@cyberus.ca \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.