From: Erik Mouw <mouw@nl.linux.org>
To: jamal <hadi@cyberus.ca>
Cc: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
netdev@vger.kernel.org
Subject: Re: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24
Date: Fri, 1 Feb 2008 15:54:47 +0100 [thread overview]
Message-ID: <20080201145446.GA3661@gateway.home> (raw)
In-Reply-To: <1201648108.4425.15.camel@localhost>
[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]
On Tue, Jan 29, 2008 at 06:08:28PM -0500, jamal wrote:
> On Tue, 2008-29-01 at 22:45 +0100, Erik Mouw wrote:
>
> > > The driver seems buggy. Make it return NETDEV_TX_BUSY instead of -EIO
> > > in xircom_start_xmit() and the messages will go away.
> >
> > Like this?
> >
>
> Indeed.
I've changed the -EIO into NETDEV_TX_BUSY and so far I can't trigger
the bug anymore. It was quite easy to trigger within minutes with
rsync, but I can't trigger it anymore. Should I send a patch, and if
so: to who? The tulip/xircom_cb driver seems to be orphaned.
> Peter, I suspect that driver is just buggy in some other way as opposed
> to being re-entered; couldnt tell by inspection. It is possible it may
> be too eager to open up before it really has space.
> It will be easy to check your theory by having the driver just check if
> it is netif_stopped just before it returns NETDEV_TX_BUSY.
No need to test that, it *is* netif_stopped before the return:
/* Uh oh... no free descriptor... drop the packet */
netif_stop_queue(dev);
spin_unlock_irqrestore(&card->lock,flags);
trigger_transmit(card);
return NETDEV_TX_BUSY;
trigger_transmit() is a simple function that just writes a single
register on the card to trigger a transmit.
Erik
--
They're all fools. Don't worry. Darwin may be slow, but he'll
eventually get them. -- Matthew Lammers in alt.sysadmin.recovery
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-02-01 14:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 18:47 Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24 Erik Mouw
2008-01-29 19:57 ` Waskiewicz Jr, Peter P
2008-01-29 20:57 ` jamal
2008-01-29 21:45 ` Erik Mouw
2008-01-29 23:08 ` jamal
2008-01-29 23:12 ` Waskiewicz Jr, Peter P
2008-02-01 14:54 ` Erik Mouw [this message]
2008-02-01 19:07 ` Waskiewicz Jr, Peter P
2008-01-29 21:48 ` Waskiewicz Jr, Peter P
2008-01-29 21:00 ` Erik Mouw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080201145446.GA3661@gateway.home \
--to=mouw@nl.linux.org \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.