* [PATCH] Remove __INIT_REFOK and __INITDATA_REFOK
@ 2008-01-30 14:14 Ralf Baechle
2008-02-02 18:01 ` Sam Ravnborg
0 siblings, 1 reply; 3+ messages in thread
From: Ralf Baechle @ 2008-01-30 14:14 UTC (permalink / raw)
To: Sam Ravnborg, Andrew Morton; +Cc: linux-kernel, linux-mips
Commit 312b1485fb509c9bc32eda28ad29537896658cb8 made __INIT_REFOK expand
into .section .section ".ref.text", "ax". Since the assembler doesn't
tolerate stuttering in the source that broke all MIPS builds.
Since with this change Sam downgraded __INIT_REFOK to just a backward
compat thing and there being only a single use in the MIPS arch code the
best solution is to delete both of __INIT_REFOK and __INITDATA_REFOK (which
was equally broken) being unused anyway these can be deleted.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
---
I'll send out the MIPS bits as part of my next pull request to Linus.
diff --git a/include/linux/init.h b/include/linux/init.h
index 2efbda0..90cdbbb 100644
--- a/include/linux/init.h
+++ b/include/linux/init.h
@@ -124,9 +124,6 @@
#define __REF .section ".ref.text", "ax"
#define __REFDATA .section ".ref.data", "aw"
#define __REFCONST .section ".ref.rodata", "aw"
-/* backward compatibility */
-#define __INIT_REFOK .section __REF
-#define __INITDATA_REFOK .section __REFDATA
#ifndef __ASSEMBLY__
/*
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove __INIT_REFOK and __INITDATA_REFOK
2008-01-30 14:14 [PATCH] Remove __INIT_REFOK and __INITDATA_REFOK Ralf Baechle
@ 2008-02-02 18:01 ` Sam Ravnborg
0 siblings, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2008-02-02 18:01 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Andrew Morton, linux-kernel, linux-mips
On Wed, Jan 30, 2008 at 02:14:08PM +0000, Ralf Baechle wrote:
> Commit 312b1485fb509c9bc32eda28ad29537896658cb8 made __INIT_REFOK expand
> into .section .section ".ref.text", "ax". Since the assembler doesn't
> tolerate stuttering in the source that broke all MIPS builds.
>
> Since with this change Sam downgraded __INIT_REFOK to just a backward
> compat thing and there being only a single use in the MIPS arch code the
> best solution is to delete both of __INIT_REFOK and __INITDATA_REFOK (which
> was equally broken) being unused anyway these can be deleted.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Thanks Ralf - applied.
And sorry for the MIPS breakage.
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Remove __INIT_REFOK and __INITDATA_REFOK
2008-02-02 20:35 [REVIEW for merge] kbuild updates including silence of section mismatch check Sam Ravnborg
@ 2008-02-02 20:46 ` Sam Ravnborg
0 siblings, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2008-02-02 20:46 UTC (permalink / raw)
To: kbuild; +Cc: Ralf Baechle
From: Ralf Baechle <ralf@linux-mips.org>
Commit 312b1485fb509c9bc32eda28ad29537896658cb8 made __INIT_REFOK expand
into .section .section ".ref.text", "ax". Since the assembler doesn't
tolerate stuttering in the source that broke all MIPS builds.
Since with this change Sam downgraded __INIT_REFOK to just a backward
compat thing and there being only a single use in the MIPS arch code the
best solution is to delete both of __INIT_REFOK and __INITDATA_REFOK (which
was equally broken) being unused anyway these can be deleted.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
include/linux/init.h | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/include/linux/init.h b/include/linux/init.h
index 2efbda0..90cdbbb 100644
--- a/include/linux/init.h
+++ b/include/linux/init.h
@@ -124,9 +124,6 @@
#define __REF .section ".ref.text", "ax"
#define __REFDATA .section ".ref.data", "aw"
#define __REFCONST .section ".ref.rodata", "aw"
-/* backward compatibility */
-#define __INIT_REFOK .section __REF
-#define __INITDATA_REFOK .section __REFDATA
#ifndef __ASSEMBLY__
/*
--
1.5.4.rc3.14.g44397
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-02 20:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-30 14:14 [PATCH] Remove __INIT_REFOK and __INITDATA_REFOK Ralf Baechle
2008-02-02 18:01 ` Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2008-02-02 20:35 [REVIEW for merge] kbuild updates including silence of section mismatch check Sam Ravnborg
2008-02-02 20:46 ` [PATCH] Remove __INIT_REFOK and __INITDATA_REFOK Sam Ravnborg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.