From: Robin Holt <holt@sgi.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andrea Arcangeli <andrea@qumranet.com>, Robin Holt <holt@sgi.com>,
Avi Kivity <avi@qumranet.com>, Izik Eidus <izike@qumranet.com>,
Nick Piggin <npiggin@suse.de>,
kvm-devel@lists.sourceforge.net,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
steiner@sgi.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, daniel.blueman@quadrics.com,
Hugh Dickins <hugh@veritas.com>
Subject: Re: [patch 3/6] mmu_notifier: invalidate_page callbacks for subsystems with rmap
Date: Wed, 30 Jan 2008 12:03:12 -0600 [thread overview]
Message-ID: <20080130180312.GV26420@sgi.com> (raw)
In-Reply-To: <20080130022944.699753910@sgi.com>
This is the second part of a patch posted to patch 1/6.
Index: git-linus/mm/rmap.c
===================================================================
--- git-linus.orig/mm/rmap.c 2008-01-30 11:55:56.000000000 -0600
+++ git-linus/mm/rmap.c 2008-01-30 12:01:28.000000000 -0600
@@ -476,8 +476,10 @@ int page_mkclean(struct page *page)
struct address_space *mapping = page_mapping(page);
if (mapping) {
ret = page_mkclean_file(mapping, page);
- if (unlikely(PageExternalRmap(page)))
+ if (unlikely(PageExternalRmap(page))) {
mmu_rmap_notifier(invalidate_page, page);
+ ClearPageExported(page);
+ }
if (page_test_dirty(page)) {
page_clear_dirty(page);
ret = 1;
@@ -980,8 +982,10 @@ int try_to_unmap(struct page *page, int
else
ret = try_to_unmap_file(page, migration);
- if (unlikely(PageExternalRmap(page)))
+ if (unlikely(PageExternalRmap(page))) {
mmu_rmap_notifier(invalidate_page, page);
+ ClearPageExported(page);
+ }
if (!page_mapped(page))
ret = SWAP_SUCCESS;
WARNING: multiple messages have this Message-ID (diff)
From: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>
To: Christoph Lameter <clameter-sJ/iWh9BUns@public.gmane.org>
Cc: Nick Piggin <npiggin-l3A5Bk7waGM@public.gmane.org>,
Andrea Arcangeli <andrea-atKUWr5tajBWk0Htik3J/w@public.gmane.org>,
Peter Zijlstra
<a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org>,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
steiner-sJ/iWh9BUns@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>,
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
daniel.blueman-xqY44rlHlBpWk0Htik3J/w@public.gmane.org,
Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>,
Hugh Dickins <hugh-DTz5qymZ9yRBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [patch 3/6] mmu_notifier: invalidate_page callbacks for subsystems with rmap
Date: Wed, 30 Jan 2008 12:03:12 -0600 [thread overview]
Message-ID: <20080130180312.GV26420@sgi.com> (raw)
In-Reply-To: <20080130022944.699753910-sJ/iWh9BUns@public.gmane.org>
This is the second part of a patch posted to patch 1/6.
Index: git-linus/mm/rmap.c
===================================================================
--- git-linus.orig/mm/rmap.c 2008-01-30 11:55:56.000000000 -0600
+++ git-linus/mm/rmap.c 2008-01-30 12:01:28.000000000 -0600
@@ -476,8 +476,10 @@ int page_mkclean(struct page *page)
struct address_space *mapping = page_mapping(page);
if (mapping) {
ret = page_mkclean_file(mapping, page);
- if (unlikely(PageExternalRmap(page)))
+ if (unlikely(PageExternalRmap(page))) {
mmu_rmap_notifier(invalidate_page, page);
+ ClearPageExported(page);
+ }
if (page_test_dirty(page)) {
page_clear_dirty(page);
ret = 1;
@@ -980,8 +982,10 @@ int try_to_unmap(struct page *page, int
else
ret = try_to_unmap_file(page, migration);
- if (unlikely(PageExternalRmap(page)))
+ if (unlikely(PageExternalRmap(page))) {
mmu_rmap_notifier(invalidate_page, page);
+ ClearPageExported(page);
+ }
if (!page_mapped(page))
ret = SWAP_SUCCESS;
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
WARNING: multiple messages have this Message-ID (diff)
From: Robin Holt <holt@sgi.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andrea Arcangeli <andrea@qumranet.com>, Robin Holt <holt@sgi.com>,
Avi Kivity <avi@qumranet.com>, Izik Eidus <izike@qumranet.com>,
Nick Piggin <npiggin@suse.de>,
kvm-devel@lists.sourceforge.net,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
steiner@sgi.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, daniel.blueman@quadrics.com,
Hugh Dickins <hugh@veritas.com>
Subject: Re: [patch 3/6] mmu_notifier: invalidate_page callbacks for subsystems with rmap
Date: Wed, 30 Jan 2008 12:03:12 -0600 [thread overview]
Message-ID: <20080130180312.GV26420@sgi.com> (raw)
In-Reply-To: <20080130022944.699753910@sgi.com>
This is the second part of a patch posted to patch 1/6.
Index: git-linus/mm/rmap.c
===================================================================
--- git-linus.orig/mm/rmap.c 2008-01-30 11:55:56.000000000 -0600
+++ git-linus/mm/rmap.c 2008-01-30 12:01:28.000000000 -0600
@@ -476,8 +476,10 @@ int page_mkclean(struct page *page)
struct address_space *mapping = page_mapping(page);
if (mapping) {
ret = page_mkclean_file(mapping, page);
- if (unlikely(PageExternalRmap(page)))
+ if (unlikely(PageExternalRmap(page))) {
mmu_rmap_notifier(invalidate_page, page);
+ ClearPageExported(page);
+ }
if (page_test_dirty(page)) {
page_clear_dirty(page);
ret = 1;
@@ -980,8 +982,10 @@ int try_to_unmap(struct page *page, int
else
ret = try_to_unmap_file(page, migration);
- if (unlikely(PageExternalRmap(page)))
+ if (unlikely(PageExternalRmap(page))) {
mmu_rmap_notifier(invalidate_page, page);
+ ClearPageExported(page);
+ }
if (!page_mapped(page))
ret = SWAP_SUCCESS;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-01-30 18:03 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 2:29 [patch 0/6] [RFC] MMU Notifiers V3 Christoph Lameter
2008-01-30 2:29 ` Christoph Lameter
2008-01-30 2:29 ` [patch 1/6] mmu_notifier: Core code Christoph Lameter
2008-01-30 2:29 ` Christoph Lameter
2008-01-30 15:37 ` Andrea Arcangeli
2008-01-30 15:37 ` Andrea Arcangeli
2008-01-30 15:37 ` Andrea Arcangeli
2008-01-30 15:53 ` Jack Steiner
2008-01-30 15:53 ` Jack Steiner
2008-01-30 15:53 ` Jack Steiner
2008-01-30 16:38 ` Andrea Arcangeli
2008-01-30 16:38 ` Andrea Arcangeli
2008-01-30 16:38 ` Andrea Arcangeli
2008-01-30 19:19 ` Christoph Lameter
2008-01-30 19:19 ` Christoph Lameter
2008-01-30 19:19 ` Christoph Lameter
2008-01-30 22:20 ` Robin Holt
2008-01-30 22:20 ` Robin Holt
2008-01-30 22:20 ` Robin Holt
2008-01-30 23:38 ` Andrea Arcangeli
2008-01-30 23:38 ` Andrea Arcangeli
2008-01-30 23:38 ` Andrea Arcangeli
2008-01-30 23:55 ` Christoph Lameter
2008-01-30 23:55 ` Christoph Lameter
2008-01-31 0:12 ` [kvm-devel] " Andrea Arcangeli
2008-01-31 0:12 ` Andrea Arcangeli
2008-01-31 0:12 ` Andrea Arcangeli
2008-01-31 1:27 ` [kvm-devel] " Christoph Lameter
2008-01-31 1:27 ` Christoph Lameter
2008-01-31 1:27 ` Christoph Lameter
2008-01-30 17:10 ` Peter Zijlstra
2008-01-30 17:10 ` Peter Zijlstra
2008-01-30 19:28 ` Christoph Lameter
2008-01-30 19:28 ` Christoph Lameter
2008-01-30 19:28 ` Christoph Lameter
2008-01-30 18:02 ` Robin Holt
2008-01-30 18:02 ` Robin Holt
2008-01-30 18:02 ` Robin Holt
2008-01-30 19:08 ` Christoph Lameter
2008-01-30 19:08 ` Christoph Lameter
2008-01-30 19:08 ` Christoph Lameter
2008-01-30 19:14 ` Christoph Lameter
2008-01-30 19:14 ` Christoph Lameter
2008-01-30 19:14 ` Christoph Lameter
2008-01-30 2:29 ` [patch 2/6] mmu_notifier: Callbacks to invalidate address ranges Christoph Lameter
2008-01-30 2:29 ` Christoph Lameter
2008-01-30 2:29 ` [patch 3/6] mmu_notifier: invalidate_page callbacks for subsystems with rmap Christoph Lameter
2008-01-30 2:29 ` Christoph Lameter
2008-01-30 18:03 ` Robin Holt [this message]
2008-01-30 18:03 ` Robin Holt
2008-01-30 18:03 ` Robin Holt
2008-01-30 2:29 ` [patch 4/6] MMU notifier: invalidate_page callbacks using Linux rmaps Christoph Lameter
2008-01-30 2:29 ` Christoph Lameter
2008-01-30 2:29 ` [patch 5/6] mmu_notifier: Callbacks for xip_filemap.c Christoph Lameter
2008-01-30 2:29 ` Christoph Lameter
2008-01-30 2:29 ` [patch 6/6] mmu_notifier: Add invalidate_all() Christoph Lameter
2008-01-30 2:29 ` Christoph Lameter
-- strict thread matches above, loose matches on Subject: below --
2008-01-28 20:28 [patch 0/6] [RFC] MMU Notifiers V2 Christoph Lameter
2008-01-28 20:28 ` [patch 3/6] mmu_notifier: invalidate_page callbacks for subsystems with rmap Christoph Lameter
2008-01-28 20:28 ` Christoph Lameter
2008-01-29 16:28 ` Robin Holt
2008-01-29 16:28 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080130180312.GV26420@sgi.com \
--to=holt@sgi.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andrea@qumranet.com \
--cc=avi@qumranet.com \
--cc=benh@kernel.crashing.org \
--cc=clameter@sgi.com \
--cc=daniel.blueman@quadrics.com \
--cc=hugh@veritas.com \
--cc=izike@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.