From: Adrian Bunk <bunk@stusta.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Nick Piggin <npiggin@suse.de>,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
linux390@de.ibm.com
Subject: x86 arch updates also broke s390
Date: Thu, 31 Jan 2008 02:33:10 +0200 [thread overview]
Message-ID: <20080131003310.GW29368@does.not.exist> (raw)
In-Reply-To: <20080130011550.GA31853@elte.hu>
<-- snip -->
...
CC arch/s390/kernel/asm-offsets.s
In file included from
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/s390/kernel/asm-offsets.c:7:
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/sched.h: In function 'spin_needbreak':
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/sched.h:1931: error: implicit declaration of function '__raw_spin_is_contended'
make[2]: *** [arch/s390/kernel/asm-offsets.s] Error 1
<-- snip -->
Guilty commit:
Commit: 95c354fe9f7d6decc08a92aa26eb233ecc2155bf
Author: Nick Piggin <npiggin@suse.de> Wed, 30 Jan 2008 13:31:20 +0100
spinlock: lockbreak cleanup
The break_lock data structure and code for spinlocks is quite nasty.
Not only does it double the size of a spinlock but it changes locking to
a potentially less optimal trylock.
Put all of that under CONFIG_GENERIC_LOCKBREAK, and introduce a
__raw_spin_is_contended that uses the lock data itself to determine whether
there are waiters on the lock, to be used if CONFIG_GENERIC_LOCKBREAK is
not set.
Rename need_lockbreak to spin_needbreak, make it use spin_is_contended to
decouple it from the spinlock implementation, and make it typesafe (rwlocks
do not have any need_lockbreak sites -- why do they even get bloated up
with that break_lock then?).
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-01-31 0:32 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 1:15 [git pull] x86 arch updates for v2.6.25 Ingo Molnar
2008-01-31 0:33 ` Adrian Bunk [this message]
2008-01-31 9:34 ` x86 arch updates also broke s390 Martin Schwidefsky
2008-01-31 10:24 ` Ingo Molnar
2008-01-31 12:37 ` Nick Piggin
2008-02-01 9:48 ` Ingo Molnar
2008-02-01 9:52 ` Ingo Molnar
2008-02-01 9:54 ` Martin Schwidefsky
2008-02-01 10:02 ` Ingo Molnar
2008-01-31 15:57 ` [git pull] x86 arch updates for v2.6.25 Adrian Bunk
2008-01-31 16:00 ` Ingo Molnar
2008-01-31 16:04 ` Ingo Molnar
2008-01-31 16:12 ` Adrian Bunk
2008-01-31 16:15 ` Ingo Molnar
2008-01-31 16:21 ` WANG Cong
2008-01-31 16:24 ` Adrian Bunk
2008-01-31 16:46 ` Ingo Molnar
2008-01-31 16:52 ` Jeremy Fitzhardinge
2008-01-31 16:29 ` sparc compile error caused by x86 arch updates Adrian Bunk
2008-01-31 16:29 ` Adrian Bunk
2008-01-31 16:50 ` Jeremy Fitzhardinge
2008-01-31 16:50 ` Jeremy Fitzhardinge
2008-01-31 17:43 ` Ingo Molnar
2008-01-31 17:43 ` Ingo Molnar
2008-01-31 17:55 ` Jeremy Fitzhardinge
2008-01-31 17:55 ` Jeremy Fitzhardinge
2008-01-31 18:21 ` Adrian Bunk
2008-01-31 18:21 ` Adrian Bunk
2008-01-31 18:38 ` Ingo Molnar
2008-01-31 18:38 ` Ingo Molnar
2008-02-05 2:36 ` [git pull] x86 arch updates for v2.6.25 Maxim Levitsky
2008-02-05 3:27 ` Linus Torvalds
2008-02-05 4:11 ` Phil Oester
2008-02-05 4:54 ` Andrew Morton
2008-02-06 12:08 ` Jan Kiszka
2008-02-07 20:00 ` Daniel Phillips
2008-02-08 4:48 ` Christoph Hellwig
2008-02-08 9:51 ` Jan Kiszka
2008-02-05 17:45 ` John Stoffel
2008-02-05 17:52 ` H. Peter Anvin
2008-02-08 18:24 ` Bernhard Kaindl
2008-02-08 19:38 ` remote DMA via FireWire (was Re: [git pull] x86 arch updates for v2.6.25) Stefan Richter
2008-02-07 19:20 ` [git pull] x86 arch updates for v2.6.25 Daniel Phillips
2008-02-08 17:00 ` Andi Kleen
2008-02-08 17:48 ` Jan Kiszka
2008-02-08 18:57 ` Andi Kleen
2008-02-08 21:28 ` [RFC][PATCH] KGDB: remove kgdb-own fault handling (was: Re: [git pull] x86 arch updates for v2.6.25) Jan Kiszka
2008-02-08 21:58 ` Linus Torvalds
2008-02-08 22:16 ` [RFC][PATCH] KGDB: remove kgdb-own fault handling Jason Wessel
2008-02-09 14:11 ` [git pull] x86 arch updates for v2.6.25 Amit Shah
2008-02-10 12:30 ` Jiri Kosina
2008-02-12 7:16 ` Amit Shah
2008-02-13 8:56 ` Ingo Molnar
2008-02-13 10:19 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131003310.GW29368@does.not.exist \
--to=bunk@stusta.de \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.