From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Adrian Bunk <bunk@kernel.org>,
wli@holomorphy.com,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org
Subject: Re: sparc compile error caused by x86 arch updates
Date: Thu, 31 Jan 2008 17:55:41 +0000 [thread overview]
Message-ID: <47A20B9D.3090700@goop.org> (raw)
In-Reply-To: <20080131174331.GA11881@elte.hu>
Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>
>> But I guess I overlooked the comment...
>>
>> I guess the fix is to scatter linux/pagemap.h into the appropriate
>> places where these macros are used (asm-generic/tlb.h, for a start).
>>
>
> no. The fix is always to undo the damage ASAP, to keep the window of
> breakage minimized.
>
Yes, sorry about that. Uninlining the asm-x86/pgalloc.h functions is
the right thing to do anyway.
J
WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Adrian Bunk <bunk@kernel.org>,
wli@holomorphy.com,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org
Subject: Re: sparc compile error caused by x86 arch updates
Date: Thu, 31 Jan 2008 09:55:41 -0800 [thread overview]
Message-ID: <47A20B9D.3090700@goop.org> (raw)
In-Reply-To: <20080131174331.GA11881@elte.hu>
Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>
>> But I guess I overlooked the comment...
>>
>> I guess the fix is to scatter linux/pagemap.h into the appropriate
>> places where these macros are used (asm-generic/tlb.h, for a start).
>>
>
> no. The fix is always to undo the damage ASAP, to keep the window of
> breakage minimized.
>
Yes, sorry about that. Uninlining the asm-x86/pgalloc.h functions is
the right thing to do anyway.
J
next prev parent reply other threads:[~2008-01-31 17:55 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 1:15 [git pull] x86 arch updates for v2.6.25 Ingo Molnar
2008-01-31 0:33 ` x86 arch updates also broke s390 Adrian Bunk
2008-01-31 9:34 ` Martin Schwidefsky
2008-01-31 10:24 ` Ingo Molnar
2008-01-31 12:37 ` Nick Piggin
2008-02-01 9:48 ` Ingo Molnar
2008-02-01 9:52 ` Ingo Molnar
2008-02-01 9:54 ` Martin Schwidefsky
2008-02-01 10:02 ` Ingo Molnar
2008-01-31 15:57 ` [git pull] x86 arch updates for v2.6.25 Adrian Bunk
2008-01-31 16:00 ` Ingo Molnar
2008-01-31 16:04 ` Ingo Molnar
2008-01-31 16:12 ` Adrian Bunk
2008-01-31 16:15 ` Ingo Molnar
2008-01-31 16:21 ` WANG Cong
2008-01-31 16:24 ` Adrian Bunk
2008-01-31 16:46 ` Ingo Molnar
2008-01-31 16:52 ` Jeremy Fitzhardinge
2008-01-31 16:29 ` sparc compile error caused by x86 arch updates Adrian Bunk
2008-01-31 16:29 ` Adrian Bunk
2008-01-31 16:50 ` Jeremy Fitzhardinge
2008-01-31 16:50 ` Jeremy Fitzhardinge
2008-01-31 17:43 ` Ingo Molnar
2008-01-31 17:43 ` Ingo Molnar
2008-01-31 17:55 ` Jeremy Fitzhardinge [this message]
2008-01-31 17:55 ` Jeremy Fitzhardinge
2008-01-31 18:21 ` Adrian Bunk
2008-01-31 18:21 ` Adrian Bunk
2008-01-31 18:38 ` Ingo Molnar
2008-01-31 18:38 ` Ingo Molnar
2008-02-05 2:36 ` [git pull] x86 arch updates for v2.6.25 Maxim Levitsky
2008-02-05 3:27 ` Linus Torvalds
2008-02-05 4:11 ` Phil Oester
2008-02-05 4:54 ` Andrew Morton
2008-02-06 12:08 ` Jan Kiszka
2008-02-07 20:00 ` Daniel Phillips
2008-02-08 4:48 ` Christoph Hellwig
2008-02-08 9:51 ` Jan Kiszka
2008-02-05 17:45 ` John Stoffel
2008-02-05 17:52 ` H. Peter Anvin
2008-02-08 18:24 ` Bernhard Kaindl
2008-02-08 19:38 ` remote DMA via FireWire (was Re: [git pull] x86 arch updates for v2.6.25) Stefan Richter
2008-02-07 19:20 ` [git pull] x86 arch updates for v2.6.25 Daniel Phillips
2008-02-08 17:00 ` Andi Kleen
2008-02-08 17:48 ` Jan Kiszka
2008-02-08 18:57 ` Andi Kleen
2008-02-08 21:28 ` [RFC][PATCH] KGDB: remove kgdb-own fault handling (was: Re: [git pull] x86 arch updates for v2.6.25) Jan Kiszka
2008-02-08 21:58 ` Linus Torvalds
2008-02-08 22:16 ` [RFC][PATCH] KGDB: remove kgdb-own fault handling Jason Wessel
2008-02-09 14:11 ` [git pull] x86 arch updates for v2.6.25 Amit Shah
2008-02-10 12:30 ` Jiri Kosina
2008-02-12 7:16 ` Amit Shah
2008-02-13 8:56 ` Ingo Molnar
2008-02-13 10:19 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A20B9D.3090700@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.