From: Paul Mundt <lethal@linux-sh.org>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: linux-arch@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Jeremy Fitzhardinge <jeremy@goop.org>,
David Brownell <david-b@pacbell.net>
Subject: Re: asm-generic/tlb.h and check_pgt_cache()
Date: Thu, 31 Jan 2008 21:18:42 +0900 [thread overview]
Message-ID: <20080131121842.GA15834@linux-sh.org> (raw)
In-Reply-To: <20080131125425.7e91b54d@dhcp-252-066.norway.atmel.com>
On Thu, Jan 31, 2008 at 12:54:25PM +0100, Haavard Skinnemoen wrote:
> Another way to fix it would be to include asm/pgalloc.h elsewhere, e.g.
> from asm/tlb.h right before including asm-generic/tlb.h. Or perhaps we
> should move check_pgt_cache() into asm/tlb.h on all architectures and
> include asm/pgalloc.h as needed?
>
> I don't know how many architectures are currently broken -- if it's
> only avr32, I can probably come up with a way to fix it on my own. But
> if there are others, I thought it might be a good idea to coordinate
> things.
>
sh broke also, and simply moving the check_pgt_cache() definition wasn't
really a sane option due to the quicklist dependence, as you noted. Some
folks seem to have just done check_pgt_cache() in asm/tlb.h (ie, FR-V), I
opted to just include pgalloc.h from tlb.h. Though if this gets fixed
another way, that's fine too.
next prev parent reply other threads:[~2008-01-31 12:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 11:54 asm-generic/tlb.h and check_pgt_cache() Haavard Skinnemoen
2008-01-31 12:18 ` Paul Mundt [this message]
2008-01-31 13:03 ` Adrian Bunk
2008-01-31 15:36 ` Adrian Bunk
2008-01-31 16:31 ` Jeremy Fitzhardinge
2008-01-31 16:53 ` Adrian Bunk
2008-01-31 17:39 ` Jeremy Fitzhardinge
2008-02-01 0:09 ` Paul Mundt
2008-02-01 0:31 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131121842.GA15834@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=david-b@pacbell.net \
--cc=hskinnemoen@atmel.com \
--cc=jeremy@goop.org \
--cc=linux-arch@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.