From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 6/6] [TCP]: Reorganize struct tcp_sock to save 16 bytes
Date: Thu, 31 Jan 2008 20:33:40 +0000 [thread overview]
Message-ID: <20080131203340.GG11940@ghostprotocols.net> (raw)
In-Reply-To: <1201804304-28777-7-git-send-email-acme@redhat.com>
Em Thu, Jan 31, 2008 at 06:17:20PM -0200, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Jan 31, 2008 at 08:57:53PM +0100, Eric Dumazet escreveu:
> > Hum... retrans_out should sit close to packets_out (or lost_out/sacked_out
> > ???), please.
> >
> > 'struct tcp_sock' is very large on 64 bits, so I would prefer to make sure
> > most paths dont need to touch all 24 cache lines (or 25 cache lines).
>
> That is perfectly fine, I'll replace my patch with another, that states
> this beyond doubt.
David, I just removed this patch from my net-2.6 tree, if you are ok
with the others, please pull.
- Arnaldo
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Eric Dumazet <dada1@cosmosbay.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, dccp@vger.kernel.org
Subject: Re: [PATCH 6/6] [TCP]: Reorganize struct tcp_sock to save 16 bytes on 64-bit arch
Date: Thu, 31 Jan 2008 18:33:40 -0200 [thread overview]
Message-ID: <20080131203340.GG11940@ghostprotocols.net> (raw)
In-Reply-To: <20080131201720.GE11940@ghostprotocols.net>
Em Thu, Jan 31, 2008 at 06:17:20PM -0200, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Jan 31, 2008 at 08:57:53PM +0100, Eric Dumazet escreveu:
> > Hum... retrans_out should sit close to packets_out (or lost_out/sacked_out
> > ???), please.
> >
> > 'struct tcp_sock' is very large on 64 bits, so I would prefer to make sure
> > most paths dont need to touch all 24 cache lines (or 25 cache lines).
>
> That is perfectly fine, I'll replace my patch with another, that states
> this beyond doubt.
David, I just removed this patch from my net-2.6 tree, if you are ok
with the others, please pull.
- Arnaldo
next prev parent reply other threads:[~2008-01-31 20:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 18:31 [PATCH 6/6] [TCP]: Reorganize struct tcp_sock to save 16 bytes on 64-bit arch Arnaldo Carvalho de Melo
2008-01-31 18:31 ` Arnaldo Carvalho de Melo
2008-01-31 19:57 ` [PATCH 6/6] [TCP]: Reorganize struct tcp_sock to save 16 bytes Eric Dumazet
2008-01-31 19:57 ` [PATCH 6/6] [TCP]: Reorganize struct tcp_sock to save 16 bytes on 64-bit arch Eric Dumazet
2008-01-31 20:17 ` [PATCH 6/6] [TCP]: Reorganize struct tcp_sock to save 16 bytes Arnaldo Carvalho de Melo
2008-01-31 20:17 ` [PATCH 6/6] [TCP]: Reorganize struct tcp_sock to save 16 bytes on 64-bit arch Arnaldo Carvalho de Melo
2008-01-31 20:33 ` Arnaldo Carvalho de Melo [this message]
2008-01-31 20:33 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2008-02-01 2:40 [PATCHES 0/6]: Move hashinfo to sk_prot and struct reorgs David Miller
2008-02-01 2:40 ` David Miller
2008-01-31 18:31 [PATCH 5/6] [INET_TIMEWAIT_SOCK]: Reorganize struct inet_timewait_sock to save some bytes Arnaldo Carvalho de Melo
2008-01-31 18:31 ` Arnaldo Carvalho de Melo
2008-01-31 18:31 [PATCH 4/6] [IPV6]: Reorganize strut ipv6_mc_socklist to save 8 bytes Arnaldo Carvalho de Melo
2008-01-31 18:31 ` Arnaldo Carvalho de Melo
2008-01-31 18:31 [PATCH 3/6] [DCCP]: Reorganize struct dccp_sock " Arnaldo Carvalho de Melo
2008-01-31 18:31 ` Arnaldo Carvalho de Melo
2008-01-31 18:31 [PATCH 2/6] [INET6]: Reorganize struct inet6_dev " Arnaldo Carvalho de Melo
2008-01-31 18:31 ` Arnaldo Carvalho de Melo
2008-01-31 18:31 [PATCH 1/6] [SOCK] proto: Add hashinfo member to struct proto Arnaldo Carvalho de Melo
2008-01-31 18:31 ` Arnaldo Carvalho de Melo
2008-01-31 18:31 [PATCHES 0/6]: Move hashinfo to sk_prot and struct reorgs Arnaldo Carvalho de Melo
2008-01-31 18:31 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131203340.GG11940@ghostprotocols.net \
--to=acme@redhat.com \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.