From: Sam Ravnborg <sam@ravnborg.org>
To: Greg Ungerer <gerg@snapgear.com>
Cc: torvalds@linux-foundation.org, gerg@uclinux.org,
linux-kernel@vger.kernel.org
Subject: Re: [M68KNOMMU]: platform setup for 520x ColdFire parts
Date: Fri, 1 Feb 2008 13:13:31 +0100 [thread overview]
Message-ID: <20080201121331.GA12815@uranus.ravnborg.org> (raw)
In-Reply-To: <47A30604.6070602@snapgear.com>
On Fri, Feb 01, 2008 at 09:44:04PM +1000, Greg Ungerer wrote:
>
> Hi Sam,
>
> Sam Ravnborg wrote:
> >On Fri, Feb 01, 2008 at 05:34:10PM +1000, Greg Ungerer wrote:
> >>Switch to platform style configuration for 520x ColdFire parts.
> >>Initial support is for the UARTs. DMA support moved to common code
> >>for all ColdFire parts.
> >>
> >>+static struct mcf_platform_uart m520x_uart_platform[] = {
> >>+ {
> >>+ .mapbase = MCF_MBAR + MCFUART_BASE1,
> >>+ .irq = MCFINT_VECBASE + MCFINT_UART0,
> >>+ },
> >>+ {
> >>+ .mapbase = MCF_MBAR + MCFUART_BASE2,
> >>+ .irq = MCFINT_VECBASE + MCFINT_UART1,
> >>+ },
> >>+ {
> >>+ .mapbase = MCF_MBAR + MCFUART_BASE3,
> >>+ .irq = MCFINT_VECBASE + MCFINT_UART2,
> >>+ },
> >>+ { },
> >>+};
> >const?
> >Same comments for the rest of the patch and the other similar patches.
> >
> >Note: Use __initdataconst for const data as replacement for __initdata.
>
> I am confused, __initdataconst?
Newly introduced...
We only had __*initdata before and therefore we could not
annotate both non-const and const data in a mix - gcc would barf out.
So we added a new member of the set of annotations:
__initconst used to annotate const data.
[I see - I had a spelling error above - I guess that why I confused you]
Sam
prev parent reply other threads:[~2008-02-01 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 7:34 [M68KNOMMU]: platform setup for 520x ColdFire parts Greg Ungerer
2008-02-01 8:48 ` Sam Ravnborg
2008-02-01 11:44 ` Greg Ungerer
2008-02-01 12:13 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080201121331.GA12815@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.