From: Greg Ungerer <gerg@snapgear.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: torvalds@linux-foundation.org, gerg@uclinux.org,
linux-kernel@vger.kernel.org
Subject: Re: [M68KNOMMU]: platform setup for 520x ColdFire parts
Date: Fri, 01 Feb 2008 21:44:04 +1000 [thread overview]
Message-ID: <47A30604.6070602@snapgear.com> (raw)
In-Reply-To: <20080201084817.GB10969@uranus.ravnborg.org>
Hi Sam,
Sam Ravnborg wrote:
> On Fri, Feb 01, 2008 at 05:34:10PM +1000, Greg Ungerer wrote:
>> Switch to platform style configuration for 520x ColdFire parts.
>> Initial support is for the UARTs. DMA support moved to common code
>> for all ColdFire parts.
>>
>> +static struct mcf_platform_uart m520x_uart_platform[] = {
>> + {
>> + .mapbase = MCF_MBAR + MCFUART_BASE1,
>> + .irq = MCFINT_VECBASE + MCFINT_UART0,
>> + },
>> + {
>> + .mapbase = MCF_MBAR + MCFUART_BASE2,
>> + .irq = MCFINT_VECBASE + MCFINT_UART1,
>> + },
>> + {
>> + .mapbase = MCF_MBAR + MCFUART_BASE3,
>> + .irq = MCFINT_VECBASE + MCFINT_UART2,
>> + },
>> + { },
>> +};
> const?
> Same comments for the rest of the patch and the other similar patches.
>
> Note: Use __initdataconst for const data as replacement for __initdata.
I am confused, __initdataconst?
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Chief Software Dude EMAIL: gerg@snapgear.com
SnapGear -- a Secure Computing Company PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2008-02-01 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 7:34 [M68KNOMMU]: platform setup for 520x ColdFire parts Greg Ungerer
2008-02-01 8:48 ` Sam Ravnborg
2008-02-01 11:44 ` Greg Ungerer [this message]
2008-02-01 12:13 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A30604.6070602@snapgear.com \
--to=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.