From: Nathan Lynch <ntl@pobox.com>
To: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: kvm-ppc-devel
<kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
kvm-devel
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [kvm-ppc-devel] [RFC PATCH] KVM for PowerPC: simpler TLB
Date: Fri, 01 Feb 2008 19:07:55 +0000 [thread overview]
Message-ID: <20080201190754.GZ14201@localdomain> (raw)
In-Reply-To: <1201223312.21851.21.camel@basalt>
Hollis Blanchard wrote:
> --- a/arch/powerpc/kernel/asm-offsets.c
> +++ b/arch/powerpc/kernel/asm-offsets.c
> @@ -22,6 +22,7 @@
> #include <linux/mman.h>
> #include <linux/mm.h>
> #include <linux/suspend.h>
> +#include <linux/kvm_host.h>
> #ifdef CONFIG_PPC64
> #include <linux/time.h>
> #include <linux/hardirq.h>
> @@ -328,5 +329,31 @@ int main(void)
>
> DEFINE(PGD_TABLE_SIZE, PGD_TABLE_SIZE);
>
> +#ifdef CONFIG_KVM
> + DEFINE(TLBE_BYTES, sizeof(struct tlbe));
> +
> + DEFINE(VCPU_HOST_STACK, offsetof(struct kvm_vcpu, arch.host_stack));
> + DEFINE(VCPU_HOST_PID, offsetof(struct kvm_vcpu, arch.host_pid));
> + DEFINE(VCPU_HOST_TLB, offsetof(struct kvm_vcpu, arch.host_tlb));
> + DEFINE(VCPU_SHADOW_TLB, offsetof(struct kvm_vcpu, arch.shadow_tlb));
I found that if CONFIG_KVM=m these definitions don't get picked up
when generating asm-offsets.h, which causes the build to break:
AS arch/powerpc/kvm/booke_interrupts.o
arch/powerpc/kvm/booke_interrupts.S: Assembler messages:
arch/powerpc/kvm/booke_interrupts.S:347: Error: unsupported relocation
against VCPU_HOST_TLB
arch/powerpc/kvm/booke_interrupts.S:348: Error: unsupported relocation
against VCPU_SHADOW_TLB
make[1]: *** [arch/powerpc/kvm/booke_interrupts.o] Error 1
Changing it to ifdef CONFIG_KVM_POWERPC (which is a bool) seems to do
the right thing.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
To: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: kvm-ppc-devel
<kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
kvm-devel
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [kvm-ppc-devel] [RFC PATCH] KVM for PowerPC: simpler TLB handling, better page management
Date: Fri, 1 Feb 2008 13:07:55 -0600 [thread overview]
Message-ID: <20080201190754.GZ14201@localdomain> (raw)
In-Reply-To: <1201223312.21851.21.camel@basalt>
Hollis Blanchard wrote:
> --- a/arch/powerpc/kernel/asm-offsets.c
> +++ b/arch/powerpc/kernel/asm-offsets.c
> @@ -22,6 +22,7 @@
> #include <linux/mman.h>
> #include <linux/mm.h>
> #include <linux/suspend.h>
> +#include <linux/kvm_host.h>
> #ifdef CONFIG_PPC64
> #include <linux/time.h>
> #include <linux/hardirq.h>
> @@ -328,5 +329,31 @@ int main(void)
>
> DEFINE(PGD_TABLE_SIZE, PGD_TABLE_SIZE);
>
> +#ifdef CONFIG_KVM
> + DEFINE(TLBE_BYTES, sizeof(struct tlbe));
> +
> + DEFINE(VCPU_HOST_STACK, offsetof(struct kvm_vcpu, arch.host_stack));
> + DEFINE(VCPU_HOST_PID, offsetof(struct kvm_vcpu, arch.host_pid));
> + DEFINE(VCPU_HOST_TLB, offsetof(struct kvm_vcpu, arch.host_tlb));
> + DEFINE(VCPU_SHADOW_TLB, offsetof(struct kvm_vcpu, arch.shadow_tlb));
I found that if CONFIG_KVM=m these definitions don't get picked up
when generating asm-offsets.h, which causes the build to break:
AS arch/powerpc/kvm/booke_interrupts.o
arch/powerpc/kvm/booke_interrupts.S: Assembler messages:
arch/powerpc/kvm/booke_interrupts.S:347: Error: unsupported relocation
against VCPU_HOST_TLB
arch/powerpc/kvm/booke_interrupts.S:348: Error: unsupported relocation
against VCPU_SHADOW_TLB
make[1]: *** [arch/powerpc/kvm/booke_interrupts.o] Error 1
Changing it to ifdef CONFIG_KVM_POWERPC (which is a bool) seems to do
the right thing.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-02-01 19:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 1:08 [kvm-ppc-devel] [RFC PATCH] KVM for PowerPC: simpler TLB handling, Hollis Blanchard
2008-01-25 1:08 ` [RFC PATCH] KVM for PowerPC: simpler TLB handling, better page management Hollis Blanchard
2008-02-01 19:07 ` Nathan Lynch [this message]
2008-02-01 19:07 ` [kvm-ppc-devel] " Nathan Lynch
2008-02-01 19:17 ` [kvm-ppc-devel] [RFC PATCH] KVM for PowerPC: simpler Hollis Blanchard
2008-02-01 19:17 ` [kvm-ppc-devel] [RFC PATCH] KVM for PowerPC: simpler TLB handling, better page management Hollis Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080201190754.GZ14201@localdomain \
--to=ntl@pobox.com \
--cc=hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.