grub_cmdline_get() i18n problem

grub_cmdline_get() i18n problem

[Oleg Strikov]

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

Good day!

Let's look at grub_cmdline_get() func code:

/* normal/cmdline.c  - line 300 */
plen = grub_utf8_strlen (prompt);
  lpos = llen = 0;
  buf[0] = '\0';

  if ((grub_getxy () >> 8) != 0)
    grub_putchar ('\n');

  grub_printf (prompt);

  xpos = plen;

Idea is very simple - we move cursor `plen` times.
All is OK when `promt` contains only ASCII symblos. If we use UTF8 strings -
we get incorrect cursor moving (grub_strlen returns incorrect length due to
UTF-8 symbol floating byte size).
There are two ways:
* encode smth like grub_utf8_strlen ()
* modify grub_strlen () func and add this feature

I do my best to solve this problem, but what way do you recommend?

Thanks

[-- Attachment #2: Type: text/html, Size: 849 bytes --]

Re: grub_cmdline_get() i18n problem

[Robert Millan]

On Fri, Feb 01, 2008 at 09:19:57PM +0000, Oleg Strikov wrote:
> There are two ways:
> * encode smth like grub_utf8_strlen ()
> * modify grub_strlen () func and add this feature
> 
> I do my best to solve this problem, but what way do you recommend?

The convention is to match the posix equivalents, then grub_strlen() for counting
bytes, so I'd suggest the first.

But, are you sure we don't have this already?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)

Re: grub_cmdline_get() i18n problem

[Yoshinori K. Okuji]

On Friday 01 February 2008 22:19, Oleg Strikov wrote:
> Good day!
>
> Let's look at grub_cmdline_get() func code:
>
> /* normal/cmdline.c  - line 300 */
> plen = grub_utf8_strlen (prompt);
>   lpos = llen = 0;
>   buf[0] = '\0';
>
>   if ((grub_getxy () >> 8) != 0)
>     grub_putchar ('\n');
>
>   grub_printf (prompt);
>
>   xpos = plen;
>
> Idea is very simple - we move cursor `plen` times.
> All is OK when `promt` contains only ASCII symblos. If we use UTF8 strings
> - we get incorrect cursor moving (grub_strlen returns incorrect length due
> to UTF-8 symbol floating byte size).
> There are two ways:
> * encode smth like grub_utf8_strlen ()
> * modify grub_strlen () func and add this feature
>
> I do my best to solve this problem, but what way do you recommend?

PROMPT is always in ASCII. This was my assumption. Is it bad?

Okuji

Re: grub_cmdline_get() i18n problem

[Oleg Strikov]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

>
> PROMPT is always in ASCII. This was my assumption. Is it bad?
>
> Okuji
>

Possibly, it is not so bad, but unexpectedly.
It seems (e.g. to me) that grub_cmdline_get() simply makes grub_printf()
call (without any `byte length` restrictions).

Furthermore, if user wanna make `i18n prompt request` in his native language
module we incline him to use separate grub_printf() & grub_cmdline_get("" -
prompt) calls.

[-- Attachment #2: Type: text/html, Size: 618 bytes --]