Re: [PATCH 4/9] libata: normalize port_info, port_operations and sht tables

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

> * Every driver for SFF controllers now uses ata_pci_default_filter()
>   unless the driver has custom implementation.

That is only needed for DMA capable devices. I guess it does no harm to
be consistent and call it anyway but you then say ..

> * No reason to set ata_pci_default_filter() for PIO-only drivers.

and your patches add the calls for the CS5520 ?


> diff --git a/drivers/ata/pata_cs5520.c b/drivers/ata/pata_cs5520.c
> index 972ed9f..5614e76 100644
> --- a/drivers/ata/pata_cs5520.c
> +++ b/drivers/ata/pata_cs5520.c
> @@ -160,6 +160,7 @@ static struct scsi_host_template cs5520_sht = {
>  static struct ata_port_operations cs5520_port_ops = {
>  	.set_piomode		= cs5520_set_piomode,
>  	.set_dmamode		= cs5520_set_dmamode,
> +	.mode_filter		= ata_pci_default_filter,

This case is wrong. CS5520 doesn't do DMA (just VDMA which we don't
support) and in addition doesn't use BAR4 so its not a generic PCI
controller and this is asking for trouble later.

> diff --git a/drivers/ata/pata_opti.c b/drivers/ata/pata_opti.c
> index 8f79447..ebb9dc1 100644
> --- a/drivers/ata/pata_opti.c
> +++ b/drivers/ata/pata_opti.c
> @@ -184,6 +184,7 @@ static struct scsi_host_template opti_sht = {
>  
>  static struct ata_port_operations opti_port_ops = {
>  	.set_piomode	= opti_set_piomode,
> +	.mode_filter	= ata_pci_default_filter,

PIO only


> --- a/drivers/ata/pata_rz1000.c
> +++ b/drivers/ata/pata_rz1000.c
> @@ -72,6 +72,7 @@ static struct scsi_host_template rz1000_sht = {
>  
>  static struct ata_port_operations rz1000_port_ops = {
>  	.set_mode	= rz1000_set_mode,
> +	.mode_filter	= ata_pci_default_filter,

PIO only