Re: [PATCH 5/9] libata: implement and use SHT initializers and ops inheritance

[Mark Lord <liml@rtr.ca>]

Tejun Heo wrote:
> libata lets low level drivers build scsi_host_template and
> ata_port_operations tables and register them with upper layers.  This
> allows low level drivers high level of flexibility but also burdens
> them with lots of boilerplate entries in thoes data structures.
..
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index 939bf1d..c365650 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -452,61 +452,28 @@ static void mv_channel_reset(struct mv_host_priv *hpriv, void __iomem *mmio,
>  			     unsigned int port_no);
>  
>  static struct scsi_host_template mv5_sht = {
> -	.module			= THIS_MODULE,
> -	.name			= DRV_NAME,
> -	.ioctl			= ata_scsi_ioctl,
> -	.queuecommand		= ata_scsi_queuecmd,
> -	.can_queue		= ATA_DEF_QUEUE,
> -	.this_id		= ATA_SHT_THIS_ID,
> +	ATA_BASE_SHT(DRV_NAME),
>  	.sg_tablesize		= MV_MAX_SG_CT / 2,
..

I think this will need to be re-diff'd against the latest sata_mv,
which now has NCQ support.

Cheers