Re: [PATCH] to make grub2 compile on NetBSD

[Robert Millan <rmh@aybabtu.com>]

On Mon, Feb 04, 2008 at 12:21:11PM -0800, walt wrote:
> 
> On Mon, 2008-02-04 at 16:56 +0100, Marco Gerards wrote:
> > walt <wa1ter@myrealbox.com> writes:
> > 
> > > NetBSD's gcc wants libgcc and libc to define __enable_execute_stack,
> > > but this is useless for a free-standing executable like grub.  Define
> > > a dummy function in lieu of libgcc to supply __enable_execute_stack.
> 
> > ...  If this is for NetBSD only,
> > shouldn't you add a #ifdef instead of a comment?
> 
> Second try:
> 
> 	Make NetBSD's gcc happy.
> 
> 	* kern/mm.c: New dummy symbol __enable_execute_stack.
> 	(include/grub/mm.h): Likewise.

This ChangeLog entry seems wrong.  I'll write it up for you, as it's easier to
explain with an example:

	Make NetBSD's gcc happy.

	* include/grub/mm.h
	[__NetBSD__] (__enable_execute_stack): New function prototype.
	* kern/mm.c
	[__NetBSD__] (__enable_execute_stack): New function.

> +#ifdef __NetBSD__
> +/* Dummy symbol to make gcc happy. */
> +void
> +__enable_execute_stack(void)

Missing space here       ^

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)