From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: xen-devel@lists.xensource.com
Subject: Re: [PATCH] x86_emulate: fix side-effect macro call
Date: Tue, 5 Feb 2008 15:37:22 +0000 [thread overview]
Message-ID: <20080205153722.GG4322@implementation.uk.xensource.com> (raw)
In-Reply-To: <20080205153355.GA10999@implementation.uk.xensource.com>
Samuel Thibault, le Tue 05 Feb 2008 15:33:55 +0000, a écrit :
> x86_emulate: fix side-effect macro call
> Both jmp_rel and insn_fetch_type increment eip, so it's not
> compiler-safe to nest the calls.
Another way to fix it would be to change jmp_rel:
- _regs.eip += (int)(rel);
+ int _rel = (int)(rel);
+ _regs.eip += _rel;
Samuel
prev parent reply other threads:[~2008-02-05 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 15:33 [PATCH] x86_emulate: fix side-effect macro call Samuel Thibault
2008-02-05 15:37 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080205153722.GG4322@implementation.uk.xensource.com \
--to=samuel.thibault@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.