From: Andrew Morton <akpm@linux-foundation.org>
To: Dmitry Torokhov <dtor@insightbb.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] Input updates for 2.6.25-rc0
Date: Tue, 5 Feb 2008 22:32:42 -0800 [thread overview]
Message-ID: <20080205223242.f444fad6.akpm@linux-foundation.org> (raw)
In-Reply-To: <200802060108.31644.dtor@insightbb.com>
Looks OK. Minorish things from a quick scan:
tosakbd_scankeyboard() looks like it'll spend a perfectly wicked amount of
time under spin_lock_irqsave().
This code, in tosakbd_probe():
+fail2:
+ while (--i >= 0)
+ gpio_free(TOSA_GPIO_KEY_STROBE(i));
+
+ i = TOSA_KEY_SENSE_NUM;
+fail:
+ while (--i >= 0) {
+ free_irq(gpio_to_irq(TOSA_GPIO_KEY_SENSE(i)), pdev);
+ gpio_free(TOSA_GPIO_KEY_SENSE(i));
+ }
looks like it'll free irqs and gpios which were never allocated (if i <
TOSA_KEY_SENSE_NUM on entry).
+static int __devinit tosakbd_probe(struct platform_device *pdev) {
please integrate checkpatch into your merging process.
i8042_platform_init():
+#if defined(__i386__) || defined(__x86_64__)
use #ifdef CONFIG_X86?
next prev parent reply other threads:[~2008-02-06 6:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 6:08 [git pull] Input updates for 2.6.25-rc0 Dmitry Torokhov
2008-02-06 6:32 ` Andrew Morton [this message]
2008-02-06 6:49 ` Dmitry Torokhov
2008-02-06 7:56 ` Sam Ravnborg
2008-02-06 14:19 ` Dmitry Torokhov
2008-02-07 20:05 ` Dmitry Torokhov
2008-02-07 21:00 ` Andrew Morton
2008-02-06 7:00 ` Andrew Morton
2008-02-08 23:25 ` Ingo Molnar
2008-02-08 23:28 ` Stephen Hemminger
2008-02-08 23:37 ` [patch] " Randy Dunlap
2008-02-08 23:49 ` Jesper Juhl
2008-02-08 23:54 ` Andrew Morton
2008-02-09 0:00 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080205223242.f444fad6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dtor@insightbb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.