From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: Pavel Emelyanov <xemul@openvz.org>,
"Kok, Auke" <auke-jan.h.kok@intel.com>,
jesse.brandeburg@intel.com, jeffrey.t.kirsher@intel.com,
john.ronciak@intel.com, David Miller <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
e1000-devel@lists.sourceforge.net, Denis Lunev <den@openvz.org>,
Justin Piszcz <jpiszcz@lucidpixels.com>,
Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86_32: fix regression caused by trim ram according to mtrr on system with 4G more RAM
Date: Wed, 6 Feb 2008 10:51:07 +0100 [thread overview]
Message-ID: <20080206095107.GA30596@elte.hu> (raw)
In-Reply-To: <200802060149.26083.yinghai.lu@sun.com>
* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
> [PATCH] x86_32: fix regression caused by trim ram according to mtrr on system with 4G more RAM
>
> Pravel report:
> "
> The commit
>
> 093af8d7f0ba3c6be1485973508584ef081e9f93
> x86_32: trim memory by updating e820
>
> broke my e1000 card: on loading driver says that
>
> e1000: probe of 0000:04:03.0 failed with error -5
>
> and the interface doesn't appear.
> "
>
> on 32 bit kernel, base will overflow when try to do PAGE_SHIFT. and
> highest_addr will always less 4G.
>
> so use pfn instead of address to avoid overflow when more than 4g
> ram installed on 32bit kernel
> Many thanks for Pavel Emelyanov to report and test it.
thanks guys, applied.
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: "Kok, Auke" <auke-jan.h.kok@intel.com>,
e1000-devel@lists.sourceforge.net,
Linux Netdev List <netdev@vger.kernel.org>,
jesse.brandeburg@intel.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
john.ronciak@intel.com, jeffrey.t.kirsher@intel.com,
Denis Lunev <den@openvz.org>,
Thomas Gleixner <tglx@linutronix.de>,
David Miller <davem@davemloft.net>,
Justin Piszcz <jpiszcz@lucidpixels.com>,
Pavel Emelyanov <xemul@openvz.org>
Subject: Re: [PATCH] x86_32: fix regression caused by trim ram according to mtrr on system with 4G more RAM
Date: Wed, 6 Feb 2008 10:51:07 +0100 [thread overview]
Message-ID: <20080206095107.GA30596@elte.hu> (raw)
In-Reply-To: <200802060149.26083.yinghai.lu@sun.com>
* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
> [PATCH] x86_32: fix regression caused by trim ram according to mtrr on system with 4G more RAM
>
> Pravel report:
> "
> The commit
>
> 093af8d7f0ba3c6be1485973508584ef081e9f93
> x86_32: trim memory by updating e820
>
> broke my e1000 card: on loading driver says that
>
> e1000: probe of 0000:04:03.0 failed with error -5
>
> and the interface doesn't appear.
> "
>
> on 32 bit kernel, base will overflow when try to do PAGE_SHIFT. and
> highest_addr will always less 4G.
>
> so use pfn instead of address to avoid overflow when more than 4g
> ram installed on 32bit kernel
> Many thanks for Pavel Emelyanov to report and test it.
thanks guys, applied.
Ingo
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-02-06 9:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 17:18 [e1000][net-2.6 tree] Regression: driver doesn't detect card on my node Pavel Emelyanov
2008-02-05 17:24 ` Kok, Auke
2008-02-05 17:43 ` Yinghai Lu
2008-02-06 7:10 ` Pavel Emelyanov
2008-02-06 8:20 ` Yinghai Lu
2008-02-06 8:41 ` Pavel Emelyanov
2008-02-06 9:19 ` Yinghai Lu
2008-02-06 9:30 ` Pavel Emelyanov
2008-02-06 9:49 ` [PATCH] x86_32: fix regression caused by trim ram according to mtrr on system with 4G more RAM Yinghai Lu
2008-02-06 9:51 ` Ingo Molnar [this message]
2008-02-06 9:51 ` Ingo Molnar
2008-02-06 7:27 ` [e1000][net-2.6 tree] Regression: driver doesn't detect card on my node Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080206095107.GA30596@elte.hu \
--to=mingo@elte.hu \
--cc=Yinghai.Lu@Sun.COM \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=den@openvz.org \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=jpiszcz@lucidpixels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.