From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Bug#461442: detection of other OSes in update-grub
Date: Wed, 6 Feb 2008 13:02:04 +0100 [thread overview]
Message-ID: <20080206120204.GA22114@thorin> (raw)
In-Reply-To: <47A9881C.70908@leat.rub.de>
On Wed, Feb 06, 2008 at 11:12:44AM +0100, Fabian Greffrath wrote:
> I do not believe this is an overkill. Do you want grub-probe to print
> "i-dont-check-my-arguments" (grub-probe --target=device --device
> i-dont-check-my-arguments) ?
> Even worse, if you select another target than 'device' and if you don't
> check if the given parameter is *really* a device name, you will pass
> the faulty parameter over to the other functions that are called in
> probe () and fail with some "cannot stat ..." message . In my opinion
> this should not happen. Instead, grub-probe should fail gracefully with
> a dedicated error messge in this situation as proposed by my patch.
Ok, I don't mind that much.
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)
next prev parent reply other threads:[~2008-02-06 12:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 10:12 Bug#461442: detection of other OSes in update-grub Fabian Greffrath
2008-02-06 12:02 ` Robert Millan [this message]
[not found] <4790C888.6040007@leat.rub.de>
[not found] ` <87sl0v6iod.fsf@ossystems.com.br>
[not found] ` <20080119114939.GB10722@thorin>
[not found] ` <479450A9.90601@leat.rub.de>
[not found] ` <20080121112448.GD7378@thorin>
[not found] ` <47948422.8000208@leat.rub.de>
[not found] ` <20080121121828.GA9244@thorin>
[not found] ` <4795B435.20102@leat.rub.de>
[not found] ` <20080122124642.GC2017@thorin>
2008-01-22 13:14 ` Fabian Greffrath
2008-01-22 16:56 ` Robert Millan
2008-01-30 10:41 ` Fabian Greffrath
2008-01-30 19:48 ` Robert Millan
2008-01-31 8:31 ` Fabian Greffrath
2008-01-31 10:10 ` Otavio Salvador
2008-01-31 11:58 ` Robert Millan
2008-01-31 14:26 ` Fabian Greffrath
2008-01-31 14:39 ` Robert Millan
2008-02-04 8:43 ` Fabian Greffrath
2008-02-04 14:18 ` Robert Millan
2008-02-04 14:47 ` Fabian Greffrath
2008-02-04 15:04 ` Robert Millan
2008-02-04 15:27 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080206120204.GA22114@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.