From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Paul Knowles <paul-1LojSYAwM1QXQ3Lr6voeyA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] Fix to kvm_arch_vcpu_ioctl_set_sregs so that set_cr0 works properly
Date: Wed, 6 Feb 2008 21:21:42 +0100 [thread overview]
Message-ID: <20080206202142.GB6344@8bytes.org> (raw)
In-Reply-To: <1DF02D2D-98D0-4695-A4A5-724A12616142-1LojSYAwM1QXQ3Lr6voeyA@public.gmane.org>
On Wed, Feb 06, 2008 at 11:02:35AM +0000, Paul Knowles wrote:
> mmu_reset_needed |= vcpu->arch.cr0 != sregs->cr0;
> - vcpu->arch.cr0 = sregs->cr0;
> kvm_x86_ops->set_cr0(vcpu, sregs->cr0);
Why should this fix anything? The vcpu->arch.cr0 is also set in
kvm_x86_ops->set_cr0() aka vmx_set_cr0() and its not touched on the path
to it?
Btw, I think its very likely that you set an invalid guest state with
your set_sregs ioctl (e.g. an impossible hardware register state).
Starting a guest in PAE mode is basically working because otherwise live
migration of PAE guests won't work.
Joerg
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-02-06 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 11:02 [PATCH] Fix to kvm_arch_vcpu_ioctl_set_sregs so that set_cr0 works properly Paul Knowles
[not found] ` <1DF02D2D-98D0-4695-A4A5-724A12616142-1LojSYAwM1QXQ3Lr6voeyA@public.gmane.org>
2008-02-06 20:21 ` Joerg Roedel [this message]
[not found] ` <20080206202142.GB6344-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2008-02-07 8:55 ` Paul Knowles
[not found] ` <E1C3584C-9A8E-4F97-9C7A-DA709B8A85CB-1LojSYAwM1QXQ3Lr6voeyA@public.gmane.org>
2008-02-07 10:32 ` Joerg Roedel
2008-02-11 8:11 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080206202142.GB6344@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=paul-1LojSYAwM1QXQ3Lr6voeyA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.