From: Avi Kivity <avi@qumranet.com>
To: Paul Knowles <paul@transitive.com>
Cc: kvm-devel@lists.sourceforge.net
Subject: Re: [PATCH] Fix to kvm_arch_vcpu_ioctl_set_sregs so that set_cr0 works properly
Date: Mon, 11 Feb 2008 10:11:20 +0200 [thread overview]
Message-ID: <47B00328.7010906@qumranet.com> (raw)
In-Reply-To: <1DF02D2D-98D0-4695-A4A5-724A12616142@transitive.com>
Paul Knowles wrote:
> Whilst working on getting a VM to initialize in to IA32e mode I found
> this issue. set_cr0 relies on comparing the old cr0 to the new one to
> work correctly.
>
>
Applied, thanks. I moved the assignment below rather than deleting it
to be a little more conservative (svm_set_cr0 doesn't always actually
set cr0 these days).
> Whilst this fix gets me a little closer I still fail to run due to an
> invalid VMX state. Has anybody else ever tried to set up a VM to jump
> straight in to IA32e mode?
>
Sure. Initially kvm only did long mode, and these days when you live
migrate (or save/restore) a long mode guest you are effectively starting
the new instance in long mode.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
prev parent reply other threads:[~2008-02-11 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 11:02 [PATCH] Fix to kvm_arch_vcpu_ioctl_set_sregs so that set_cr0 works properly Paul Knowles
[not found] ` <1DF02D2D-98D0-4695-A4A5-724A12616142-1LojSYAwM1QXQ3Lr6voeyA@public.gmane.org>
2008-02-06 20:21 ` Joerg Roedel
[not found] ` <20080206202142.GB6344-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2008-02-07 8:55 ` Paul Knowles
[not found] ` <E1C3584C-9A8E-4F97-9C7A-DA709B8A85CB-1LojSYAwM1QXQ3Lr6voeyA@public.gmane.org>
2008-02-07 10:32 ` Joerg Roedel
2008-02-11 8:11 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B00328.7010906@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=paul@transitive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.