From: "Daniel P. Berrange" <berrange@redhat.com>
To: Samuel Thibault <samuel.thibault@eu.citrix.com>,
xen-devel@lists.xensource.com
Subject: Re: [PATCH] ioemu: make daemonize optional
Date: Thu, 7 Feb 2008 14:37:54 +0000 [thread overview]
Message-ID: <20080207143754.GE30230@redhat.com> (raw)
In-Reply-To: <20080207142251.GF9343@implementation.uk.xensource.com>
On Thu, Feb 07, 2008 at 02:22:51PM +0000, Samuel Thibault wrote:
> ioemu: make daemonize optional
Why ? Littering up the source code with lots of #ifdef isn't
very nice for maintainance. Can we at least have some explanation
of the actual need for these changes along with the patch.
NB, I'm not against the patch - when looking through changelogs it just
helps to have good description of the reasoning behind the change, and
in this case 'make daemonize optional' doesn't tell me anything over and
above what the diff itself shows.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
next prev parent reply other threads:[~2008-02-07 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-07 14:22 [PATCH] ioemu: make daemonize optional Samuel Thibault
2008-02-07 14:37 ` Daniel P. Berrange [this message]
2008-02-07 14:47 ` Samuel Thibault
2008-02-08 12:52 ` Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080207143754.GE30230@redhat.com \
--to=berrange@redhat.com \
--cc=samuel.thibault@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.