All of lore.kernel.org
 help / color / mirror / Atom feed
* - dz-always-check-if-it-is-safe-to-console_putchar.patch removed from -mm tree
@ 2008-02-08  8:06 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2008-02-08  8:06 UTC (permalink / raw)
  To: macro, jirislaby, mm-commits


The patch titled
     dz: always check if it is safe to console_putchar()
has been removed from the -mm tree.  Its filename was
     dz-always-check-if-it-is-safe-to-console_putchar.patch

This patch was dropped because it was merged into mainline or a subsystem tree

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: dz: always check if it is safe to console_putchar()
From: "Maciej W. Rozycki" <macro@linux-mips.org>

Polled transmission is tricky enough with the DZ11 design.  While "loop" is
set to a high value, conceptually you are not allowed to transmit without
checking whether the device offers the right transmission line (yes, it is the
device that selects the line -- the driver has no control over it other than
disabling the transmitter offered if it is the wrong one), so the loop has to
be run at least once.

Well, the '1977 or PDP11 view of how serial lines should be handled...  Except
that the serial interface used to be quite an impressive board back then
rather than chip.

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
Cc: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/serial/dz.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff -puN drivers/serial/dz.c~dz-always-check-if-it-is-safe-to-console_putchar drivers/serial/dz.c
--- a/drivers/serial/dz.c~dz-always-check-if-it-is-safe-to-console_putchar
+++ a/drivers/serial/dz.c
@@ -685,7 +685,7 @@ static void dz_console_putchar(struct ua
 	iob();
 	spin_unlock_irqrestore(&dport->port.lock, flags);
 
-	while (loops--) {
+	do {
 		trdy = dz_in(dport, DZ_CSR);
 		if (!(trdy & DZ_TRDY))
 			continue;
@@ -696,7 +696,7 @@ static void dz_console_putchar(struct ua
 		dz_out(dport, DZ_TCR, mask);
 		iob();
 		udelay(2);
-	}
+	} while (loops--);
 
 	if (loops)				/* Cannot send otherwise. */
 		dz_out(dport, DZ_TDR, ch);
_

Patches currently in -mm which might be from macro@linux-mips.org are

origin.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-02-08  8:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-08  8:06 - dz-always-check-if-it-is-safe-to-console_putchar.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.