From: Ivo van Doorn <ivdoorn@gmail.com>
To: rt2400-devel@lists.sourceforge.net
Cc: "Randy Dunlap" <randy.dunlap@oracle.com>,
linux-wireless@vger.kernel.org,
"Michael Büker" <m.bueker@berlin.de>,
linux-kernel@vger.kernel.org, akpm <akpm@linux-foundation.org>,
linville@tuxdriver.com
Subject: Re: [Rt2400-devel] [PATCH] wireless: rt2x00: fix driver menu indenting
Date: Sun, 10 Feb 2008 20:03:25 +0100 [thread overview]
Message-ID: <200802102003.25392.IvDoorn@gmail.com> (raw)
In-Reply-To: <20080210105252.e0a433ee.randy.dunlap@oracle.com>
On Sunday 10 February 2008, Randy Dunlap wrote:
> On Sat, 9 Feb 2008 16:23:06 +0100 Michael B=FCker wrote:
>=20
> > 2) When selecting "Ralink driver support" (CONFIG_RT2X00), the acco=
mpanying=20
> > drivers (CONFIG_RT2400PCI, CONFIG_RT61PC, ...) appear unindented. T=
hey should=20
> > be indented by four spaces.
>=20
> Yes, patch is below.
>=20
> ---
> From: Randy Dunlap <randy.dunlap@oracle.com>
>=20
> Michael B=FCker <m.bueker@berlin.de> reports that the RT2x00 drivers
> are not indented as they should be, so use proper dependencies to mak=
e
> them be indented as expected.
>=20
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Ack-by: Ivo van Doorn <IvDoorn@gmail.com>
---
John,
Could you push this directly into wireless-2.6 and probably upstream as=
well.
Thanks.
Ivo
> ---
> drivers/net/wireless/rt2x00/Kconfig | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>=20
> --- linux-2.6.24-git21.orig/drivers/net/wireless/rt2x00/Kconfig
> +++ linux-2.6.24-git21/drivers/net/wireless/rt2x00/Kconfig
> @@ -11,18 +11,17 @@ config RT2X00
> will also be created. That library (when the driver is built as
> a module) will be called "rt2x00lib.ko".
> =20
> +if RT2X00
> +
> config RT2X00_LIB
> tristate
> - depends on RT2X00
> =20
> config RT2X00_LIB_PCI
> tristate
> - depends on RT2X00
> select RT2X00_LIB
> =20
> config RT2X00_LIB_USB
> tristate
> - depends on RT2X00
> select RT2X00_LIB
> =20
> config RT2X00_LIB_FIRMWARE
> @@ -39,7 +38,7 @@ config RT2X00_LIB_RFKILL
> =20
> config RT2400PCI
> tristate "Ralink rt2400 pci/pcmcia support"
> - depends on RT2X00 && PCI
> + depends on PCI
> select RT2X00_LIB_PCI
> select EEPROM_93CX6
> ---help---
> @@ -58,7 +57,7 @@ config RT2400PCI_RFKILL
> =20
> config RT2500PCI
> tristate "Ralink rt2500 pci/pcmcia support"
> - depends on RT2X00 && PCI
> + depends on PCI
> select RT2X00_LIB_PCI
> select EEPROM_93CX6
> ---help---
> @@ -77,7 +76,7 @@ config RT2500PCI_RFKILL
> =20
> config RT61PCI
> tristate "Ralink rt61 pci/pcmcia support"
> - depends on RT2X00 && PCI
> + depends on PCI
> select RT2X00_LIB_PCI
> select RT2X00_LIB_FIRMWARE
> select EEPROM_93CX6
> @@ -97,7 +96,7 @@ config RT61PCI_RFKILL
> =20
> config RT2500USB
> tristate "Ralink rt2500 usb support"
> - depends on RT2X00 && USB
> + depends on USB
> select RT2X00_LIB_USB
> ---help---
> This is an experimental driver for the Ralink rt2500 wireless chi=
p.
> @@ -106,7 +105,7 @@ config RT2500USB
> =20
> config RT73USB
> tristate "Ralink rt73 usb support"
> - depends on RT2X00 && USB
> + depends on USB
> select RT2X00_LIB_USB
> select RT2X00_LIB_FIRMWARE
> ---help---
> @@ -128,3 +127,4 @@ config RT2X00_DEBUG
> ---help---
> Enable debugging output for all rt2x00 modules
> =20
> +endif
>=20
> ---------------------------------------------------------------------=
----
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Rt2400-devel mailing list
> Rt2400-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/rt2400-devel
>=20
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Ivo van Doorn <ivdoorn@gmail.com>
To: rt2400-devel@lists.sourceforge.net
Cc: "Randy Dunlap" <randy.dunlap@oracle.com>,
linux-wireless@vger.kernel.org,
"Michael Büker" <m.bueker@berlin.de>,
linux-kernel@vger.kernel.org, akpm <akpm@linux-foundation.org>,
linville@tuxdriver.com
Subject: Re: [Rt2400-devel] [PATCH] wireless: rt2x00: fix driver menu indenting
Date: Sun, 10 Feb 2008 20:03:25 +0100 [thread overview]
Message-ID: <200802102003.25392.IvDoorn@gmail.com> (raw)
In-Reply-To: <20080210105252.e0a433ee.randy.dunlap@oracle.com>
On Sunday 10 February 2008, Randy Dunlap wrote:
> On Sat, 9 Feb 2008 16:23:06 +0100 Michael Büker wrote:
>
> > 2) When selecting "Ralink driver support" (CONFIG_RT2X00), the accompanying
> > drivers (CONFIG_RT2400PCI, CONFIG_RT61PC, ...) appear unindented. They should
> > be indented by four spaces.
>
> Yes, patch is below.
>
> ---
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Michael Büker <m.bueker@berlin.de> reports that the RT2x00 drivers
> are not indented as they should be, so use proper dependencies to make
> them be indented as expected.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Ack-by: Ivo van Doorn <IvDoorn@gmail.com>
---
John,
Could you push this directly into wireless-2.6 and probably upstream as well.
Thanks.
Ivo
> ---
> drivers/net/wireless/rt2x00/Kconfig | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> --- linux-2.6.24-git21.orig/drivers/net/wireless/rt2x00/Kconfig
> +++ linux-2.6.24-git21/drivers/net/wireless/rt2x00/Kconfig
> @@ -11,18 +11,17 @@ config RT2X00
> will also be created. That library (when the driver is built as
> a module) will be called "rt2x00lib.ko".
>
> +if RT2X00
> +
> config RT2X00_LIB
> tristate
> - depends on RT2X00
>
> config RT2X00_LIB_PCI
> tristate
> - depends on RT2X00
> select RT2X00_LIB
>
> config RT2X00_LIB_USB
> tristate
> - depends on RT2X00
> select RT2X00_LIB
>
> config RT2X00_LIB_FIRMWARE
> @@ -39,7 +38,7 @@ config RT2X00_LIB_RFKILL
>
> config RT2400PCI
> tristate "Ralink rt2400 pci/pcmcia support"
> - depends on RT2X00 && PCI
> + depends on PCI
> select RT2X00_LIB_PCI
> select EEPROM_93CX6
> ---help---
> @@ -58,7 +57,7 @@ config RT2400PCI_RFKILL
>
> config RT2500PCI
> tristate "Ralink rt2500 pci/pcmcia support"
> - depends on RT2X00 && PCI
> + depends on PCI
> select RT2X00_LIB_PCI
> select EEPROM_93CX6
> ---help---
> @@ -77,7 +76,7 @@ config RT2500PCI_RFKILL
>
> config RT61PCI
> tristate "Ralink rt61 pci/pcmcia support"
> - depends on RT2X00 && PCI
> + depends on PCI
> select RT2X00_LIB_PCI
> select RT2X00_LIB_FIRMWARE
> select EEPROM_93CX6
> @@ -97,7 +96,7 @@ config RT61PCI_RFKILL
>
> config RT2500USB
> tristate "Ralink rt2500 usb support"
> - depends on RT2X00 && USB
> + depends on USB
> select RT2X00_LIB_USB
> ---help---
> This is an experimental driver for the Ralink rt2500 wireless chip.
> @@ -106,7 +105,7 @@ config RT2500USB
>
> config RT73USB
> tristate "Ralink rt73 usb support"
> - depends on RT2X00 && USB
> + depends on USB
> select RT2X00_LIB_USB
> select RT2X00_LIB_FIRMWARE
> ---help---
> @@ -128,3 +127,4 @@ config RT2X00_DEBUG
> ---help---
> Enable debugging output for all rt2x00 modules
>
> +endif
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Rt2400-devel mailing list
> Rt2400-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/rt2400-devel
>
next prev parent reply other threads:[~2008-02-10 19:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-09 15:23 Two comments on menuconfig usability Michael Büker
2008-02-10 18:52 ` [PATCH] wireless: rt2x00: fix driver menu indenting Randy Dunlap
2008-02-10 18:52 ` Randy Dunlap
2008-02-10 19:03 ` Ivo van Doorn [this message]
2008-02-10 19:03 ` [Rt2400-devel] " Ivo van Doorn
2008-03-05 6:00 ` Randy Dunlap
2008-03-05 6:00 ` Randy Dunlap
2008-03-05 18:11 ` John W. Linville
2008-03-05 18:11 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802102003.25392.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=m.bueker@berlin.de \
--cc=randy.dunlap@oracle.com \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.