Re: [PATCH] e2fsprogs: New bitmap and inode table allocation for FLEX_BG

[Theodore Tso <tytso@MIT.EDU>]

On Fri, Feb 08, 2008 at 11:37:40AM -0600, Jose R. Santos wrote:
> > >  #define EXT2_BG_INODE_UNINIT	0x0001 /* Inode table/bitmap not initialized */
> > >  #define EXT2_BG_BLOCK_UNINIT	0x0002 /* Block bitmap not initialized */
> > > +#define EXT2_BG_FLEX_METADATA	0x0004 /* FLEX_BG block group contains meta-data */
> > 
> > Hrm, I thought I had reserved that value in the uninit_groups patch?
> > +#define EXT3_BG_INODE_ZEROED   0x0004  /* On-disk itable initialized to zero */
> 
> I may have been, I just based the patch on the next branch as Ted had
> ask for new e2fsprog patches.  The uninit group patch was not part of
> the next branch when I pulled.

Yes, but whenever you start reserving code points that impact the
on-disk format, you need to be careful and coordinate.  Exactly is the
purpose of this flag, and why is it here?

And I don't see any patch in the kernel patch queue that uses this
flag.  Is this intended for internal use inside e2fsprogs?  If so,
this might not be the best place for it.....

     	       	      	   	     - Ted