Re: [PATCH][e2fsprogs] New bitmap and inode table allocation for FLEX_BG

[Theodore Tso <tytso@MIT.EDU>]

On Thu, Apr 03, 2008 at 09:28:58AM -0500, Jose R. Santos wrote:
> I blame Undo Manager for being so slow that cause me to skip some of
> the testing needed to be done.  

If that means we need a patch to disable the undo manager, via a
command-line option, feel free.  :-)

> I was incorrectly checking the feature
> flag instead of checking the value of fs->super->s_log_groups_per_flex.

Actually, you should check both, and we need to make mke2fs have an
intelligent default, which can be overridden via mke2fs.conf.

Also, it looks like this patch doesn't create a valid filesystem in
combination with meta_bg:

mke2fs G 32 -O meta_bg,flex_bg,uninit_groups,^resize_inode /tmp/foo.img

Then try running "e2fsck -f /tmp/foo.img" with the patch applied.

One obvious question is why is this patch so fragile....?  Is there
some way we can make it more likely not to break given other changes
to e2fsprogs in the future.

						- Ted