From: Pete Wyckoff <pw@osc.edu>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-scsi@vger.kernel.org
Subject: [PATCH] bsg: bidi bio map failure fix
Date: Tue, 12 Feb 2008 15:40:24 -0500 [thread overview]
Message-ID: <20080212204024.GA13643@osc.edu> (raw)
If blk_rq_map_user requires more than one bio, and fails mapping
somewhere after the first bio, it will return with rq->bio set to
non-NULL, but it will have already unmapped the partial bio. The
"out:" error exit section will see the non-null bio and try to unmap
it again, triggering a mapcount bug via bad_page().
Signed-off-by: Pete Wyckoff <pw@osc.edu>
---
block/bsg.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/block/bsg.c b/block/bsg.c
index 3337125..bba7154 100644
--- a/block/bsg.c
+++ b/block/bsg.c
@@ -295,8 +295,10 @@ bsg_map_hdr(struct bsg_device *bd, struct sg_io_v4 *hdr)
dxferp = (void*)(unsigned long)hdr->din_xferp;
ret = blk_rq_map_user(q, next_rq, dxferp, hdr->din_xfer_len);
- if (ret)
+ if (ret) {
+ next_rq->bio = NULL; /* do not unmap twice */
goto out;
+ }
}
if (hdr->dout_xfer_len) {
--
1.5.3.8
next reply other threads:[~2008-02-12 20:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 20:40 Pete Wyckoff [this message]
2008-02-12 21:12 ` [PATCH] bsg: bidi bio map failure fix James Bottomley
2008-02-18 12:55 ` Jens Axboe
2008-02-18 14:37 ` FUJITA Tomonori
2008-02-18 14:46 ` Jens Axboe
2008-02-18 15:09 ` James Bottomley
2008-02-18 15:24 ` FUJITA Tomonori
2008-02-18 17:25 ` Jens Axboe
2008-02-18 14:54 ` James Bottomley
2008-02-14 11:57 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080212204024.GA13643@osc.edu \
--to=pw@osc.edu \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.