From: FUJITA Tomonori <tomof@acm.org>
To: James.Bottomley@HansenPartnership.com
Cc: jens.axboe@oracle.com, tomof@acm.org, pw@osc.edu,
fujita.tomonori@lab.ntt.co.jp, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] bsg: bidi bio map failure fix
Date: Tue, 19 Feb 2008 00:24:37 +0900 [thread overview]
Message-ID: <20080219002439Y.tomof@acm.org> (raw)
In-Reply-To: <1203347347.3324.8.camel@localhost.localdomain>
On Mon, 18 Feb 2008 09:09:07 -0600
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> On Mon, 2008-02-18 at 15:46 +0100, Jens Axboe wrote:
> > Seems symmetric to me now, either we fail and everything is cleaned up,
> > or return success. What remains?
>
> My main symmetry complaint was the API: The map takes a request, the
> unmap takes a bio.
Yeah, it would be nice if we avoid such code:
blk_rq_map_user(q, rq, ...)
bio = rq->bio
blk_execute_rq(q, ...
blk_rq_unmap_user(bio);
I think that none of the users of blk_rq_map_user is interested in
bio, the details of how kernel manage I/Os. At least, we can remove
bio stuff in bsg if blk_rq_map_user and blk_rq_unmap_user take
requests.
next prev parent reply other threads:[~2008-02-18 15:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 20:40 [PATCH] bsg: bidi bio map failure fix Pete Wyckoff
2008-02-12 21:12 ` James Bottomley
2008-02-18 12:55 ` Jens Axboe
2008-02-18 14:37 ` FUJITA Tomonori
2008-02-18 14:46 ` Jens Axboe
2008-02-18 15:09 ` James Bottomley
2008-02-18 15:24 ` FUJITA Tomonori [this message]
2008-02-18 17:25 ` Jens Axboe
2008-02-18 14:54 ` James Bottomley
2008-02-14 11:57 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080219002439Y.tomof@acm.org \
--to=tomof@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=pw@osc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.