From: Andrew Morton <akpm@linux-foundation.org>
To: minyard@acm.org
Cc: linux-kernel@vger.kernel.org, kbaidarov@ru.mvista.com,
openipmi-developer@lists.sourceforge.net
Subject: Re: [PATCH 4/8] IPMI: Don't grab locks in run-to-completion mode
Date: Wed, 13 Feb 2008 15:22:12 -0800 [thread overview]
Message-ID: <20080213152212.814e1868.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080213162749.GD9830@minyard.local>
On Wed, 13 Feb 2008 10:27:49 -0600
Corey Minyard <minyard@acm.org> wrote:
> This patch prevents deadlocks in IPMI panic handler caused by msg_lock
> in smi_info structure and waiting_msgs_lock in ipmi_smi structure.
Again, what are the newly-added barrier()s for? Was cpu_relax()
intended?
If a barrier indeed was intended then, as always, each one should have
a comment explaining why it is there. Because it is frequently hard to
determine what the programmer was trying to do.
prev parent reply other threads:[~2008-02-13 23:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 16:27 [PATCH 4/8] IPMI: Don't grab locks in run-to-completion mode Corey Minyard
2008-02-13 23:22 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080213152212.814e1868.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=kbaidarov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.